Skip to content

AODBcRewriter: regroup tracks by collision so the -1 group stays contiguous#2370

Merged
ktf merged 1 commit into
masterfrom
pr2370
Jun 4, 2026
Merged

AODBcRewriter: regroup tracks by collision so the -1 group stays contiguous#2370
ktf merged 1 commit into
masterfrom
pr2370

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented Jun 2, 2026

No description provided.

@ktf ktf requested review from jackal1-66 and sawenzel as code owners June 2, 2026 13:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ktf
Copy link
Copy Markdown
Member Author

ktf commented Jun 2, 2026

@jgrosseo @jackal1-66 @sawenzel would this make sense? I assume this is the same as sort + uniq if the two collections of BCs are one a subset of the other.

@ktf
Copy link
Copy Markdown
Member Author

ktf commented Jun 2, 2026

I am actually not convinced this changes anything, actually...

@ktf ktf changed the title Do not resort the BC table, just remove the duplicates AODBcRewriter: regroup tracks by collision so the -1 group stays contiguous Jun 3, 2026
@ktf
Copy link
Copy Markdown
Member Author

ktf commented Jun 3, 2026

this one seems to produce a valid file...

@ktf ktf merged commit 28b44ef into master Jun 4, 2026
17 checks passed
@ktf ktf deleted the pr2370 branch June 4, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant