Create AbandonConfirmMenu.java and default item for plot-abandon to TNT#213
Merged
Conversation
Zoriot
requested changes
Apr 10, 2026
Member
Zoriot
left a comment
Zoriot
left a comment
There was a problem hiding this comment.
Not sure about the design, I also see it would make sense to have a separate "back" and "cancel" button, might be too much also.
Might make sense to ask Malte - because he often mass delete plot where this is a extra click (where you also have to readjust the mouse). If he wishes also a direct way we could add a permission for that.
Please fix the translation issue - the other stuff i mentioned are your own decision. Other than that LGTM - ty for implementing it
Zoriot
force-pushed
the
update/abandon-confirmation
branch
from
cf13262 to
3e8cfc7
Compare
Zoriot
approved these changes
May 18, 2026
Zoriot
force-pushed
the
update/abandon-confirmation
branch
from
3e8cfc7 to
ea86536
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of clicking on the abandon item in the PlotActionsMenu.
Now the button opens up a new confirmation menu where only after clicking on the abandon item again, will the plot be actually abandoned.
This is to prevent trigger happy users accidentally nuking their progress.
Additionally, this PR also changes the default item for the abandon item to TNT. Previously it was a barrier block.