Skip to content

fix(schematics): 🐛 prevent schematic truncation for plots exceeding world height #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zoriot merged 2 commits into from
May 23, 2026
Merged

fix(schematics): 🐛 prevent schematic truncation for plots exceeding world height #220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fc208e
fix(schematics): 🐛 prevent schematic truncation for plots exceeding w…
Zoriot May 22, 2026
63f5296
Merge branch 'main' into fix-focus-plots
Zoriot May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/main/java/com/alpsbte/plotsystem/core/system/plot/utils/PlotUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.UUID;
import java.util.concurrent.CompletableFuture;
Expand Down Expand Up @@ -207,7 +206,7 @@ public static boolean isPlotWorld(@NotNull World world) {
}

Polygonal2DRegion region = new Polygonal2DRegion(
BukkitAdapter.adapt(world),
null,
plot.getOutline(),
clipboard.getMinimumPoint().y(),
clipboard.getMaximumPoint().y()
Expand Down Expand Up @@ -259,14 +258,14 @@ public static boolean savePlotAsSchematic(@NotNull Plot plot) throws IOException
// Load finished plot region as cuboid region
if (!plot.getWorld().loadWorld()) return false;
com.sk89q.worldedit.world.World world = new BukkitWorld(plot.getWorld().getBukkitWorld());
Polygonal2DRegion region = new Polygonal2DRegion(world, plotOutlines, cuboidRegion.getMinimumPoint().y(), cuboidRegion.getMaximumPoint().y());
Polygonal2DRegion region = new Polygonal2DRegion(null, plotOutlines, cuboidRegion.getMinimumPoint().y(), cuboidRegion.getMaximumPoint().y());

// Copy and write finished plot clipboard to schematic
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
try (Clipboard cb = new BlockArrayClipboard(region)) {
cb.setOrigin(BlockVector3.at(plotCenter.x(), cuboidRegion.getMinimumY(), (double) plotCenter.z()));

ForwardExtentCopy forwardExtentCopy = new ForwardExtentCopy(Objects.requireNonNull(region.getWorld()), region, cb, region.getMinimumPoint());
ForwardExtentCopy forwardExtentCopy = new ForwardExtentCopy(world, region, cb, region.getMinimumPoint());
Operations.complete(forwardExtentCopy);

try (ClipboardWriter writer = AbstractPlot.CLIPBOARD_FORMAT.getWriter(outputStream)) {
Expand Down
Loading