This repository was archived by the owner on Jul 21, 2026. It is now read-only.
formulae: use SDK-owned cross-compilation settings - #106
Merged
Conversation
Member
Author
|
Independent source-diff and validation review: ACCEPT exact head The reviewer matched all 33 removed assignments to exact #874 Merge remains held on #874, #883, #879, and #873 as described; final bottle work remains separately gated. |
brandonpayton
force-pushed
the
formulae/consume-sdk-target-facts
branch
from
July 14, 2026 01:06
052e7df to
862a4cc
Compare
This was referenced Jul 14, 2026
brandonpayton
force-pushed
the
formulae/consume-sdk-target-facts
branch
from
July 16, 2026 19:43
862a4cc to
3132a4e
Compare
Cross-compiled packages need one reviewed source of truth for target behavior. Duplicating reusable configure answers in nine Formulae lets package recipes drift from the Kandelo SDK and can produce packages under inconsistent target assumptions. Remove the answers now owned by sdk/config.site from Gawk, Grep, Gzip, Libpng, M4, Make, Nano, Sed, and XZ. Keep the GNU Make package-specific synchronous posix_spawn probe because it tests behavior rather than reusable API availability.
brandonpayton
force-pushed
the
formulae/consume-sdk-target-facts
branch
from
July 17, 2026 02:34
3132a4e to
89bfdee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Kandelo cross-compiles packages for WebAssembly, so many upstream configure scripts cannot run their normal probe programs on the build machine. The Kandelo SDK supplies reviewed answers about the target in
sdk/config.site.Nine Formulae also carried 21 local assignments covering 15 distinct target facts. Two copies can drift: the SDK could say a function is unavailable while a package recipe says it is available, causing packages to build under inconsistent assumptions. Package authors should receive one target contract from the SDK instead of maintaining private copies.
What changed
Remove the SDK-owned configure answers from Gawk, Grep, Gzip, Libpng, M4, Make, Nano, Sed, and XZ.
GNU Make deliberately retains
make_cv_synchronous_posix_spawn=yes. That Make-specific probe checks whether a missing child reportsENOENTsynchronously. It is package behavior, not a reusable function-availability fact.No Formula revision is bumped. The candidate SDK supplies the same target answers before these lines are removed, so this changes ownership rather than intended package behavior. This PR contains no bottle block, archive, sidecar, receipt, provenance file, generated Wasm artifact, platform code, or Kandelo ABI change.
ABI 41 review evidence
a7d0d8ad92998a08a8bf1b03278e2189c01c2a0d89bfdeed1d4d5a13ff51b6bce3406b579c5728f5a77203cbc989cd257e1d6d3961cd2ceb76d869cea9a2a2092dedf8c7b8c2e35f06430489cd1d3c1e6efb411f15df83819a4e21a961845084f8860f6c, treeb133bfa018f7e2bc84c4845edf2f945b2f844954, andsdk/config.siteblobd8ea6e3f359419b004274784676db573ee08416cFresh checks covered all nine Formulae:
config.logfiles show the candidate SDK andsdk/config.sitesupplied the cross-target answers.git diff --checkpassed.This is source-build evidence. It does not claim that public bottles have been published, poured from GHCR, assembled into a VFS image, or run by stock Homebrew inside a guest.
Ordering and remaining gates
Automattic/kandelo#967 has merged. Its exact merged
sdk/config.siteblob matches all 15 facts removed here. This commit was restacked without patch changes onto current tapmain; range-diff, stable patch identity, and the Formula blobs are unchanged. A final independent review found no code blocker.Merge only after the fresh trust checks pass on the exact head above. Bottle publication remains a separate trusted-publisher operation with public readback, stock pour evidence, and Node.js/Chromium runtime validation.