Resolves Issue #1667, Org controller middleware registry flag parsing#1821
Open
afoote-mitre wants to merge 1 commit into
Open
Resolves Issue #1667, Org controller middleware registry flag parsing#1821afoote-mitre wants to merge 1 commit into
afoote-mitre wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #1667
Summary
The org controller middleware was incorrectly parsing the incoming registry flag value, leading to conditional logic that always evaluated as false regardless of what the flag was set to.
Important Changes
src/controller/org.controller/org.middleware.jsvalidateUserIdOrUsername()andvalidateUpdateOrgParameters()Testing
Steps to manually test updated functionality, if possible
npm run test:integrationand ensure all tests passnpm run test:unit-testsand ensure all tests pass