fixup! feat(core): surface the unsupported-version warning in CI

Author: not-matthias

packages/core/src/nodeVersion.ts

@@ -27,6 +27,17 @@ function escapeWorkflowCommandData(value: string): string {
   return value.replace(/%/g, "%25").replace(/\r/g, "%0D").replace(/\n/g, "%0A");
 }
 
+/**
+ * Properties are parsed out of the command header, where `:` ends the property
+ * list and `,` separates properties, so both need encoding on top of the data
+ * escaping.
+ */
+function escapeWorkflowCommandProperty(value: string): string {
+  return escapeWorkflowCommandData(value)
+    .replace(/:/g, "%3A")
+    .replace(/,/g, "%2C");
+}
+
 /** ANSI yellow, the colour GitLab CI job logs use for warnings. */
 const YELLOW = "\x1b[33m";
 const COLOR_RESET = "\x1b[0m";
@@ -42,7 +53,7 @@ const COLOR_RESET = "\x1b[0m";
 export function warnCi(message: string, title: string): void {
   if (process.env.GITHUB_ACTIONS === "true") {
     process.stdout.write(
-      `::warning title=${escapeWorkflowCommandData(title)}::${escapeWorkflowCommandData(message)}\n`,
+      `::warning title=${escapeWorkflowCommandProperty(title)}::${escapeWorkflowCommandData(message)}\n`,
     );
     return;
   }

packages/core/tests/nodeVersion.integ.test.ts

@@ -44,10 +44,10 @@ describe("warnCi", () => {
   it("should emit an annotation on GitHub Actions", () => {
     process.env.GITHUB_ACTIONS = "true";
 
-    warnCi("a 100% clear\nwarning", "A title");
+    warnCi("a 100% clear\nwarning", "A title: with, separators");
 
     expect(write).toHaveBeenCalledWith(
-      "::warning title=A title::a 100%25 clear%0Awarning\n",
+      "::warning title=A title%3A with%2C separators::a 100%25 clear%0Awarning\n",
     );
     expect(warn).not.toHaveBeenCalled();
   });