Repository navigation
Add account config schema for cisco_secure_email_threat_defense - #25391
Ikmunozmartinez wants to merge 5 commits into
Conversation
evalya-impact-summaryevalya impact analysis |
…ay limits Move host_name into a regional connection method that keeps the existing hostnames as codes and maps them to https base URLs (pending IXP's code-to-URL change to RegionalMethod), and add the crawler's min/max/default to verdict_delay. api_key stays at the account level until IXP confirms how to model a third credential.
Match the field name introduced in ddoghq/dd-source#128691.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
Validation Report
Run Passed validations (20)
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 5229f66 | Docs | View more details | Give us feedback! |
Checklist before requesting review
What does this PR do?
Adds the
assets/account_config.jsonschema for thecisco_secure_email_threat_defenseintegration (Generic AMS), feeding thecisco-secure-email-threat-defense-logsdataflow. It uses the same field keys the crawler declares infields_in_development:basic):client_id→settings.client_id,client_password→secrets.client_password. The crawler uses them for basic auth onPOST /v1/oauth/tokento get a bearer token.regional):host_namekeeps the existing hostnames (api.{us,au,de,in}.etd.cisco.com) as codes and maps each tohttps://<host>, matching the crawler'shttps://{host_name}.api_key(see below) andverdict_delay(integer withmin: 0,max: 720,default: 30, matching the crawler).No tests: this is a schema-only asset, covered by the
account-config-schemaandaccount-config-runtimevalidations.Motivation
The
cisco_secure_email_threat_defenseintegration has an autogenerated tile via crawler-sdk but no account configuration schema on Generic AMS yet. This adds it.Draft, blocked on IXP:
regionalwith codes: todayregionaldropdown values must be https URLs. IXP proposed allowing codes, plus a code → base URL mapping. The mapping now uses IXP's field name,region_base_urls, from ddoghq/dd-source#128691, so this part passesvalidate-account-config-schemaonce that PR is merged and deployed.api_key: the crawler sends a third credential as thex-api-keyheader, on top of the basic credentials. No auth method can hold it,passwordisn't allowed at the account level, and exemptions are closed. It stays at the account level until IXP confirms how to model it.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged