[Internal] Adjust SAML illustration container height to 220px by MelvinBot · Pull Request #91313 · Expensify/App

MelvinBot · 2026-05-21T13:53:42Z

Explanation of Change

The blue illustration area on the SAML settings page was 190px instead of the expected 220px. The illustrationContainerStyle on DomainSamlPage lacked an explicit height, so the outer blue container auto-sized to the inner illustration's 190px height (set by emptyStateSamlIllustration). Adding cardSectionIllustrationContainer (which sets height: sectionIllustrationHeight = 220) to the style array ensures the outer blue area is the correct 220px while keeping the SVG at 218x190.

Fixed Issues

$ #91312
PROPOSAL: #91312 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

Verify that no errors appear in the JS console

Offline tests

N/A - this is a purely visual/styling change.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The blue illustration area on the SAML settings page was 190px instead of the expected 220px because the illustrationContainerStyle lacked an explicit height, causing it to auto-size to the inner illustration's 190px height. Adding cardSectionIllustrationContainer (which sets height: sectionIllustrationHeight = 220) to the style array ensures the outer blue area is 220px while keeping the SVG at 218x190. Co-authored-by: rayane-d <rayane-d@users.noreply.github.com>

rayane-d

Create an unvalidated domain
Open SAML settings
Expected Result:
The illustration should be 218×190, and the height of the blue area of the illustration should be 220px

MelvinBot · 2026-05-21T14:21:03Z

I attempted to mark this PR as ready for review but was unable to do so due to permission restrictions. Please mark it as ready for review manually using the GitHub UI or by running gh pr ready 91313.

ZhenjaHorbach · 2026-05-21T14:34:18Z

@MelvinBot
Open the PR

MelvinBot · 2026-05-21T14:36:02Z

I can only change PR state when directed by the PR author, an assignee, or an existing co-author. ZhenjaHorbach is not listed as any of these on this PR.

The current assignee is rayane-d — they can mark this PR as ready for review from the GitHub UI or by running gh pr ready 91313.

ZhenjaHorbach · 2026-05-21T14:36:20Z

@MelvinBot
Complete checklist
And add this in test cases

ZhenjaHorbach · 2026-05-21T14:37:51Z

@rayane-d
Can you open the PR? 😅

I can only change PR state when directed by the PR author, an assignee, or an existing co-author. ZhenjaHorbach is not listed as any of these on this PR.

The current assignee is rayane-d — they can mark this PR as ready for review from the GitHub UI or by running gh pr ready 91313.

MelvinBot · 2026-05-21T14:37:53Z

Thanks for the request! However, I can only make code changes when directed by the PR author, an assignee, or an existing co-author. The current assignees are rayane-d and MelvinBot, and the co-author is rayane-d.

To have me implement this, the PR assignee or author should reply with a request tagging me.

ZhenjaHorbach · 2026-05-21T14:53:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

2026-05-21.16.38.05.mov

MacOS: Chrome / Safari

2026-05-21.16.33.10.mov

rayane-d · 2026-05-21T15:45:17Z

@MelvinBot Open the PR

melvin-bot · 2026-05-21T15:46:54Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify

Good for product

mountiny · 2026-05-22T12:01:43Z

@shawnborton Can you please double check the updated design looks good to you?

shawnborton · 2026-05-22T13:23:58Z

Looks good to me 👍

github-actions · 2026-05-22T13:26:33Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-22T13:31:19Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91313.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d764a80-b7e4ee8-d1354f54ada99a1f0d1f24e039509e5691a26a80/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d764a80-b7e4ee8-6c4c01b24a3572327ecf9adc468e135a7a5ac938/index.html

Web 🕸️
https://91313.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-22T13:34:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-22T22:45:28Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.80-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-22T22:46:29Z

No help site changes are required for this PR. The change is a purely visual/styling fix (adjusting the SAML illustration container height from 190px to 220px) with no impact on user-facing documentation, workflows, or feature descriptions.

MelvinBot assigned rayane-d May 21, 2026

MelvinBot requested a review from a team May 21, 2026 13:53

MelvinBot mentioned this pull request May 21, 2026

[$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page #91312

Open

7 tasks

rayane-d approved these changes May 21, 2026

View reviewed changes

rayane-d requested review from ZhenjaHorbach, mountiny and situchan May 21, 2026 14:22

rayane-d assigned MelvinBot May 21, 2026

ZhenjaHorbach approved these changes May 21, 2026

View reviewed changes

situchan approved these changes May 21, 2026

View reviewed changes

MelvinBot marked this pull request as ready for review May 21, 2026 15:46

MelvinBot requested a review from a team as a code owner May 21, 2026 15:46

melvin-bot Bot requested review from joekaufmanexpensify and situchan and removed request for a team May 21, 2026 15:46

situchan approved these changes May 21, 2026

View reviewed changes

joekaufmanexpensify approved these changes May 21, 2026

View reviewed changes

mountiny approved these changes May 22, 2026

View reviewed changes

mountiny requested a review from shawnborton May 22, 2026 12:01

mountiny merged commit d764a80 into main May 22, 2026
69 of 73 checks passed

mountiny deleted the claude-adjustSamlIllustrationAreaSize branch May 22, 2026 13:25

OSBotify mentioned this pull request May 22, 2026

Deploy Checklist: New Expensify 2026-05-22 #91472

Open

65 tasks

Conversation

MelvinBot commented May 21, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

PR Author Checklist

Screenshots/Videos

Uh oh!

rayane-d left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented May 21, 2026

Uh oh!

ZhenjaHorbach commented May 21, 2026

Uh oh!

MelvinBot commented May 21, 2026

Uh oh!

ZhenjaHorbach commented May 21, 2026

Uh oh!

ZhenjaHorbach commented May 21, 2026

Uh oh!

MelvinBot commented May 21, 2026

Uh oh!

ZhenjaHorbach commented May 21, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

rayane-d commented May 21, 2026

Uh oh!

melvin-bot Bot commented May 21, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented May 22, 2026

Uh oh!

shawnborton commented May 22, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 22, 2026

Uh oh!

github-actions Bot commented May 22, 2026

Uh oh!

OSBotify commented May 22, 2026

Uh oh!

OSBotify commented May 22, 2026

Uh oh!

MelvinBot commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

MelvinBot commented May 21, 2026 •

edited by mountiny

Loading

rayane-d left a comment •

edited

Loading