Navigate to parent chat after rejecting expense report#91314
Draft
MelvinBot wants to merge 1 commit into
Draft
Conversation
After a vacation delegate rejects an expense report, navigate to the parent expense chat instead of calling Navigation.goBack(). This prevents the delegate from landing on a report they are about to lose access to, which was causing "Report Not Found" when clicking Print. This mirrors the existing behavior in rejectMoneyRequest for single-expense reports. Co-authored-by: Olly <Ollyws@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
After a vacation delegate rejects an expense report via
RejectExpenseReportPage,Navigation.goBack()returns the delegate to the report they just rejected. However, the server-side rejection removes the delegate's access to that report (by rewritingmanagerIDto the submitter), creating a race where the delegate sees "Report Not Found" if they interact with the report (e.g. More → Print) beforeReportNavigateAwayHandlerfires.This PR replaces
Navigation.goBack()withNavigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.chatReportID))so the delegate is navigated to the parent expense chat after rejection — the same patternrejectMoneyRequestalready uses for single-expense reports.Fixed Issues
$ #87837
PROPOSAL: #87837 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
// TODO: The human co-author must fill out offline test steps
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari