Skip to content

Commit c1e91cf

Browse files
committed
fix: pr-suites-packs.sh full-mode must target each pack subdir, not $LANGUAGE
codeql pack install/create requires a directory containing a qlpack.yml directly. No language has a top-level qlpack.yml (only nested src/, lib/, ext/, ext-library-sources/) so `codeql pack install "$LANGUAGE"` fails with "ERROR: The directory is not a qlpack." Loop over the actual pack subdirectories instead, matching what codeql-workspace.yml's `**/qlpack.yml` globs actually resolve to. Caught by dispatching this branch's workflow_dispatch run directly - cpp/go/ruby all failed identically before this fix.
1 parent 19bbdb9 commit c1e91cf

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

‎.github/scripts/pr-suites-packs.sh‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,13 @@ if [[ -z "$PR_NUMBER" ]]; then
1919
done < <(find "$LANGUAGE/suites" -name '*.qls' -print0)
2020
fi
2121

22-
echo "[+] Compiling Pack: $LANGUAGE"
23-
codeql pack install "$LANGUAGE"
24-
codeql pack create "$LANGUAGE"
22+
for pack_dir in "$LANGUAGE/src" "$LANGUAGE/lib" "$LANGUAGE/ext" "$LANGUAGE/ext-library-sources"; do
23+
if [[ -f "$pack_dir/qlpack.yml" ]]; then
24+
echo "[+] Compiling Pack: $pack_dir"
25+
codeql pack install "$pack_dir"
26+
codeql pack create "$pack_dir"
27+
fi
28+
done
2529

2630
echo "[+] Complete"
2731
exit 0

0 commit comments

Comments
 (0)