Repository navigation
Dragging handle back into its anchor makes its opposite handle move around randomly #2451
Description
We no longer can snap a handle to its anchor point, thereby hiding it (giving it a zero length status where it's treated as gone). When doing this, the other handle shouldn't be affected from its original position.
See the video in my comment below for what this issue is now about.
Activity
0SlowPoke0 commentedon Mar 17, 2025
@Keavon this was fixed right?
Keavon commentedon Mar 17, 2025
Hmm, yeah, seems to be and that does align with my memory. I moved this over from the ✅ issue in #code-todo-list (which I deleted when transferring this over to here to avoid duplication), prompted by @mTvare6 referencing that #code-todo-list task link in a TODO comment in the code of #2450. So I tested it and saw it was broken in dev. So I replaced it with this issue and updated the URL of the TODO comment to this issue. But now it's not present as far as I can tell.
However, when testing just now, I did find this similar bug. Let's make this issue now dedicated to fixing this bug:
capture_53_.mp4
mTvare6 commentedon Mar 18, 2025
The code already did mention that issue once, I just moved it over into common handler, sorry for not checking if it were resolved.
Keavon commentedon Mar 18, 2025
Oh I missed that you were just moving that code, my bad. Mystery solved.
krVatsal commentedon Feb 5, 2026
Hi @Keavon, i think this issue is solved or is there something that i am missing for reproducing the issue?
devviktoria commentedon Apr 27, 2026
I was able to reproduce the issue that was shown in the video at https://dev.graphite.art/. Is it OK if I work on this?
Keavon commentedon Apr 27, 2026
Yes! Please include your own videos of the reproduction and solution as well in the PR (or just here if you can show a recent reproduction, that'd be helpful).
devviktoria commentedon Apr 29, 2026
I created a draft pull request for this. That contain the reproduction video and how it is working now with my fix.
What I found that if the handle is collinear and Along Path snapping mode is active that can cause weird jittering and snapping issues when the handle is near the anchor point.
My idea is to reduce the snap weight under this condition so the tool behaves more naturally in this way.
But this idea has to be approved, because this is kind of turn off the snapping near the anchor point in this specific case (collinear+Along Path snapping)!
My solution does not have tests I will look into that next.
devviktoria commentedon Sep 8, 2026
I created a new PR for this which contains only the edge case fix, which I think was really the root cause of this issue. It contains a test for this too.
Please note that I haven't updated my old PR with the breaking changes. But if you prefer to merge that one than let me know and I will update that one. (But I think it is best to merge this new PR instead the old one, because this changes are not going to alter the behavior of the software itself.)