From 16316fb193c529a619992d55e18d3e42297c7b8d Mon Sep 17 00:00:00 2001 From: Patel230 Date: Tue, 9 Jun 2026 11:56:44 +0530 Subject: [PATCH 1/3] fix: align toolchain versions and remove disabled/duplicate CI files - mise.toml: bumped go 1.26.1 -> 1.26.4 to match go.mod/CI. - CI: aligned golangci-lint version between ci.yml and mise.toml; pinned gofumpt v0.10.0 (was @latest). - Removed two permanently-disabled workflow stubs (license-check.yml -> non-existent shared workflow; lint.yml -> redundant with ci.yml). - Removed duplicate .github/CODEOWNERS (kept the richer root CODEOWNERS). Verified: go build/vet/test pass; gofumpt clean; golangci-lint 0 issues. --- .github/CODEOWNERS | 2 -- .github/workflows/ci.yml | 4 ++-- .github/workflows/license-check.yml | 15 ------------ .github/workflows/lint.yml | 37 ----------------------------- mise.toml | 2 +- 5 files changed, 3 insertions(+), 57 deletions(-) delete mode 100644 .github/CODEOWNERS delete mode 100644 .github/workflows/license-check.yml delete mode 100644 .github/workflows/lint.yml diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS deleted file mode 100644 index 9170b06..0000000 --- a/.github/CODEOWNERS +++ /dev/null @@ -1,2 +0,0 @@ -# Default code owners for all files -* @GrayCodeAI/cli-maintainers diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dae9e43..00aa2d7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -49,7 +49,7 @@ jobs: cache: true - name: gofumpt diff run: | - go install mvdan.cc/gofumpt@latest + go install mvdan.cc/gofumpt@v0.10.0 out=$(gofumpt -l .) if [ -n "$out" ]; then echo "::error::gofumpt would reformat the following files:" @@ -73,7 +73,7 @@ jobs: cache: true - uses: golangci/golangci-lint-action@v7 with: - version: v2.1.0 + version: v2.11.3 install-mode: goinstall verify: false args: --timeout=5m diff --git a/.github/workflows/license-check.yml b/.github/workflows/license-check.yml deleted file mode 100644 index 7c294a6..0000000 --- a/.github/workflows/license-check.yml +++ /dev/null @@ -1,15 +0,0 @@ -name: License Check - -on: - workflow_dispatch: - # Disabled: reusable workflow GrayCodeAI/shared not available - # pull_request: - # push: - # branches: - # - main - -jobs: - check-licenses: - runs-on: ubuntu-latest - steps: - - run: echo "License check disabled - shared workflow not available" diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml deleted file mode 100644 index 5d0e38f..0000000 --- a/.github/workflows/lint.yml +++ /dev/null @@ -1,37 +0,0 @@ -name: Lint -on: - workflow_dispatch: - # Disabled: redundant with CI workflow which runs lint + tests - # pull_request: - # push: - # branches: - # - main - -permissions: - contents: read - -jobs: - lint: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 - with: - ref: ${{ github.event.pull_request.head.sha }} - - - uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6 - with: - go-version-file: go.mod - - - uses: jdx/mise-action@1648a7812b9aeae629881980618f079932869151 # v4 - - - name: Run linters - run: mise run lint - - # So this golangci-lint uses the same config as `mise run lint:go`, but using special sauce to - # create inline feedback on GitHub's UI. On local dev, the same issues should be surfaced by - # mise-tasks/lint/go - - name: Run golangci-lint - uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9 - with: - version: 'v2.11.3' - debug: 'clean' diff --git a/mise.toml b/mise.toml index 5e3fb49..bdf2cee 100644 --- a/mise.toml +++ b/mise.toml @@ -1,6 +1,6 @@ [tools] # Please also keep the version aligned in the go.mod file -go = { version = '1.26.1', postinstall = "go install github.com/go-delve/delve/cmd/dlv@latest && go install gotest.tools/gotestsum@latest" } +go = { version = '1.26.4', postinstall = "go install github.com/go-delve/delve/cmd/dlv@latest && go install gotest.tools/gotestsum@latest" } golangci-lint = '2.11.3' shellcheck = 'latest' tmux = 'latest' From 2b0911ffa8ed27752b2370bd05ab8631e7a5448e Mon Sep 17 00:00:00 2001 From: Patel230 Date: Tue, 9 Jun 2026 15:35:02 +0530 Subject: [PATCH 2/3] fix: restore code owners --- .github/CODEOWNERS | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000..9170b06 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,2 @@ +# Default code owners for all files +* @GrayCodeAI/cli-maintainers From a067d692afc83058983e9638f854a067db48a797 Mon Sep 17 00:00:00 2001 From: Patel230 Date: Tue, 9 Jun 2026 16:35:40 +0530 Subject: [PATCH 3/3] fix: remove duplicate .github/CODEOWNERS so root CODEOWNERS governs The .github/CODEOWNERS (`* @GrayCodeAI/cli-maintainers`) took GitHub precedence over the richer root CODEOWNERS, shadowing the per-directory ownership (security-team for /redact/, devops-team for CI/build, etc.). Removing it restores the intended ownership policy. --- .github/CODEOWNERS | 2 -- 1 file changed, 2 deletions(-) delete mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS deleted file mode 100644 index 9170b06..0000000 --- a/.github/CODEOWNERS +++ /dev/null @@ -1,2 +0,0 @@ -# Default code owners for all files -* @GrayCodeAI/cli-maintainers