tab: remove installed_as_dependency, use installed_on_request as source of truth

Replace all uses of installed_as_dependency with !installed_on_request.
Stop storing installed_as_dependency in new Tabs for both formulae and casks.
installed_on_request is now the single source of truth.

Fixes #21751

Author: ooye-sanket

Library/Homebrew/bundle/brew.rb

@@ -142,7 +142,7 @@ def dump(describe: false, no_restart: false)
           require "bundle/brew_services"
 
           requested_formula = formulae.select do |f|
-            f[:installed_on_request?] || !f[:installed_as_dependency?]
+            f[:installed_on_request?]
           end
           requested_formula.map do |f|
             brewline = if describe && f[:desc].present?
@@ -245,7 +245,6 @@ def formula_to_hash(formula)
               nil
             end.to_s
             args << "HEAD" if version.start_with?("HEAD")
-            installed_as_dependency = tab.installed_as_dependency
             installed_on_request = tab.installed_on_request
             runtime_dependencies = if (runtime_deps = tab.runtime_dependencies)
               runtime_deps.filter_map { |d| d["full_name"] }
@@ -270,7 +269,6 @@ def formula_to_hash(formula)
             any_version_installed?:   formula.any_version_installed?,
             args:                     Array(args).uniq,
             version:,
-            installed_as_dependency?: installed_as_dependency || false,
             installed_on_request?:    installed_on_request || false,
             dependencies:             runtime_dependencies,
             build_dependencies:       formula.deps.select(&:build?).map(&:name).uniq,

Library/Homebrew/cask/audit.rb

@@ -626,7 +626,7 @@ def extract_artifacts(&_block)
 
         install_options = {
           show_header:             true,
-          installed_as_dependency: true,
+          installed_on_request: false,
           installed_on_request:    false,
           verbose:                 false,
         }.compact

Library/Homebrew/cask/installer.rb

@@ -23,15 +23,15 @@ class Installer
       params(
         cask: ::Cask::Cask, command: T.class_of(SystemCommand), force: T::Boolean, adopt: T::Boolean,
         skip_cask_deps: T::Boolean, binaries: T::Boolean, verbose: T::Boolean, zap: T::Boolean,
-        require_sha: T::Boolean, upgrade: T::Boolean, reinstall: T::Boolean, installed_as_dependency: T::Boolean,
+        require_sha: T::Boolean, upgrade: T::Boolean, reinstall: T::Boolean,
         installed_on_request: T::Boolean, quarantine: T::Boolean, verify_download_integrity: T::Boolean,
         quiet: T::Boolean, download_queue: Homebrew::DownloadQueue, defer_fetch: T::Boolean
       ).void
     }
     def initialize(cask, command: SystemCommand, force: false, adopt: false,
                    skip_cask_deps: false, binaries: true, verbose: false,
                    zap: false, require_sha: false, upgrade: false, reinstall: false,
-                   installed_as_dependency: false, installed_on_request: true,
+                    installed_on_request: true,
                    quarantine: true, verify_download_integrity: true, quiet: false,
                    download_queue: Homebrew.default_download_queue, defer_fetch: false)
       @cask = cask
@@ -45,7 +45,6 @@ def initialize(cask, command: SystemCommand, force: false, adopt: false,
       @require_sha = require_sha
       @reinstall = reinstall
       @upgrade = upgrade
-      @installed_as_dependency = installed_as_dependency
       @installed_on_request = installed_on_request
       @quarantine = quarantine
       @verify_download_integrity = verify_download_integrity
@@ -64,8 +63,7 @@ def binaries? = @binaries
     sig { returns(T::Boolean) }
     def force? = @force
 
-    sig { returns(T::Boolean) }
-    def installed_as_dependency? = @installed_as_dependency
+
 
     sig { returns(T::Boolean) }
     def installed_on_request? = @installed_on_request
@@ -170,7 +168,6 @@ def install
       install_artifacts(predecessor:)
 
       tab = Tab.create(@cask)
-      tab.installed_as_dependency = installed_as_dependency?
       tab.installed_on_request = installed_on_request?
       tab.write
 
@@ -437,7 +434,7 @@ def missing_cask_and_formula_dependencies
     end
 
     def satisfy_cask_and_formula_dependencies
-      return if installed_as_dependency?
+     return unless installed_on_request?
 
       formulae_and_casks = cask_and_formula_dependencies
 
@@ -466,7 +463,6 @@ def satisfy_cask_and_formula_dependencies
             adopt:                   adopt?,
             binaries:                binaries?,
             force:                   false,
-            installed_as_dependency: true,
             installed_on_request:    false,
             quarantine:              quarantine?,
             quiet:                   quiet?,
@@ -478,7 +474,6 @@ def satisfy_cask_and_formula_dependencies
             cask_or_formula,
             **{
               show_header:             true,
-              installed_as_dependency: true,
               installed_on_request:    false,
               verbose:                 verbose?,
             }.compact,

Library/Homebrew/cask/tab.rb

@@ -104,7 +104,6 @@ def to_json(*_args)
         "homebrew_version"        => homebrew_version,
         "loaded_from_api"         => loaded_from_api,
         "uninstall_flight_blocks" => uninstall_flight_blocks,
-        "installed_as_dependency" => installed_as_dependency,
         "installed_on_request"    => installed_on_request,
         "time"                    => time,
         "runtime_dependencies"    => runtime_dependencies,

Library/Homebrew/cmd/install.rb

@@ -294,7 +294,6 @@ def run
         formulae_installer = Install.formula_installers(
           installed_formulae,
           installed_on_request:       !args.as_dependency?,
-          installed_as_dependency:    args.as_dependency?,
           build_bottle:               args.build_bottle?,
           force_bottle:               args.force_bottle?,
           bottle_arch:                args.bottle_arch,

Library/Homebrew/cmd/leaves.rb

@@ -30,7 +30,7 @@ def run
         end
         leaves_list -= casks_runtime_dependencies
         leaves_list.select! { |leaf| installed_on_request?(leaf) } if args.installed_on_request?
-        leaves_list.select! { |leaf| installed_as_dependency?(leaf) } if args.installed_as_dependency?
+        leaves_list.select! { |leaf| !installed_on_request?(leaf) } if args.installed_as_dependency?
 
         leaves_list.map(&:full_name)
                    .sort
@@ -45,8 +45,8 @@ def installed_on_request?(formula)
       end
 
       sig { params(formula: Formula).returns(T::Boolean) }
-      def installed_as_dependency?(formula)
-        formula.any_installed_keg&.tab&.installed_as_dependency == true
+     def installed_on_request?(formula)
+        formula.any_installed_keg&.tab&.installed_on_request == false
       end
     end
   end

Library/Homebrew/cmd/list.rb

@@ -136,7 +136,9 @@ def run
 
             statuses = []
             statuses << "installed on request" if args.installed_on_request? && tab.installed_on_request
-            statuses << "installed as dependency" if args.installed_as_dependency? && tab.installed_as_dependency
+            # TODO: Uncomment to deprecate in a future release:
+            # odeprecated "brew list --installed-as-dependency", "brew list --no-installed-on-request"
+            statuses << "installed as dependency" if args.installed_as_dependency? && !tab.installed_on_request
             statuses << "poured from bottle" if args.poured_from_bottle? && tab.poured_from_bottle
             statuses << "built from source" if args.built_from_source? && !tab.poured_from_bottle
             next if statuses.empty?

Library/Homebrew/cmd/tab.rb

@@ -78,7 +78,6 @@ def update_tab(formula_or_cask, installed_on_request:)
         end
 
         tab.installed_on_request = installed_on_request
-        tab.installed_as_dependency = !installed_on_request if formula_or_cask.is_a?(Formula)
         tab.write
         ohai "#{name} is now marked as #{installed_on_request_str}."
       end

Library/Homebrew/extend/os/linux/formula_installer.rb

@@ -5,6 +5,6 @@ class FormulaInstaller
   sig { params(formula: Formula).returns(T.nilable(T::Boolean)) }
   def fresh_install?(formula)
     !Homebrew::EnvConfig.developer? &&
-      (!installed_as_dependency? || !formula.any_version_installed?)
+      (installed_on_request? || !formula.any_version_installed?)
   end
 end

Library/Homebrew/extend/os/mac/formula_installer.rb

@@ -11,7 +11,7 @@ module FormulaInstaller
       sig { params(formula: Formula).returns(T.nilable(T::Boolean)) }
       def fresh_install?(formula)
         !::Homebrew::EnvConfig.developer? && !OS::Mac.version.outdated_release? &&
-          (!installed_as_dependency? || !formula.any_version_installed?)
+         (installed_on_request? || !formula.any_version_installed?)
       end
     end
   end