Skip to content

Commit 8a783d7

Browse files
committed
Remove unnecessary blank line in supports_linux? method
1 parent 932a3fd commit 8a783d7

3 files changed

Lines changed: 12 additions & 10 deletions

File tree

Library/Homebrew/cask/cask.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def supports_macos? = true
167167
sig { returns(T::Boolean) }
168168
def supports_linux?
169169
return true if font?
170-
170+
171171
# Cache the os value before contains_os_specific_artifacts? refreshes the cask
172172
# (the refresh clears @dsl.os in generic/non-OS-specific contexts)
173173
os_value = @dsl.os

Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,8 @@ def filter_runners(cask)
154154
filtered_runners.merge(linux_runners)
155155
end
156156

157+
private
158+
157159
sig { params(cask: Cask::Cask, os: Symbol).returns(T::Array[Symbol]) }
158160
def architectures(cask:, os:)
159161
architectures = T.let([], T::Array[Symbol])

Library/Homebrew/test/dev-cmd/generate-cask-ci-matrix_spec.rb

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@
148148

149149
context "when cask does not have on_system blocks/calls or `depends_on arch`" do
150150
it "returns an array including everything" do
151-
expect(generate_matrix.send(:filter_runners, c))
151+
expect(generate_matrix.filter_runners(c))
152152
.to eq({
153153
{ arch: :arm, name: "macos-14", symbol: :sonoma } => 0.0,
154154
{ arch: :arm, name: "macos-15", symbol: :sequoia } => 0.0,
@@ -158,7 +158,7 @@
158158
{ arch: :intel, name: "ubuntu-22.04", symbol: :linux } => 1.0,
159159
})
160160

161-
expect(generate_matrix.send(:filter_runners, c_app_only_macos))
161+
expect(generate_matrix.filter_runners(c_app_only_macos))
162162
.to eq({
163163
{ arch: :arm, name: "macos-14", symbol: :sonoma } => 0.0,
164164
{ arch: :arm, name: "macos-15", symbol: :sequoia } => 0.0,
@@ -172,7 +172,7 @@
172172

173173
context "when cask does not have on_system blocks/calls but has macOS specific stanza" do
174174
it "returns an array including all macOS" do
175-
expect(generate_matrix.send(:filter_runners, c_app))
175+
expect(generate_matrix.filter_runners(c_app))
176176
.to eq({
177177
{ arch: :arm, name: "macos-14", symbol: :sonoma } => 0.0,
178178
{ arch: :arm, name: "macos-15", symbol: :sequoia } => 0.0,
@@ -184,14 +184,14 @@
184184

185185
context "when cask does not have on_system blocks/calls but has `depends_on arch`" do
186186
it "returns an array only including macOS/`depends_on arch` value" do
187-
expect(generate_matrix.send(:filter_runners, c_depends_macos_on_intel))
187+
expect(generate_matrix.filter_runners(c_depends_macos_on_intel))
188188
.to eq({ { arch: :intel, name: "macos-15-intel", symbol: :sequoia } => 1.0 })
189189
end
190190
end
191191

192192
context "when cask has on_system blocks/calls but does not have `depends_on arch`" do
193193
it "returns an array with combinations of OS and architectures" do
194-
expect(generate_matrix.send(:filter_runners, c_on_system))
194+
expect(generate_matrix.filter_runners(c_on_system))
195195
.to eq({
196196
{ arch: :arm, name: "macos-14", symbol: :sonoma } => 0.0,
197197
{ arch: :arm, name: "macos-15", symbol: :sequoia } => 0.0,
@@ -205,13 +205,13 @@
205205

206206
context "when cask has on_system blocks/calls and `depends_on arch`" do
207207
it "returns an array with combinations of OS and `depends_on arch` value" do
208-
expect(generate_matrix.send(:filter_runners, c_on_system_depends_on_intel))
208+
expect(generate_matrix.filter_runners(c_on_system_depends_on_intel))
209209
.to eq({
210210
{ arch: :intel, name: "macos-15-intel", symbol: :sequoia } => 1.0,
211211
{ arch: :intel, name: "ubuntu-22.04", symbol: :linux } => 1.0,
212212
})
213213

214-
expect(generate_matrix.send(:filter_runners, c_on_linux_depends_on_intel))
214+
expect(generate_matrix.filter_runners(c_on_linux_depends_on_intel))
215215
.to eq({
216216
{ arch: :arm, name: "macos-14", symbol: :sonoma } => 0.0,
217217
{ arch: :arm, name: "macos-15", symbol: :sequoia } => 0.0,
@@ -220,14 +220,14 @@
220220
{ arch: :intel, name: "ubuntu-22.04", symbol: :linux } => 1.0,
221221
})
222222

223-
expect(generate_matrix.send(:filter_runners, c_on_macos_depends_on_intel))
223+
expect(generate_matrix.filter_runners(c_on_macos_depends_on_intel))
224224
.to eq({
225225
{ arch: :intel, name: "macos-15-intel", symbol: :sequoia } => 1.0,
226226
{ arch: :intel, name: "ubuntu-22.04", symbol: :linux } => 1.0,
227227
{ arch: :arm, name: "ubuntu-22.04-arm", symbol: :linux } => 1.0,
228228
})
229229

230-
expect(generate_matrix.send(:filter_runners, c_on_system_depends_on_mixed))
230+
expect(generate_matrix.filter_runners(c_on_system_depends_on_mixed))
231231
.to eq({
232232
{ arch: :arm, name: "ubuntu-22.04-arm", symbol: :linux } => 1.0,
233233
{ arch: :intel, name: "macos-15-intel", symbol: :sequoia } => 1.0,

0 commit comments

Comments
 (0)