chore(deps): upgrade @kitware/vtk.js to 36.0.0#879
Open
PaulHax wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bumps @kitware/vtk.js from ^32.12.1 to ^36.0.0. Per vtk.js BREAKING_CHANGES (33 -> 34), several volume mapper setters were moved from the mapper onto the volume property. Adjust callers to invoke the new property-based setters: - src/utils/volumeProperties.ts: route the relevant set* calls through the volume's property instead of the mapper. - src/components/vtk/VtkBaseVolumeRepresentation.vue: same migration for the representation component's mapper/property interactions.
VolView's virtual-modules plugin stubs @kitware/vtk.js's internal ColorMaps.json.js to drop the unused built-in colormap data. vtk.js v36 builds with Vite/Rolldown, which emits that module with `export default` (v35's Rollup build used a minified named export). Match the new shape so the stub satisfies ColorMaps.js's default import.
PaulHax
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @kitware/vtk.js from
^32.12.1to^36.0.0.API migration
Per vtk.js BREAKING_CHANGES (33 -> 34), several volume mapper setters were moved from the mapper onto the volume property. Callers are adjusted to invoke the new property-based setters:
src/utils/volumeProperties.ts: route the relevantset*calls through the volume's property instead of the mapper.src/components/vtk/VtkBaseVolumeRepresentation.vue: same migration for the representation component's mapper/property interactions.Build config
vtk.js v36 builds with Vite/Rolldown (Kitware/vtk-js#3435). Its internal
ColorMaps.json.jsis now emitted withexport defaultinstead of v35's minified named export, so thevirtual-modulesstub invite.config.tsis updated to match.Verified:
vue-tsc --noEmitpasses andvite buildsucceeds against@kitware/vtk.js@36.0.0.