Assisted suicides also by world and indicate assists in kill feed.#2009
Open
Agiel wants to merge 1 commit into
Open
Assisted suicides also by world and indicate assists in kill feed.#2009Agiel wants to merge 1 commit into
Agiel wants to merge 1 commit into
Conversation
Contributor
Author
Yes let's handle that separately. Another issue we might have is subtracting too many points when negative assists are enabled, but rather than fixing it I think we should discuss removing the feature altogether. I can't see any servers enabling it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1851 fixed awarding assists when suiciding by your own grenade, but missed the case where the killer is worldspawn. This PR should handle that. I also added the assist indicator to the kill feed.
Note that the kill feed text will sometimes overflow the container but I haven't been able to figure out why. Pretty sure this was a problem before as well though. I restructured the space calculation and text rendering so they're closer and easier to follow but that didn't help me narrow it down. I think we can leave it until someone decides to rewrite the feed using NeoUI.
Without assist:
With assist:
Toolchain
Linked Issues