Skip to content

Commit 7cf5236

Browse files
committed
libiconvReal: disable the setup hook on Darwin
This mirrors the Darwin libiconv package, which does not provide a setup hook. It is expected that libiconv will be linked explicitly on Darwin.
1 parent aefbff8 commit 7cf5236

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

pkgs/development/libraries/libiconv/default.nix

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,13 @@ stdenv.mkDerivation rec {
2828
# https://github.com/NixOS/nixpkgs/pull/192630#discussion_r978985593
2929
hardeningDisable = lib.optional (stdenv.hostPlatform.libc == "bionic") "fortify";
3030

31-
setupHooks = [
32-
../../../build-support/setup-hooks/role.bash
33-
./setup-hook.sh
31+
setupHooks =
32+
# Match the default behavior on Darwin, which does not automatically link libiconv.
33+
lib.optionals (!stdenv.hostPlatform.isDarwin) [
34+
../../../build-support/setup-hooks/role.bash
35+
./setup-hook.sh
36+
];
37+
3438
patches = [
3539
# Add support for the UTF-8-MAC encoding. This is needed for correct behavior of applications that interact with
3640
# the filesystem on Darwin because it uses a variant of NFD to store filenames.

0 commit comments

Comments
 (0)