Skip to content

feat(accessibility): add core types and platform support - #1114

Merged
Kyle-Ye merged 27 commits into
mainfrom
feature/accessibility
Sep 28, 2026
Merged

Kyle-Ye merged 27 commits into
mainfrom
feature/accessibility

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add shared accessibility values, properties, traits, visibility, activation points, and child behavior storage.
  • Add custom content, custom attributes, chart descriptors, data series, and attachment serialization.
  • Add platform focus helpers, accessibility SPI and fallback types, and localized system symbol descriptions.
  • Move shared numeric and link support into OpenSwiftUICore and document public accessibility APIs.

Related to #1112.

@Kyle-Ye
Kyle-Ye requested a review from Mx-Iris as a code owner September 27, 2026 18:56
@github-actions github-actions Bot added area: accessibility Accessibility APIs, settings, semantics, or behavior. type: feature New API, behavior, platform support, or user-facing capability. labels Sep 27, 2026
@Kyle-Ye Kyle-Ye linked an issue Sep 27, 2026 that may be closed by this pull request
1 of 3 tasks
@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.30529% with 1609 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.80%. Comparing base (018f209) to head (3ce41ee).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...re/Accessibility/AccessibilityNodeAttachment.swift 0.00% 289 Missing ⚠️
...SwiftUICore/Accessibility/AccessibilityValue.swift 13.16% 244 Missing ⚠️
.../Accessibility/AccessibilityCustomAttributes.swift 0.00% 117 Missing ⚠️
...wiftUICore/Accessibility/AccessibilityTraits.swift 0.00% 117 Missing ⚠️
...ore/Accessibility/AccessibilityCustomContent.swift 0.00% 94 Missing ⚠️
...UICore/Accessibility/AccessibilityProperties.swift 0.00% 89 Missing ⚠️
...UICore/Accessibility/AccessibilityDataSeries.swift 0.00% 74 Missing ⚠️
...e/Accessibility/AccessibilityChartDescriptor.swift 0.00% 73 Missing ⚠️
...Accessibility/AccessibilityNullableOptionSet.swift 0.00% 58 Missing ⚠️
...rces/OpenSwiftUICore/Util/AccessibilityShims.swift 0.00% 58 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
- Coverage   33.70%   32.80%   -0.91%     
==========================================
  Files         799      822      +23     
  Lines       62211    66340    +4129     
==========================================
+ Hits        20969    21762     +793     
- Misses      41242    44578    +3336     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tuist

tuist Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 17abd6a49

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 52.6s 17abd6a49

@Kyle-Ye
Kyle-Ye merged commit ec661fe into main Sep 28, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/accessibility branch September 28, 2026 03:06
@Kyle-Ye Kyle-Ye mentioned this pull request Sep 28, 2026
1 of 3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: accessibility Accessibility APIs, settings, semantics, or behavior. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Accessibility support

1 participant