Skip to content

chore: update forms Input forms input 2.6.0 tokens - #911

Open
AhmedAmineZr wants to merge 9 commits into
developfrom
839-for-phone-number-input-component-update-to-v131
Open

chore: update forms Input forms input 2.6.0 tokens#911
AhmedAmineZr wants to merge 9 commits into
developfrom
839-for-phone-number-input-component-update-to-v131

Conversation

@AhmedAmineZr

@AhmedAmineZr AhmedAmineZr commented Aug 26, 2026

Copy link
Copy Markdown
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • CHANGELOG.md files have been updated respecting keep a changelog rules and referencing the issue

@AhmedAmineZr
AhmedAmineZr requested a review from nouha06 August 26, 2026 14:21
@AhmedAmineZr AhmedAmineZr self-assigned this Aug 26, 2026
@AhmedAmineZr AhmedAmineZr added 📖 documentation Improvements or additions to documentation ⚛️ component 📱 demo app labels Aug 26, 2026
@AhmedAmineZr AhmedAmineZr linked an issue Aug 26, 2026 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown

📖 Documentation preview deployed!

🔗 https://flutter.unified-design-system.orange.com/prPreview/911/

github-actions Bot pushed a commit that referenced this pull request Aug 26, 2026
AhmedAmineZr and others added 5 commits August 26, 2026 17:58
- Add MIGRATION.md entry for OudsTextInputPrefixIcon/OudsTextInputSuffixIconButton
  breaking change (prefixIcon/suffixIcon type change, onSuffixPressed removal)
- Document OudsButton.tinted as a non-breaking addition
- Sync skills/ouds-flutter-migration-guide/SKILL.md with the same migration steps

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add v2.0.0 -> v2.1.0 section (Navigation Button, Circular/Linear Progress
  Indicator, tokens v2.6.0), matching the released CHANGELOG entries
- Add v2.1.0 -> v3.0.0 section and move the OudsTextInput/OudsPhoneNumberInput
  typed prefix/suffix icon breaking change and OudsButton.tinted addition
  there, since they belong to the upcoming 3.0.0 release (per ouds_core
  pubspec.yaml and CHANGELOG Unreleased section), not v2.0.0
- Remove those entries from the v1.3.1 -> v2.0.0 section where they had been
  incorrectly attributed
- Sync skills/ouds-flutter-migration-guide/SKILL.md version summary table and
  the typed icon migration example with the new v2.1.0 -> v3.0.0 section

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions Bot pushed a commit that referenced this pull request Aug 26, 2026
@AhmedAmineZr
AhmedAmineZr marked this pull request as ready for review August 26, 2026 17:45
Metadata-only update (phone/short-number metadata, carrier and geocoding
data refresh) within the existing ^1.1.51 constraint declared in
ouds_core/pubspec.yaml. No API changes; PhoneNumberUtil usage in
OudsPhoneNumberInput is unaffected.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@AhmedAmineZr AhmedAmineZr changed the title 839 for phone number input component update to v131 chore: update forms Input forms input 2.6.0 tokens Aug 26, 2026
widget.decoration.labelText ?? "",
style: theme.typographyTokens
.typeLabelDefaultLarge(context)
.typeLabelModerateLarge(context)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you hcange the typo here from labelLargeDefault to moderate ? in figma is specified as Label/Large/Default

overflow: TextOverflow.ellipsis,
style: theme.typographyTokens
.typeLabelDefaultLarge(context)
.typeLabelModerateLarge(context)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you changed the typo here ? teh correct one is LabelLargeDefault

prefixToDisplay,
style: theme.typographyTokens
.typeLabelDefaultLarge(context)
.typeLabelModerateLarge(context)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the correct one as in figma is LabelLargeDefault

text,
baseStyle: theme.typographyTokens
.typeLabelDefaultMedium(context)
.typeLabelModerateMedium(context)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to typeLabelDefaultMedium as in figma

overflow: TextOverflow.ellipsis,
style: theme.typographyTokens
.typeLabelDefaultLarge(context)
.typeLabelModerateLarge(context)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the moderate is applied only for the filled text, do not make this change

'assets/communication/accessibility/accessibility-vision.svg';
final String communicationSecurityAndSafetyLockClosed =
'assets/communication/security-and-safety/lock-closed.svg';
final String communicationAssistanceTipsAndTricks =

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think no need to add this assets to use it in inputs you can use other assets already implemented in project

Comment thread ouds_core/CHANGELOG.md
- [Library] In library, update `link` component to v2.3.0 ([#838](https://github.com/Orange-OpenSource/ouds-flutter/issues/838))
- [Library] For `button` component, update to version 3.3.0 ([#832](https://github.com/Orange-OpenSource/ouds-flutter/issues/832))
- [Library] Update `progress-indicator`: add size parameter to OudsCircularProgressIndicator for button integration ([#876](https://github.com/Orange-OpenSource/ouds-flutter/issues/876))
- [Library] deps update dependency `dlibphonenumber` to 1.1.70

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enleve cette ligne

final String? hintText;
final String? suffixIcon;
final String? prefixIcon;
final OudsTextInputSuffixIconButton? suffixIcon;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on doit passer par deprecated d'abord si non on va casser l'API ici !

final String? suffixIcon;
final String? prefixIcon;
final OudsTextInputSuffixIconButton? suffixIcon;
final OudsTextInputPrefixIcon? prefixIcon;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on doit passer par deprecated d'abord si non on va casser l'API ici !

final String? suffix;
final String? errorText;
final bool? loader;
final OudsTextInputLoader? loader;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on doit passer par deprecated d'abord si non on va casser l'API ici !

@nouha06 nouha06 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • update the table in readme.md in core module to show the actuelle version of the components

  • update the version of the component in doc

from 1.3.0 to 1.3.1

/// OUDS Password Input Design Guidelines
///
/// Reference design version : 1.3.0

from 1.4.0 to 1.4.1

/// OUDS Text Input Design Guidelines
///
/// Reference design version : 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

2 participants