Merge pull request #50 from adriengivry/fix/negative_intensity_light_support

BenjaminViranin · web-flow · commit 09101fb880fc · 2019-11-11T13:26:18.000-05:00
Negative light are now supported
diff --git a/Sources/Overload/OvRendering/src/OvRendering/Entities/Light.cpp b/Sources/Overload/OvRendering/src/OvRendering/Entities/Light.cpp
@@ -52,7 +52,7 @@ OvMaths::FMatrix4 OvRendering::Entities::Light::GenerateMatrix() const
 float CalculateLuminosity(float p_constant, float p_linear, float p_quadratic, float p_intensity, float p_distance)
 {
 	auto attenuation = (p_constant + p_linear * p_distance + p_quadratic * (p_distance * p_distance));
-	return (1.0f / attenuation) * p_intensity;
+	return (1.0f / attenuation) * std::abs(p_intensity);
 }
 
 float CalculatePointLightRadius(float p_constant, float p_linear, float p_quadratic, float p_intensity)

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ OvMaths::FMatrix4 OvRendering::Entities::Light::GenerateMatrix() const`
`52`	`52`	`float CalculateLuminosity(float p_constant, float p_linear, float p_quadratic, float p_intensity, float p_distance)`
`53`	`53`	`{`
`54`	`54`	`auto attenuation = (p_constant + p_linear * p_distance + p_quadratic * (p_distance * p_distance));`
`55`		`- return (1.0f / attenuation) * p_intensity;`
	`55`	`+ return (1.0f / attenuation) * std::abs(p_intensity);`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`float CalculatePointLightRadius(float p_constant, float p_linear, float p_quadratic, float p_intensity)`