fix-missing-reference-asset-display (#741)

Author: Synyproxy

Sources/OvCore/include/OvCore/Helpers/GUIHelpers.h

@@ -62,6 +62,7 @@ namespace OvCore::Helpers
 		using PickerProviderCallback = std::function<void(PickerItemList, std::string)>;
 		using IconProviderCallback = std::function<uint32_t(OvTools::Utils::PathParser::EFileType)>;
 		using ActorSelectionProviderCallback = std::function<void(uint64_t)>;
+		using AssetExistsCallback = std::function<bool(const std::string&)>;
 
 		static void ProvideEmptyTexture(OvRendering::Resources::Texture& p_emptyTexture);
 		static OvRendering::Resources::Texture* GetEmptyTexture();
@@ -89,5 +90,8 @@ namespace OvCore::Helpers
 
 		static void SetActorSelectionProvider(ActorSelectionProviderCallback p_provider);
 		static void SelectActor(uint64_t p_guid);
+
+		static void SetAssetExistsChecker(AssetExistsCallback p_checker);
+		static bool AssetExists(const std::string& p_path);
 	};
 }

Sources/OvCore/src/OvCore/Helpers/GUIDrawer.cpp

@@ -170,8 +170,13 @@ void OvCore::Helpers::GUIDrawer::DrawColor(OvUI::Internal::WidgetContainer & p_r
 
 std::string OvCore::Helpers::GUIDrawer::GetAssetDisplayName(const std::string& p_path)
 {
+	if (p_path.empty())
+		return "";
 	const std::string friendly = OvTools::Utils::PathParser::GetFriendlyPath(p_path);
-	return friendly.empty() ? "" : std::filesystem::path(friendly).stem().string();
+	const std::string stem = friendly.empty() ? "" : std::filesystem::path(friendly).stem().string();
+	if (!GUIHelpers::AssetExists(p_path))
+		return stem.empty() ? "(Missing Reference)" : stem + " (Missing Reference)";
+	return stem;
 }
 
 std::string OvCore::Helpers::GUIDrawer::GetAssetTooltip(const std::string& p_path)

Sources/OvCore/src/OvCore/Helpers/GUIHelpers.cpp

@@ -16,6 +16,7 @@ namespace
 	OvCore::Helpers::GUIHelpers::IconProviderCallback __ICON_PROVIDER;
 	OvCore::Helpers::GUIHelpers::OpenProviderCallback __OPEN_PROVIDER;
 	OvCore::Helpers::GUIHelpers::ActorSelectionProviderCallback __ACTOR_SELECTION_PROVIDER;
+	OvCore::Helpers::GUIHelpers::AssetExistsCallback __ASSET_EXISTS_CHECKER;
 	uint32_t __ACTOR_ICON_ID = 0;
 
 	std::string TitleFromFileType(OvTools::Utils::PathParser::EFileType p_type)
@@ -122,3 +123,13 @@ void OvCore::Helpers::GUIHelpers::SelectActor(uint64_t p_guid)
 	if (__ACTOR_SELECTION_PROVIDER)
 		__ACTOR_SELECTION_PROVIDER(p_guid);
 }
+
+void OvCore::Helpers::GUIHelpers::SetAssetExistsChecker(AssetExistsCallback p_checker)
+{
+	__ASSET_EXISTS_CHECKER = std::move(p_checker);
+}
+
+bool OvCore::Helpers::GUIHelpers::AssetExists(const std::string& p_path)
+{
+	return __ASSET_EXISTS_CHECKER && __ASSET_EXISTS_CHECKER(p_path);
+}

Sources/OvEditor/src/OvEditor/Core/Editor.cpp

@@ -7,6 +7,8 @@
 #include "OvEditor/Core/EditorActions.h"
 #include <tracy/Tracy.hpp>
 
+#include <filesystem>
+
 #include <OvCore/Helpers/GUIDrawer.h>
 #include <OvCore/Helpers/GUIHelpers.h>
 
@@ -137,6 +139,14 @@ void OvEditor::Core::Editor::SetupUI()
 	if (auto* actorTexture = m_context.editorResources->GetTexture("Actor"))
 		OvCore::Helpers::GUIHelpers::SetActorIconID(actorTexture->GetTexture().GetID());
 
+	// Provide asset existence checker so AssetFields show "(Missing Reference)" for invalid paths.
+	OvCore::Helpers::GUIHelpers::SetAssetExistsChecker(
+		[this](const std::string& p_path)
+		{
+			return std::filesystem::exists(m_editorActions.GetRealPath(p_path));
+		}
+	);
+
 	// Provide actor selection so double-clicking an ActorField selects it in the inspector.
 	OvCore::Helpers::GUIHelpers::SetActorSelectionProvider(
 		[this](uint64_t p_guid)