Fixed inconsistent picking (Fixes #494)

Author: adriengivry

Sources/OvEditor/src/OvEditor/Panels/AView.cpp

@@ -87,11 +87,11 @@ void OvEditor::Panels::AView::DrawFrame()
 
 std::pair<uint16_t, uint16_t> OvEditor::Panels::AView::GetSafeSize() const
 {
-	constexpr float kTitleBarHeight = 25.0f; // <--- this takes into account the imgui window title bar
+	const float kTitleBarHeight = ImGui::GetFrameHeight(); // accounts for the imgui window title bar
 	const auto& size = GetSize();
 	return {
 		static_cast<uint16_t>(size.x),
-		static_cast<uint16_t>(std::max(0.0f, size.y - kTitleBarHeight)) // <--- clamp to prevent the output size to be negative
+		static_cast<uint16_t>(std::max(0.0f, size.y - kTitleBarHeight))
 	}; 
 }
 

Sources/OvEditor/src/OvEditor/Panels/SceneView.cpp

@@ -249,7 +249,7 @@ void OvEditor::Panels::SceneView::HandleActorPicking()
 
 		auto mousePosition = EDITOR_CONTEXT(inputManager)->GetMousePosition();
 
-		m_gizmoOperations.SetCurrentMouse({ static_cast<float>(mousePosition.first - m_position.x), static_cast<float>(mousePosition.second - m_position.y) });
+		m_gizmoOperations.SetCurrentMouse({ static_cast<float>(mousePosition.first - m_position.x), static_cast<float>(mousePosition.second - m_position.y - ImGui::GetFrameHeight()) });
 		m_gizmoOperations.ApplyOperation(m_camera.GetViewMatrix(), m_camera.GetProjectionMatrix(), m_camera.GetPosition(), { static_cast<float>(winWidth), static_cast<float>(winHeight) });
 		m_highlightedGizmoDirection = m_gizmoOperations.GetDirection();
 	}
@@ -260,7 +260,7 @@ OvEditor::Rendering::PickingRenderPass::PickingResult OvEditor::Panels::SceneVie
 	auto [mouseX, mouseY] = EDITOR_CONTEXT(inputManager)->GetMousePosition();
 	mouseX -= m_position.x;
 	mouseY -= m_position.y;
-	mouseY = GetSafeSize().second - mouseY + 25;
+	mouseY = GetSafeSize().second - mouseY + ImGui::GetFrameHeight();
 
 	auto& scene = *GetScene();