Skip to content

Commit 93600ff

Browse files
committed
glViewport wraps into OvRendering methods and remove GL call from Aview.cpp
1 parent 286b106 commit 93600ff

3 files changed

Lines changed: 18 additions & 1 deletion

File tree

Sources/Overload/OvEditor/src/OvEditor/Panels/AView.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,9 @@ void OvEditor::Panels::AView::Render()
5050

5151
EDITOR_CONTEXT(shapeDrawer)->SetViewProjection(m_camera.GetProjectionMatrix() * m_camera.GetViewMatrix());
5252

53-
glViewport(0, 0, winWidth, winHeight); // TODO: Move this OpenGL call to OvRendering
53+
auto renderer = EDITOR_CONTEXT(renderer).get();
54+
55+
renderer->SetViewPort(0, 0, winWidth, winHeight);
5456

5557
_Render_Impl();
5658
}

Sources/Overload/OvRendering/include/OvRendering/Core/Renderer.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,16 @@ namespace OvRendering::Core
157157
*/
158158
void SetColorWriting(bool p_enable);
159159

160+
161+
/**
162+
* Set the viewport parameters.
163+
* @param x
164+
* @param y
165+
* @param width
166+
* @param height
167+
*/
168+
void SetViewPort(uint16_t x, uint16_t y, uint16_t width, uint16_t height);
169+
160170
/**
161171
* Return the value associated to the given GLenum
162172
* @param p_parameter

Sources/Overload/OvRendering/src/OvRendering/Core/Renderer.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,11 @@ void OvRendering::Core::Renderer::SetColorWriting(bool p_enable)
102102
glColorMask(p_enable, p_enable, p_enable, p_enable);
103103
}
104104

105+
void OvRendering::Core::Renderer::SetViewPort(uint16_t x, uint16_t y, uint16_t width, uint16_t height)
106+
{
107+
glViewport(x, y, width, height);
108+
}
109+
105110
bool OvRendering::Core::Renderer::GetBool(GLenum p_parameter)
106111
{
107112
GLboolean result;

0 commit comments

Comments
 (0)