Fixed releasing mouse right click while in game unlocks the cursor (#557)

adriengivry · web-flow · commit e4d095670212 · 2025-05-23T13:41:24.000-04:00
diff --git a/Sources/Overload/OvEditor/src/OvEditor/Core/CameraController.cpp b/Sources/Overload/OvEditor/src/OvEditor/Core/CameraController.cpp
@@ -417,19 +417,19 @@ void OvEditor::Core::CameraController::HandleMousePressed()
 
 void OvEditor::Core::CameraController::HandleMouseReleased()
 {
-	if (m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_LEFT))
+	if (m_leftMousePressed && m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_LEFT))
 	{
 		m_leftMousePressed = false;
 		m_firstMouse = true;
 	}
 
-	if (m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_MIDDLE))
+	if (m_middleMousePressed && m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_MIDDLE))
 	{
 		m_middleMousePressed = false;
 		m_firstMouse = true;
 	}
 
-	if (m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_RIGHT))
+	if (m_rightMousePressed && m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_RIGHT))
 	{
 		m_rightMousePressed = false;
 		m_firstMouse = true;

Original file line number	Diff line number	Diff line change
`@@ -417,19 +417,19 @@ void OvEditor::Core::CameraController::HandleMousePressed()`
`417`	`417`
`418`	`418`	`void OvEditor::Core::CameraController::HandleMouseReleased()`
`419`	`419`	`{`
`420`		`- if (m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_LEFT))`
	`420`	`+ if (m_leftMousePressed && m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_LEFT))`
`421`	`421`	`{`
`422`	`422`	`m_leftMousePressed = false;`
`423`	`423`	`m_firstMouse = true;`
`424`	`424`	`}`
`425`	`425`
`426`		`- if (m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_MIDDLE))`
	`426`	`+ if (m_middleMousePressed && m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_MIDDLE))`
`427`	`427`	`{`
`428`	`428`	`m_middleMousePressed = false;`
`429`	`429`	`m_firstMouse = true;`
`430`	`430`	`}`
`431`	`431`
`432`		`- if (m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_RIGHT))`
	`432`	`+ if (m_rightMousePressed && m_inputManager.IsMouseButtonReleased(OvWindowing::Inputs::EMouseButton::MOUSE_BUTTON_RIGHT))`
`433`	`433`	`{`
`434`	`434`	`m_rightMousePressed = false;`
`435`	`435`	`m_firstMouse = true;`