Repository navigation
perf(map): vectorize Q10 palette rasterization using PIL P-mode - #971
Open
allenporter wants to merge 1 commit into
Open
allenporter wants to merge 1 commit into
allenporter wants to merge 1 commit into
Conversation
This was referenced Sep 28, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Benchmark input validation and reported median/percentile calculations need correction.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Optimizes Q10 map rasterization with Pillow palette mode and adds benchmark/profiling coverage.
Changes:
- Replaces per-cell RGBA construction with native indexed palette conversion.
- Adds Q10/V1 parsing and rendering benchmarks.
Review findings:
tests/map/test_benchmarks.py:196— Moderate (2 votes): reject iteration counts below one.tests/map/test_benchmarks.py:166— Moderate (1 vote): calculate the median and 95th percentile correctly.tests/map/test_benchmarks.py:166–167— Moderate (2 votes): use the standard two-point median for even sample counts.
| File | Summary |
|---|---|
tests/map/test_benchmarks.py |
Adds benchmark and profiling utilities. |
roborock/map/b01_q10_map_parser.py |
Vectorizes Q10 palette rasterization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
allenporter
marked this pull request as draft
September 28, 2026 03:46
allenporter
force-pushed
the
perf-q10-palette
branch
3 times, most recently
from
October 4, 2026 22:39
9d31449 to
5dbf4cf
Compare
allenporter
force-pushed
the
perf-q10-palette
branch
from
October 5, 2026 14:17
5dbf4cf to
79f2a93
Compare
allenporter
force-pushed
the
perf-q10-palette
branch
from
October 5, 2026 14:47
79f2a93 to
1d0f0cc
Compare
allenporter
marked this pull request as ready for review
October 5, 2026 14:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Vectorizes Q10 palette application in
B01Q10MapParser._renderusing PIL's nativeP(palette) mode with an RGBA color table converted to RGBA in C, replacing a Python loop that appended 4-byte color tuples across all grid cells.Performance Impact (Benchmarked on 200x200 grid)
Verification
uv run pytest tests/map/test_b01*).