Skip to content

fix(libcpu/arm): correct format specifiers in GIC dump functions - #11914

Open
Wei-beep wants to merge 2 commits into
RT-Thread:masterfrom
Wei-beep:fix/arm-gic-format-specifiers
Open

Wei-beep wants to merge 2 commits into
RT-Thread:masterfrom
Wei-beep:fix/arm-gic-format-specifiers

Conversation

@Wei-beep

@Wei-beep Wei-beep commented Oct 21, 2026 •

Copy link
Copy Markdown

Fix -Wformat warnings in arm_gic_dump_type() and arm_gic_dump() for both GICv2 (gic.c) and GICv3 (gicv3.c):

  • %p with rt_uint32_t physical address -> 0x%08x (non-pointer passed to %p is undefined behavior)
  • %d with unsigned int / unsigned long -> %u (signed/unsigned mismatch)
  • Add explicit (unsigned int) cast for GIC version extracted with 0xfUL

These warnings appear when compiling Cortex-A BSPs with -Wall -Wformat.

拉取/合并请求描述:(PR description)

为什么提交这份PR (why to submit this PR)

在 libcpu/arm/cortex-a/gic.c 和 gicv3.c 的 GIC 信息打印函数中,存在 4 类格式说明符与参数类型不匹配的问题,使用 -Wall -Wformat 编译 Cortex-A BSP 时会产生警告:

  1. %p 用于 rt_uint32_t 类型的物理地址(dist_hw_base)—— 向 %p 传入非指针是未定义行为(UB)
  2. %d 用于 unsigned long 类型的 GIC 版本号 —— 符号不匹配
  3. %d 用于 unsigned int 类型的 _gic_max_irq —— 符号不匹配
  4. %d 用于 unsigned int 类型的中断号 k —— 符号不匹配

There are 4 types of format specifier mismatches in the GIC dump functions of libcpu/arm/cortex-a/gic.c and gicv3.c, producing -Wformat warnings when compiling Cortex-A BSPs:

  1. %p used with rt_uint32_t physical address — passing non-pointer to %p is undefined behavior
  2. %d used with unsigned long GIC version — signed/unsigned mismatch
  3. %d used with unsigned int _gic_max_irq — signed/unsigned mismatch
  4. %d used with unsigned int IRQ number k — signed/unsigned mismatch

你的解决方案是什么 (what is your solution)

文件 函数 修改
gic.c arm_gic_dump_type %p→0x%08x, %d→%u (2处), 增加 (unsigned int) cast
gic.c arm_gic_dump %d→%u
gicv3.c arm_gic_dump_type %p→0x%08x, %d→%u (2处), 增加 (unsigned int) cast
gicv3.c arm_gic_dump %d→%u

仅修改格式说明符,不改变任何运行时逻辑。%p→0x%08x 同时修复了未定义行为。

Only format specifiers are changed; no runtime logic is modified. The %p→0x%08x change also fixes undefined behavior.

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/qemu-vexpress-a9 (GICv2,Cortex-A9)
  • .config: 默认配置,无需改动(GIC 驱动默认编译)
  • action: clang-format workflow 已通过,静态类型检查验证

说明:本修改仅涉及 rt_kprintf 格式说明符,不改变控制流或数据处理逻辑,风险极低。类型匹配关系已通过源码静态检查确认:dist_hw_base 为 rt_uint32_t、_gic_max_irq 为 unsigned int、k 为 unsigned int、GIC 版本表达式结果为 unsigned long。

Note: This change only affects rt_kprintf format specifiers and does not alter control flow or data processing logic. Type matching has been verified via static code review: dist_hw_base is rt_uint32_t, _gic_max_irq is unsigned int, k is unsigned int, GIC version expression yields unsigned long.

当前拉取/合并请求的状态 Intent for your PR

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用 clang-format 源码格式化工具确保格式符合RT-Thread代码规范
  • 如果是新增bsp, 已经添加ci检查

Fix -Wformat warnings in arm_gic_dump_type() and arm_gic_dump() for
both GICv2 (gic.c) and GICv3 (gicv3.c):

- %p with rt_uint32_t physical address -> 0x%08x (non-pointer passed to
  %p is undefined behavior)
- %d with unsigned int / unsigned long -> %u (signed/unsigned mismatch)
- Add explicit (unsigned int) cast for GIC version extracted with 0xfUL

These warnings appear when compiling Cortex-A BSPs with -Wall -Wformat.
@CLAassistant

CLAassistant commented Oct 21, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支(通常为 master)
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 fix/arm-gic-format-specifiers
    Enter PR branch fix/arm-gic-format-specifiers in the branch field
  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后,提交将自动更新至 fix/arm-gic-format-specifiers 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/arm-gic-format-specifiers branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants