Expanded cell specialization effects#6826
Conversation
… for advanced organelles being larger.
…on' into changed-specialisation-calculation
…on' into changed-specialisation-calculation
…ntal tolerances from organelles.
|
For anyone seeing that last commit: I just implemented the calculations in the "lowest levels" possible to see everything that would have to be changed to match. So I am aware that it is 100% not efficient yet. Just want to see if I can get it to work yet. (Also, on the gameplay side I got stuck on EndosymbiontOrganelleSystem/MicrobeReproductionSystem for now) |
… for updating already spawned entities.
…o mimic the boosted effect for auto-evo.
…d cell specilization values instead of recalculating
…e RepositionToOrigin (which includes updating the SpecializationBonus)
…ll to use RepositionToOrigin (which includes updating the SpecializationBonus)" This reverts commit 4c885d2.
|
Considering the extensive changes since this was test-approved, I'll request another round of testing if and when the code is approved. |
|
I think I'll try to get this into a mergeable state today so that we can finally merge this. |
Alright, I will take a look at resolving the merge conflicts soon. (edit: ah, you already did) And if any bugs around this pop up I will be available to try and fix them. Just to note, once everything else is done, here I do also need to update the tooltip for specialization. |
|
I think I fixed the merge conflict correctly. I'll do some final code reviewing on this and some minor testing next (soon). |
Which tooltip? I've got it on my TODO list that multicellular specialization tooltip must be updated as the wording doesn't really work for multicellular. |
The tooltip on the specialization number itself in the microbe/cell editor. Right now it still says simply that it increases bioprocess speed, which obviously does not cover the function anymore.
This is the tooltip on the number in the multicellular part of the editor? I can look at that at the same time if you want. |
Yes, and it also is missing the fact that positioning now also increases the specialization bonus. |
Alright, I can add that at the same time, just let me know when I can update the localization. |
|
Well I think now would be about as good time as any (to include the translations in this PR, as I have only a few things left to check). |
|
I'm pretty much ready to merge this now, even without the text changes. If the translations can be done soon, I can wait some time, but otherwise I think I'd like to merge this and make a separate PR from updating the multicellular specialization tooltip and I could at the same time update the other tooltip as well. |
hhyyrylainen
left a comment
There was a problem hiding this comment.
I didn't put in code to verify that the specializations are always correct and updated (it would be quite a bit of code to properly track unupdated specialization values) but I saw nothing overtly breaking in my testing runs of this.
Can do it now, just give me a few minutes. |
… tooltip as players won't yet know what a cell type is
|
I slightly adjusted the text as the multicellular variant was getting close to being as wide as the screen, and the microbe variant used the term "cell type" which I think needs to be avoided there as players who have not yet played the multicellular stage will not know what a "cell type" is (as the concept is not present yet in the microbe stage). |
Ah yes, fair enough. Those seem like good changes then. |
Brief Description of What This PR Does
This PR is intended to expand the cell specialisation bonus to affect more than just process speeds.
Currently affects:
Tooltip on the specilization bonus in the editor still needs to be updated, which I will do once everything else is approved.
Related Issues
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.