Skip to content

Expanded cell specialization effects#6826

Merged
hhyyrylainen merged 103 commits into
masterfrom
expanded-cell-specialization-effects
May 12, 2026
Merged

Expanded cell specialization effects#6826
hhyyrylainen merged 103 commits into
masterfrom
expanded-cell-specialization-effects

Conversation

@Accidental-Explorer
Copy link
Copy Markdown
Contributor

@Accidental-Explorer Accidental-Explorer commented Mar 18, 2026

Brief Description of What This PR Does

This PR is intended to expand the cell specialisation bonus to affect more than just process speeds.

Currently affects:

  • Positive environmental tolerance effects from organelles.
  • Storage capacities from organelles.
  • Movement speed from organelles (only flagella right now)
  • Turning speed from organelles (only cillia right now)
  • Digestion speed and efficiency from organelles.
  • Toxin fire rate reduction from organelles.
  • Auto-evo bonuses to emulate all of the above.

Tooltip on the specilization bonus in the editor still needs to be updated, which I will do once everything else is approved.

Related Issues

  • Subjective: cell specialisation only has a smaller indirect benefit for cells specialising in non-process tasks like movement.
  • Subjective: cell specialisation can allow you to reduce ATP production parts, but that currently also drops your oxygen tolerance as a side effect if you're using oxygen metabolism.
  • Cell specialisation makes the bioluminescent vacuole worse by increasing its ATP consumption without improving its oxygen tolerance benefit. (At least for auto-evo. There is actually a cap on the consumption of luciferin in-gameplay, so the effect is limited there)

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@Accidental-Explorer
Copy link
Copy Markdown
Contributor Author

For anyone seeing that last commit: I just implemented the calculations in the "lowest levels" possible to see everything that would have to be changed to match. So I am aware that it is 100% not efficient yet. Just want to see if I can get it to work yet.

(Also, on the gameplay side I got stuck on EndosymbiontOrganelleSystem/MicrobeReproductionSystem for now)

…d cell specilization values instead of recalculating
…e RepositionToOrigin (which includes updating the SpecializationBonus)
…ll to use RepositionToOrigin (which includes updating the SpecializationBonus)"

This reverts commit 4c885d2.
@Accidental-Explorer
Copy link
Copy Markdown
Contributor Author

Considering the extensive changes since this was test-approved, I'll request another round of testing if and when the code is approved.

@hhyyrylainen
Copy link
Copy Markdown
Member

I think I'll try to get this into a mergeable state today so that we can finally merge this.
If any new bugs are discovered hopefully you can then help out with those.

@Accidental-Explorer
Copy link
Copy Markdown
Contributor Author

Accidental-Explorer commented May 12, 2026

I think I'll try to get this into a mergeable state today so that we can finally merge this. If any new bugs are discovered hopefully you can then help out with those.

Alright, I will take a look at resolving the merge conflicts soon. (edit: ah, you already did)

And if any bugs around this pop up I will be available to try and fix them.

Just to note, once everything else is done, here I do also need to update the tooltip for specialization.

@hhyyrylainen
Copy link
Copy Markdown
Member

I think I fixed the merge conflict correctly. I'll do some final code reviewing on this and some minor testing next (soon).

@hhyyrylainen
Copy link
Copy Markdown
Member

Just to note, once everything else is done, here I do also need to update the tooltip for specialization.

Which tooltip? I've got it on my TODO list that multicellular specialization tooltip must be updated as the wording doesn't really work for multicellular.

@Accidental-Explorer
Copy link
Copy Markdown
Contributor Author

Which tooltip?

The tooltip on the specialization number itself in the microbe/cell editor. Right now it still says simply that it increases bioprocess speed, which obviously does not cover the function anymore.

I've got it on my TODO list that multicellular specialization tooltip must be updated as the wording doesn't really work for multicellular.

This is the tooltip on the number in the multicellular part of the editor? I can look at that at the same time if you want.

@hhyyrylainen
Copy link
Copy Markdown
Member

This is the tooltip on the number in the multicellular part of the editor? I can look at that at the same time if you want.

Yes, and it also is missing the fact that positioning now also increases the specialization bonus.

@Accidental-Explorer
Copy link
Copy Markdown
Contributor Author

Yes, and it also is missing the fact that positioning now also increases the specialization bonus.

Alright, I can add that at the same time, just let me know when I can update the localization.

@hhyyrylainen
Copy link
Copy Markdown
Member

Well I think now would be about as good time as any (to include the translations in this PR, as I have only a few things left to check).

@hhyyrylainen
Copy link
Copy Markdown
Member

I'm pretty much ready to merge this now, even without the text changes. If the translations can be done soon, I can wait some time, but otherwise I think I'd like to merge this and make a separate PR from updating the multicellular specialization tooltip and I could at the same time update the other tooltip as well.

Copy link
Copy Markdown
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't put in code to verify that the specializations are always correct and updated (it would be quite a bit of code to properly track unupdated specialization values) but I saw nothing overtly breaking in my testing runs of this.

@Accidental-Explorer
Copy link
Copy Markdown
Contributor Author

I'm pretty much ready to merge this now, even without the text changes. If the translations can be done soon, I can wait some time, but otherwise I think I'd like to merge this and make a separate PR from updating the multicellular specialization tooltip and I could at the same time update the other tooltip as well.

Can do it now, just give me a few minutes.

@hhyyrylainen
Copy link
Copy Markdown
Member

I slightly adjusted the text as the multicellular variant was getting close to being as wide as the screen, and the microbe variant used the term "cell type" which I think needs to be avoided there as players who have not yet played the multicellular stage will not know what a "cell type" is (as the concept is not present yet in the microbe stage).

@Accidental-Explorer
Copy link
Copy Markdown
Contributor Author

I slightly adjusted the text as the multicellular variant was getting close to being as wide as the screen, and the microbe variant used the term "cell type" which I think needs to be avoided there as players who have not yet played the multicellular stage will not know what a "cell type" is (as the concept is not present yet in the microbe stage).

Ah yes, fair enough. Those seem like good changes then.

@hhyyrylainen hhyyrylainen merged commit 9670c1c into master May 12, 2026
4 checks passed
@hhyyrylainen hhyyrylainen deleted the expanded-cell-specialization-effects branch May 12, 2026 11:48
@github-project-automation github-project-automation Bot moved this from In progress to Done in Thrive Planning May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants