From 5ab846eeac678d51e3e2330d196dc32cee95144d Mon Sep 17 00:00:00 2001
From: brentru <robots199Wme.com>
Date: Sat, 9 Mar 2019 14:55:18 -0500
Subject: [PATCH 1/2] small code updates

---
 BowieLights.cpp | 19 ++++++++++++++-----
 BowieScoop.cpp  | 14 ++++++++++----
 BowieScoop.h    |  3 +++
 3 files changed, 27 insertions(+), 9 deletions(-)

diff --git a/BowieLights.cpp b/BowieLights.cpp
index f344269..0b9830f 100644
--- a/BowieLights.cpp
+++ b/BowieLights.cpp
@@ -64,19 +64,24 @@ void BowieLights::dimLights() {
 }
 
 void BowieLights::setLight(uint8_t led_num, uint8_t val) {
-  if(led_num == 0) {
+  switch (led_num) {
+  case 0:
     analogWrite(BRIGHT_LED_FRONT_LEFT, val);
     led_val[0] = val;
-  } else if(led_num == 1) {
+    break;
+  case 1:
     analogWrite(BRIGHT_LED_FRONT_RIGHT, val);
     led_val[1] = val;
-  } else if(led_num == 2) {
+    break;
+  case 2:
     analogWrite(BRIGHT_LED_BACK_LEFT, val);
     led_val[2] = val;
-  } else if(led_num == 3) {
+    break;
+  case 3:
     analogWrite(BRIGHT_LED_BACK_RIGHT, val);
     led_val[3] = val;
-  } else if(led_num == 99) {
+    break;
+  case 99:
     analogWrite(BRIGHT_LED_FRONT_LEFT, val);
     analogWrite(BRIGHT_LED_BACK_LEFT, val);
     analogWrite(BRIGHT_LED_FRONT_RIGHT, val);
@@ -84,6 +89,10 @@ void BowieLights::setLight(uint8_t led_num, uint8_t val) {
     for(int i=0; i<4; i++) {
       led_val[i] = val;
     }
+    break;
+  default:
+    Serial.println("ERROR: Undefined led_num specified");
+    break;
   }
 }
 
diff --git a/BowieScoop.cpp b/BowieScoop.cpp
index 1f3c9e8..b3e60e1 100644
--- a/BowieScoop.cpp
+++ b/BowieScoop.cpp
@@ -52,8 +52,10 @@ void BowieScoop::servoInterruption(int key, int val) {
 void BowieScoop::updateScoopProbes() {
   scoop_probe_left_val = digitalRead(SCOOP_PROBE_LEFT);
   scoop_probe_right_val = digitalRead(SCOOP_PROBE_RIGHT);
-  //Serial << "Scoop probes- L: " << scoop_probe_left_val;
-  //Serial << "Scoop probes- R: " << scoop_probe_right_val << endl;
+  #ifdef SERVO_DEBUG:
+    Serial << "Scoop probes- L: " << scoop_probe_left_val;
+    Serial << "Scoop probes- R: " << scoop_probe_right_val << endl;
+  #endif
 }
 
 bool BowieScoop::getScoopProbeL() {
@@ -80,7 +82,9 @@ void BowieScoop::moveEnd(int endPos, int step, int del) {
   int prev_pos = getEndPos();
   if(prev_pos > endPos) { // going towards END_MIN
     for(int i=prev_pos; i>endPos; i-=step) {
-      //Serial << "S" << i << endl;
+      #ifdef SERVO_DEBUG
+        Serial << "S" << i << endl;
+      #endif
       scoop.writeMicroseconds(i);
       end_position = i;
       delay(del);
@@ -88,7 +92,9 @@ void BowieScoop::moveEnd(int endPos, int step, int del) {
     }
   } else if(prev_pos <= endPos) { // going towards END_MAX
     for(int i=prev_pos; i<endPos; i+=step) {
-      //Serial << "S" << i << endl;
+      #ifdef SERVO_DEBUG
+        Serial << "S" << i << endl;
+      #endif
       scoop.writeMicroseconds(i);
       end_position = i;
       delay(del);
diff --git a/BowieScoop.h b/BowieScoop.h
index c10e1be..bba5d61 100644
--- a/BowieScoop.h
+++ b/BowieScoop.h
@@ -26,6 +26,9 @@
 #ifndef _BOWIESCOOP_H_
 #define _BOWIESCOOP_H_
 
+// optional servo positional debugging
+#define SERVO_DEBUG False
+
 // Servo positions
 #define END_MIN 700 // up
 #define END_PARALLEL_TOP 2300 // parallel to ground when arm is raised, raised a bit to keep debris in

From f8a1d357aef20744bb6c36b786637b135ae6f680 Mon Sep 17 00:00:00 2001
From: brentru <robots199Wme.com>
Date: Sat, 9 Mar 2019 14:58:13 -0500
Subject: [PATCH 2/2] rm dsstore, gitignore at base of repo

---
 .DS_Store                           | Bin 6148 -> 0 bytes
 .gitignore/.gitignore => .gitignore |   2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 delete mode 100644 .DS_Store
 rename .gitignore/.gitignore => .gitignore (91%)

diff --git a/.DS_Store b/.DS_Store
deleted file mode 100644
index 8222cb599a7b0b7c5cf4f4f529f94bc7053e509a..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 6148
zcmeHKOKQU~5S?kWFm#h;m%4&)AcA`WuL}urX%{guw1F&jjb5zh>6=fB-3YoVrIZ<v
z-bi{Q$qy`Ph=@0*p(R=qQG+7L;#5q!t3y{#UIAI>nCL(c^n7@1`^rRru}k*eV9#gT
z(MYrX?~mg&+wcWvJa*l1df5}b4fn6gtZ;^JInz_ye_3m`Y`CF7C=d#S0-?Z<D}Xy&
zthq6aIur;6LV-^O<a|gdg4wYc>d}EpQvjemqt)O`E+H|=F*_DRjKJ7JffmZ1Vz7my
zKRGWu7DEds_T+<o<&Wfrb#=_2lun!tqYec^fu#c1)?CZ|e}`YDn&dA-q7@2+0{=__
zUUhx9!AJSsdhvO3*Cv!LikR?<I57B&M*tdfj@;^?jVJNJ%Z|lRW|4jk2gXA{1&JyY
I_yq;t0TZh$xBvhE

diff --git a/.gitignore/.gitignore b/.gitignore
similarity index 91%
rename from .gitignore/.gitignore
rename to .gitignore
index 8bfaac4..02a8558 100644
--- a/.gitignore/.gitignore
+++ b/.gitignore
@@ -6,4 +6,4 @@
 .Spotlight-V100
 .Trashes
 ehthumbs.db
-Thumbs.db
+Thumbs.db
\ No newline at end of file