Skip to content

fix: media auto-download options are not visible in bottom sheet #7374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rohit3523 wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

fix: media auto-download options are not visible in bottom sheet #7374

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ae71ef1
add height to picker item
Rohit3523 Jun 2, 2026
d4a0e4c
Added separator
Rohit3523 Jun 2, 2026
c9489e5
chore: format code and fix lint issues
Rohit3523 Jun 2, 2026
ee48669
e2e test
Rohit3523 Jun 2, 2026
0442544
Merge branch 'bottom-sheet-item-fix' of https://github.com/RocketChat…
Rohit3523 Jun 2, 2026
af5b3d3
Merge branch 'develop' into bottom-sheet-item-fix
Rohit3523 Jun 2, 2026
19022d7
Merge branch 'develop' into bottom-sheet-item-fix
Rohit3523 Jun 3, 2026
0e58e7d
remove flex and fixed height
Rohit3523 Jun 5, 2026
3c28e5e
test update
Rohit3523 Jun 5, 2026
d4945d7
Merge branch 'bottom-sheet-item-fix' of https://github.com/RocketChat…
Rohit3523 Jun 5, 2026
ec6dac7
Merge branch 'develop' into bottom-sheet-item-fix
Rohit3523 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions app/views/MediaAutoDownloadView/ListPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ const styles = StyleSheet.create({
flex: 1,
justifyContent: 'center',
alignItems: 'flex-end'
},
pickerItem: {
height: 48

@diegolmello diegolmello Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get this from? Is it used in other places?

Asking because there's a chance this is breaking a11y.

@Rohit3523 Rohit3523 Jun 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup we are using this value in other place like UIKit and notification preference setting

}
});

Expand Down Expand Up @@ -71,16 +74,21 @@ const ListPicker = ({

const getOptions = () => (
<View style={{ backgroundColor: colors.surfaceRoom, marginBottom: insets.bottom }}>
<List.Separator />
{OPTIONS.map(i => (
<List.Radio
onPress={() => {
hideActionSheet();
onChangeValue(i.value);
}}
title={i.label}
value={i.value}
isSelected={option.value === i.value}
/>
<>
<List.Radio
onPress={() => {
hideActionSheet();
onChangeValue(i.value);
}}
title={i.label}
value={i.value}
isSelected={option.value === i.value}
style={styles.pickerItem}
/>
<List.Separator />
</>
))}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</View>
);
Expand Down