feat: agenda Jobs admin page by Khizarshah01 · Pull Request #40699 · RocketChat/Rocket.Chat

Khizarshah01 · 2026-05-26T18:25:32Z

Proposed changes

Agenda Jobs Admin Page

This PR will contain the work for the Agenda Jobs Administration Page.

Progress (Backend):

Issue(s)

GSoC 2026 Agenda Job Admin Page

dionisio-bot · 2026-05-26T18:25:37Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2026-05-26T18:25:39Z

⚠️ No Changeset found

Latest commit: ce6b0a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-05-26T18:26:03Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 76661808-1e23-446d-adf4-fd9889b6c6bb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cubic-dev-ai

6 issues found across 27 files

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/meteor/app/api/server/v1/cronJobs.ts">

<violation number="1" location="apps/meteor/app/api/server/v1/cronJobs.ts:1">
P2: Substantial duplicated endpoint logic across cron.enable, cron.disable, and cron.trigger increases maintenance drift risk. All three share identical auth/permission/body/response configuration and identical action handler error-handling structure, differing only in the service method called. Consider consolidating via a shared handler factory.</violation>
</file>

<file name="apps/meteor/server/services/cron-jobs/service.ts">

<violation number="1" location="apps/meteor/server/services/cron-jobs/service.ts:12">
P2: Duplicate query, mapping, and response-building logic between `getCoreJobs` and `getAppJobs`</violation>

<violation number="2" location="apps/meteor/server/services/cron-jobs/service.ts:16">
P2: Paginated core/app job listing lacks explicit sort, making pagination order potentially unstable.</violation>
</file>

<file name="packages/core-typings/src/ICronJobItem.ts">

<violation number="1" location="packages/core-typings/src/ICronJobItem.ts:18">
P2: `status` is typed as unconstrained `string` instead of the finite union `CronJobStatus` ('running' | 'scheduled' | 'failed' | 'disabled' | 'completed') that the backend derives and returns.</violation>
</file>

<file name="apps/meteor/tests/end-to-end/api/cron-jobs.ts">

<violation number="1" location="apps/meteor/tests/end-to-end/api/cron-jobs.ts:1">
P2: Missing happy-path coverage for the cron.trigger / cron.enable / cron.disable endpoints; the test file only checks failure cases and never verifies the successful response path.</violation>

<violation number="2" location="apps/meteor/tests/end-to-end/api/cron-jobs.ts:39">
P2: Missing assertions for pagination metadata in cron.appjobs and cron.history success tests allow regressions in count/offset/total to slip through.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

cubic-dev-ai · 2026-06-09T14:15:36Z

@@ -0,0 +1,232 @@
+import { CronJobsSvc } from '@rocket.chat/core-services';


P2: Substantial duplicated endpoint logic across cron.enable, cron.disable, and cron.trigger increases maintenance drift risk. All three share identical auth/permission/body/response configuration and identical action handler error-handling structure, differing only in the service method called. Consider consolidating via a shared handler factory.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/app/api/server/v1/cronJobs.ts: <comment>Substantial duplicated endpoint logic across cron.enable, cron.disable, and cron.trigger increases maintenance drift risk. All three share identical auth/permission/body/response configuration and identical action handler error-handling structure, differing only in the service method called. Consider consolidating via a shared handler factory.</comment> <file context> @@ -0,0 +1,232 @@ +import { CronJobsSvc } from '@rocket.chat/core-services'; +import type { ICronJobItem, ICronHistoryItem } from '@rocket.chat/core-typings'; +import { ajv, ajvQuery, validateUnauthorizedErrorResponse, validateBadRequestErrorResponse } from '@rocket.chat/rest-typings'; + +import type { ExtractRoutesFromAPI } from '../ApiClass'; +import { API } from '../api'; +import { getPaginationItems } from '../helpers/getPaginationItems'; + +const isCronJobsListParams = ajvQuery.compile<{ </file context>

cubic-dev-ai · 2026-06-09T14:15:36Z

+export class CronJobsService extends ServiceClassInternal implements ICronJobsService {
+	protected name = 'cron-jobs';
+
+	async getCoreJobs(pagination?: {


P2: Duplicate query, mapping, and response-building logic between getCoreJobs and getAppJobs

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/server/services/cron-jobs/service.ts, line 12: <comment>Duplicate query, mapping, and response-building logic between `getCoreJobs` and `getAppJobs`</comment> <file context> @@ -0,0 +1,105 @@ +export class CronJobsService extends ServiceClassInternal implements ICronJobsService { + protected name = 'cron-jobs'; + + async getCoreJobs(pagination?: { + offset?: number; + count?: number; </file context>

cubic-dev-ai · 2026-06-09T14:15:36Z

+		offset?: number;
+		count?: number;
+	}): Promise<{ jobs: ICronJobItem[]; count: number; offset: number; total: number }> {
+		const { cursor, totalCount } = CronJobs.findPaginated(


P2: Paginated core/app job listing lacks explicit sort, making pagination order potentially unstable.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/server/services/cron-jobs/service.ts, line 16: <comment>Paginated core/app job listing lacks explicit sort, making pagination order potentially unstable.</comment> <file context> @@ -0,0 +1,105 @@ + offset?: number; + count?: number; + }): Promise<{ jobs: ICronJobItem[]; count: number; offset: number; total: number }> { + const { cursor, totalCount } = CronJobs.findPaginated( + { + name: { $not: /^Apps-/ }, </file context>

cubic-dev-ai · 2026-06-09T14:15:36Z

+	failCount?: number;
+	lastModifiedBy?: string;
+	data?: Record<string, any>;
+	status?: string;


P2: status is typed as unconstrained string instead of the finite union CronJobStatus ('running' | 'scheduled' | 'failed' | 'disabled' | 'completed') that the backend derives and returns.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/core-typings/src/ICronJobItem.ts, line 18: <comment>`status` is typed as unconstrained `string` instead of the finite union `CronJobStatus` ('running' | 'scheduled' | 'failed' | 'disabled' | 'completed') that the backend derives and returns.</comment> <file context> @@ -0,0 +1,19 @@ + failCount?: number; + lastModifiedBy?: string; + data?: Record<string, any>; + status?: string; +} \ No newline at end of file </file context>

cubic-dev-ai · 2026-06-09T14:15:36Z

@@ -0,0 +1,204 @@
+import { expect } from 'chai';


P2: Missing assertions for pagination metadata in cron.appjobs and cron.history success tests allow regressions in count/offset/total to slip through.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/tests/end-to-end/api/cron-jobs.ts, line 39: <comment>Missing assertions for pagination metadata in cron.appjobs and cron.history success tests allow regressions in count/offset/total to slip through.</comment> <file context> @@ -0,0 +1,204 @@ + .expect(200) + .expect((res) => { + expect(res.body).to.have.property('success', true); + expect(res.body).to.have.property('jobs').and.to.be.an('array'); + expect(res.body).to.have.property('offset'); + expect(res.body).to.have.property('total'); </file context>

cubic-dev-ai · 2026-06-09T14:15:36Z

@@ -0,0 +1,204 @@
+import { expect } from 'chai';


P2: Missing happy-path coverage for the cron.trigger / cron.enable / cron.disable endpoints; the test file only checks failure cases and never verifies the successful response path.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/tests/end-to-end/api/cron-jobs.ts: <comment>Missing happy-path coverage for the cron.trigger / cron.enable / cron.disable endpoints; the test file only checks failure cases and never verifies the successful response path.</comment> <file context> @@ -0,0 +1,204 @@ +import { expect } from 'chai'; +import { before, describe, it, after } from 'mocha'; + +import { getCredentials, api, request, credentials } from '../../data/api-data'; +import { updatePermission } from '../../data/permissions.helper'; + +describe('[Cron Jobs API]', () => { + before((done) => getCredentials(done)); + </file context>

KevLehman · 2026-06-09T16:55:52Z

 export const OmnichannelEEService = proxify<IOmnichannelEEService>('omnichannel-ee');
 export const Import = proxify<IImportService>('import');
 export const OmnichannelAnalytics = proxify<IOmnichannelAnalyticsService>('omnichannel-analytics');
+export const CronJobsSvc = proxify<ICronJobsService>('cron-jobs');


Don't name services svc. Its implied from the package where you're importing them.

dionisio-bot Bot added the community label May 26, 2026

Khizarshah01 force-pushed the feat/agenda-jobs-admin branch 2 times, most recently from 12de5e9 to 2b14da9 Compare May 30, 2026 09:46

dionisio-bot Bot added stat: conflict and removed stat: conflict labels Jun 5, 2026

Khizarshah01 added 13 commits June 5, 2026 18:54

feat: create cronjobs model and typings

9f97bb2

feat: implement cronjobs service and status derivation logic

678e28d

feat: added cron.jobs api endpoint

63e4dd1

feat: added cron.appjobs api endpoint

342df5a

feat: added cron.history api endpoint

63bd57d

feat: add pagination to cron API endpoints

9dea259

refactor: rewrite the endpoint into new way AJV schema

60a71ed

feat: added enable and disable api endpoint

57baa54

feat: added cron.trigger job api endpoint

4a1b58e

feat: added history logging for system and app jobs

15ad020

feat: added history logging for omnichannel schedulers

ddc1a6d

feat: added permission manage-scheduled-jobs for endpoints

bc7db57

fix: remove unique constraint and fix cron history index order

ab78bd0

Khizarshah01 force-pushed the feat/agenda-jobs-admin branch from 9a73a91 to ab78bd0 Compare June 5, 2026 15:19

Khizarshah01 added 4 commits June 7, 2026 13:08

feat: add i18n translation keys

bd67e2d

refactor: implement strict AJV schemas for cron jobs API

bc1629e

test: add integration and unit tests for cron jobs

4bfde0d

chore: fix prettier and import order linting errors

ba88d56

KevLehman marked this pull request as ready for review June 9, 2026 14:04

KevLehman requested review from a team as code owners June 9, 2026 14:04

KevLehman requested a review from a team as a code owner June 9, 2026 14:04

KevLehman marked this pull request as draft June 9, 2026 14:05

cubic-dev-ai Bot reviewed Jun 9, 2026

View reviewed changes

chore: fix formatting in packages

ce6b0a3

KevLehman reviewed Jun 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: agenda Jobs admin page#40699

feat: agenda Jobs admin page#40699
Khizarshah01 wants to merge 18 commits into
RocketChat:developfrom
Khizarshah01:feat/agenda-jobs-admin

Khizarshah01 commented May 26, 2026 •

edited

Loading

Uh oh!

dionisio-bot Bot commented May 26, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented May 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 26, 2026 •

edited

Loading

Review skipped

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Uh oh!

KevLehman Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,232 @@
		import { CronJobsSvc } from '@rocket.chat/core-services';

Conversation

Khizarshah01 commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Issue(s)

Uh oh!

dionisio-bot Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

KevLehman Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Khizarshah01 commented May 26, 2026 •

edited

Loading

dionisio-bot Bot commented May 26, 2026 •

edited

Loading

changeset-bot Bot commented May 26, 2026 •

edited

Loading

coderabbitai Bot commented May 26, 2026 •

edited

Loading