Skip to content

chore!: remove WebDav integration#40856

Draft
yasnagat wants to merge 5 commits into
release-9.0.0from
webdav-integration-removal
Draft

chore!: remove WebDav integration#40856
yasnagat wants to merge 5 commits into
release-9.0.0from
webdav-integration-removal

Conversation

@yasnagat

@yasnagat yasnagat commented Jun 9, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

This PR removes the WebDAV integration from the codebase.
WebDAV has been officially deprecated in Rocket.Chat and is already scheduled to be removed in upcoming versions, as announced in our documentation. Additionally, the integration relied on third-party libraries that have had recurring security vulnerabilities (CVEs), making its removal also a security improvement.
WebDAV support is no longer available after this change.

Changes implemented:

  • Removed WebDAV-related features and code paths from the application.
  • Excluded WebDAV files from the codebase.
  • Updated existing files to remove WebDAV-specific logic and dependencies.
  • Added a database migration to remove WebDAV configuration/settings from existing databases.
  • Added migration tests to verify WebDAV data is properly removed.
  • Added upgrade validation checks to detect workspaces that still have WebDAV configured before allowing the upgrade process to continue.

Issue(s)

VLN-345

Steps to test or reproduce

Further comments

@dionisio-bot

dionisio-bot Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e7843e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b6927524-7802-4643-8700-820eaf801ea3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.16%. Comparing base (1a6aafa) to head (e7843e0).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-9.0.0   #40856      +/-   ##
=================================================
+ Coverage          70.05%   70.16%   +0.11%     
=================================================
  Files               3355     3340      -15     
  Lines             129153   128888     -265     
  Branches           22385    22304      -81     
=================================================
- Hits               90475    90435      -40     
+ Misses             35384    35159     -225     
  Partials            3294     3294
Flag Coverage Δ
e2e 59.64% <ø> (+0.28%) ⬆️
e2e-api 46.94% <20.00%> (+0.68%) ⬆️
unit 69.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yasnagat yasnagat added this to the 9.0.0 milestone Jun 9, 2026
@ggazzo ggazzo changed the base branch from develop to release-9.0.0 June 12, 2026 02:00
@ggazzo ggazzo force-pushed the webdav-integration-removal branch from d155f77 to 9613065 Compare June 12, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@yasnagat @julio-rocketchat