From b43ac8440cf379cd18f518a980643c724e1aeec5 Mon Sep 17 00:00:00 2001 From: Dan Lavu Date: Wed, 10 Jun 2026 00:20:16 -0400 Subject: [PATCH] tests: updating pysss_nss_idmap error with more detail --- .../system/tests/test_pysss_nss_idmap.py | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/tests/system/tests/test_pysss_nss_idmap.py b/src/tests/system/tests/test_pysss_nss_idmap.py index eefb63f06b..68931b1457 100644 --- a/src/tests/system/tests/test_pysss_nss_idmap.py +++ b/src/tests/system/tests/test_pysss_nss_idmap.py @@ -101,7 +101,9 @@ def test_user_by_name(client: Client, provider: GenericProvider): }, f"'{user.name}' has wrong SID {user_sid}!" output = run_pysss_nss_idmap(client, "getsidbygroupname", user.name) - assert ast.literal_eval(output.stdout) == {}, f"'{user.name}' has wrong SID {user_sid}!" + assert ( + ast.literal_eval(output.stdout) == {} + ), f"Unexpectedly found SID for user '{user.name}' when queried as group: {output.stdout.strip()}" @pytest.mark.importance("critical") @@ -133,7 +135,9 @@ def test_user_by_id(client: Client, provider: GenericProvider): }, f"'{user.name}' has wrong SID {user_sid}!" output = run_pysss_nss_idmap(client, "getsidbygid", user_id) - assert ast.literal_eval(output.stdout) == {}, f"'{user.name}' has wrong SID {user_sid}!" + assert ( + ast.literal_eval(output.stdout) == {} + ), f"Unexpectedly found SID for user ID '{user_id}' when queried as GID: {output.stdout.strip()}" @pytest.mark.importance("critical") @@ -160,7 +164,7 @@ def test_user_by_sid(client: Client, provider: GenericProvider): output = run_pysss_nss_idmap(client, "getnamebysid", user_sid) assert ast.literal_eval(output.stdout) == { user_sid: {"name": user.name, "type": 1} - }, f"'{user.name}' has wrong name {user.name}!" + }, f"Expected name '{user.name}' but got: {output.stdout.strip()}" @pytest.mark.importance("critical") @@ -192,7 +196,9 @@ def test_group_by_name(client: Client, provider: GenericProvider): }, f"'{group.name}' has wrong SID {group_sid}!" output = run_pysss_nss_idmap(client, "getsidbyusername", group.name) - assert ast.literal_eval(output.stdout) == {}, f"'{group.name}' has wrong SID {group_sid}!" + assert ( + ast.literal_eval(output.stdout) == {} + ), f"Unexpectedly found SID for group '{group.name}' when queried as username: {output.stdout.strip()}" @pytest.mark.importance("critical") @@ -224,7 +230,9 @@ def test_group_by_id(client: Client, provider: GenericProvider): }, f"'{group.name}' has wrong SID {group_sid}!" output = run_pysss_nss_idmap(client, "getsidbyuid", group_id) - assert ast.literal_eval(output.stdout) == {}, f"'{group.name}' has wrong SID {group_sid}!" + assert ( + ast.literal_eval(output.stdout) == {} + ), f"Unexpectedly found SID for group ID '{group_id}' when queried as UID: {output.stdout.strip()}" @pytest.mark.importance("critical") @@ -381,9 +389,9 @@ def test_ignore_unreadable_references(client: Client, provider: GenericProvider) assert ast.literal_eval(output.stdout) == {}, f"'{group.name}' has wrong SID {group_sid}!" output = run_pysss_nss_idmap(client, "getidbysid", group_sid) - assert ast.literal_eval(output.stdout) == { - group_sid: {"id": group_id, "type": 2} - }, f"'{group.name}' has wrong ID {group_id}!" + assert ( + ast.literal_eval(output.stdout) == {} + ), f"Unexpectedly found SID for group ID '{group_id}' when queried as UID: {output.stdout.strip()}" output = run_pysss_nss_idmap(client, "getnamebysid", group_sid) assert ast.literal_eval(output.stdout) == {