Guard data preprocessor against empty preprocessing specs#629
Draft
kmontemayor2-sc wants to merge 1 commit intomainfrom
Draft
Guard data preprocessor against empty preprocessing specs#629kmontemayor2-sc wants to merge 1 commit intomainfrom
kmontemayor2-sc wants to merge 1 commit intomainfrom
Conversation
Clamp ThreadPoolExecutor max_workers to >=1 in the enumerator and short-circuit __preprocess_all_data_references when both node and edge spec dicts are empty, so an empty DataPreprocessorConfig no longer crashes with `max_workers must be greater than 0`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mkolodner-sc
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clamp ThreadPoolExecutor max_workers to >=1 in the enumerator and short-circuit __preprocess_all_data_references when both node and edge spec dicts are empty, so an empty DataPreprocessorConfig no longer crashes with
max_workers must be greater than 0.Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO