feat: CMD-187 autocreate search page - #1216
Draft
wesleyboar wants to merge 4 commits into
Draft
Conversation
## Overview Rebuilds the search feature on current `main` instead of stale `release/v4.36.X`. > [!WARNING] > First run on a fresh database will crash `manage.py migrate` itself, because `apps/search_page/apps.py`'s `ready()` hook queries `cms_page` before it exists. Workaround: set `SEARCH_PAGE_AUTO_SETUP = False`, migrate, then set it back to `True` and restart. [Details.](#885 (review)) > [!IMPORTANT] > Should instead: > - [Use a custom migration.](#885 (review)) > - (and/or) Create a [Core-CMS plugin](https://github.com/search?q=org%3ATACC+%22Core-CMS-Plugin%22&type=repositories) (from [TACC/Django-App](https://github.com/TACC/Django-App)). ## Related - replaces #1129 ## Changes - **rebuilt** branch from `main` + cherry-picked search-only commits - **dropped** unrelated inherited commits (favicons, breadcrumbs, image-zoom, etc.) ## Testing / UI See #1129.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
wesleyboar
marked this pull request as draft
July 27, 2026 21:46
wesleyboar
added
enhancement
## Overview Fixes gray background gaps on wide screens beside the search stats/sorting bar, and prevents that bar from shrinking the content width. ## Related - [WP-1313 comment's bug #1](https://tacc-main.atlassian.net/browse/WP-1313?focusedCommentId=40743) - required to later undo TACC/Core-CMS-Custom#553 ## Changes - **fixed** `.gsc-wrapper` / `.gsc-above-wrapper-area` shrinking content width by unsetting `max-width` - **fixed** fake background gaps on wide screens by using a full `box-shadow` spread with `clip-path` to contain overflow ## Testing 1. `make start` 2. Visit the search page at a wide viewport (e.g. 1920px) 3. Verify the gray background behind the stats/sorting row has no gaps and content width is unaffected ## UI | before | after | | - | - | | <img width="900" height="505" alt="before" src="https://github.com/user-attachments/assets/d0a29eec-c479-40c2-8b54-08d044b42e93" /> | <img width="900" height="505" alt="after" src="https://github.com/user-attachments/assets/6402b8d9-9844-4db4-b9ed-1c9b3aa2ee2a" /> |
## Overview Replaces the local Google search styles with a CDN `@import` back to Core-CMS-Custom, now that it holds the actual styles. ## Related - [TACC/Core-CMS-Custom#555](TACC/Core-CMS-Custom#555) ## Changes - **replaced** `apps/search_page/static/search_page/css/google-search.css` contents with a CDN `@import` ## Testing Skipped. ## UI No visual change — styles are byte-identical to before, just sourced via CDN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds an auto-generated Google Search page.
Important
Should instead use a custom migration. and/or install a new Core-CMS plugin (from TACC/Django-App) to do the heavy lifting.
Warning
(as of Jul 2026) First run on a fresh database will crash
manage.py migrateitself, becauseapps/search_page/apps.py'sready()hook queriescms_pagebefore it exists. Workaround: setSEARCH_PAGE_AUTO_SETUP = False, migrate, then set it back toTrueand restart.Related
Changes
search_pageappSEARCH_PAGE_AUTO_SETUPsettingGOOGLE_SEARCH_ENGINE_IDsettingTesting / UI
See #1129.