Skip to content

add email configuration docs - #1682

Merged
phycodurus merged 9 commits into
1416-add-support-for-mfa-for-tom-user-loginsfrom
1681-document-email-configuration
Sep 24, 2026
Merged

phycodurus merged 9 commits into
1416-add-support-for-mfa-for-tom-user-loginsfrom
1681-document-email-configuration

Conversation

@phycodurus

Copy link
Copy Markdown
Member

Adds email configuration docs. This was factored out of the MFA PR and ideally will merge into dev first.

closes #1681

The build upon tom_registrations README.md
@phycodurus phycodurus linked an issue Sep 21, 2026 that may be closed by this pull request
@phycodurus phycodurus moved this to Needs Review in TOM Toolkit Sep 21, 2026
@jchate6
jchate6 changed the base branch from dev to 1416-add-support-for-mfa-for-tom-user-logins September 21, 2026 21:16
@phycodurus phycodurus changed the title add email configurtion docs add email configuration docs Sep 21, 2026
@jchate6
jchate6 added this pull request to stack #1683 September 21, 2026 21:33

@jchate6 jchate6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some things could be better.

Comment thread docs/common/email_configuration.rst Outdated
Comment thread docs/common/email_configuration.rst
Comment thread docs/common/email_configuration.rst Outdated
Comment thread docs/common/email_configuration.rst Outdated
Comment thread docs/common/email_configuration.rst Outdated
Comment thread docs/common/email_configuration.rst
Comment thread docs/common/email_configuration.rst Outdated
Comment thread docs/common/email_configuration.rst
Comment thread docs/common/email_configuration.rst Outdated
Comment thread docs/common/email_configuration.rst
@phycodurus
phycodurus requested a review from jchate6 September 23, 2026 23:12

@jchate6 jchate6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like you have generally ignored my more important comments about readability, especially where long bullet points are concerned.

I really don't think multi-line bullets should be included in documentation like this. They undermine the utility of bullets by not allowing users to skim short brief points of information to see what's relevant to them, and they are more difficult to read than complete sentences with surrounding context. That being said, I've made that opinion clear, and they are you're docs.

@phycodurus
phycodurus merged commit 16de137 into dev Sep 24, 2026
27 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Merged (to dev) in TOM Toolkit Sep 24, 2026
@phycodurus
phycodurus deleted the 1681-document-email-configuration branch September 24, 2026 20:30
@jchate6 jchate6 moved this from Merged (to dev) to Released in TOM Toolkit Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

document-email-configuration

2 participants