query.test.ts

import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { QueryClient, hashKey } from '@tanstack/query-core'
import {
  BTreeIndex,
  createCollection,
  createLiveQueryCollection,
  eq,
  ilike,
  inArray,
  or,
} from '@tanstack/db'
import { stripVirtualProps } from '../../db/tests/utils'
import { persistedCollectionOptions } from '../../db-sqlite-persistence-core/src'
import { queryCollectionOptions } from '../src/query'
import type { QueryFunctionContext } from '@tanstack/query-core'
import type {
  Collection,
  DeleteMutationFnParams,
  InsertMutationFnParams,
  SyncMetadataApi,
  TransactionWithMutations,
  UpdateMutationFnParams,
} from '@tanstack/db'
import type { QueryCollectionConfig, QueryCollectionUtils } from '../src/query'

interface TestItem {
  id: string
  name: string
  value?: number
}

interface CategorisedItem {
  id: string
  name: string
  category: string
}

const getKey = (item: TestItem) => item.id

// Helper to advance timers and allow microtasks to flush
const flushPromises = () => new Promise((resolve) => setTimeout(resolve, 0))

function createInMemorySyncMetadataApi<
  TKey extends string | number = string | number,
  TItem extends object = Record<string, unknown>,
>(seed?: {
  rowMetadata?: ReadonlyMap<TKey, unknown>
  collectionMetadata?: ReadonlyMap<string, unknown>
  persistedRows?: ReadonlyMap<TKey, TItem>
}): {
  api: SyncMetadataApi<TKey>
  rowMetadata: Map<TKey, unknown>
  collectionMetadata: Map<string, unknown>
  persistedRows: Map<TKey, TItem>
} {
  const rowMetadata = new Map(seed?.rowMetadata)
  const collectionMetadata = new Map(seed?.collectionMetadata)
  const persistedRows = new Map(seed?.persistedRows)
  const api = {
    row: {
      get: (key: TKey) => rowMetadata.get(key),
      set: (key: TKey, value: unknown) => {
        rowMetadata.set(key, value)
      },
      delete: (key: TKey) => {
        rowMetadata.delete(key)
      },
      scanPersisted: async () =>
        Array.from(persistedRows.entries()).map(([key, value]) => ({
          key,
          value,
          metadata: rowMetadata.get(key),
        })),
    },
    collection: {
      get: (key: string) => collectionMetadata.get(key),
      set: (key: string, value: unknown) => {
        collectionMetadata.set(key, value)
      },
      delete: (key: string) => {
        collectionMetadata.delete(key)
      },
      list: (prefix?: string) =>
        Array.from(collectionMetadata.entries())
          .filter(([key]) => (prefix ? key.startsWith(prefix) : true))
          .map(([key, value]) => ({ key, value })),
    },
  }

  return {
    rowMetadata,
    collectionMetadata,
    persistedRows,
    api: api as SyncMetadataApi<TKey>,
  }
}

function createPersistedQueryAdapter<TItem extends { id: string }>(
  seed: {
    rows?: ReadonlyMap<string, TItem>
    rowMetadata?: ReadonlyMap<string, unknown>
    collectionMetadata?: ReadonlyMap<string, unknown>
  } = {},
) {
  const rows = new Map(seed.rows)
  const rowMetadata = new Map(seed.rowMetadata)
  const collectionMetadata = new Map(seed.collectionMetadata)

  return {
    rows,
    rowMetadata,
    collectionMetadata,
    loadSubset: async () =>
      Array.from(rows.values()).map((value) => ({
        key: value.id,
        value,
        metadata: rowMetadata.get(value.id),
      })),
    loadCollectionMetadata: async () =>
      Array.from(collectionMetadata.entries()).map(([key, value]) => ({
        key,
        value,
      })),
    scanRows: async () =>
      Array.from(rows.values()).map((value) => ({
        key: value.id,
        value,
        metadata: rowMetadata.get(value.id),
      })),
    applyCommittedTx: async (_collectionId: string, tx: any) => {
      if (tx.truncate) {
        rows.clear()
        rowMetadata.clear()
      }
      for (const mutation of tx.mutations) {
        if (mutation.type === `delete`) {
          rows.delete(mutation.key)
          rowMetadata.delete(mutation.key)
        } else {
          rows.set(mutation.key, mutation.value)
        }
      }
      for (const mutation of tx.rowMetadataMutations ?? []) {
        if (mutation.type === `delete`) {
          rowMetadata.delete(mutation.key)
        } else {
          rowMetadata.set(mutation.key, mutation.value)
        }
      }
      for (const mutation of tx.collectionMetadataMutations ?? []) {
        if (mutation.type === `delete`) {
          collectionMetadata.delete(mutation.key)
        } else {
          collectionMetadata.set(mutation.key, mutation.value)
        }
      }
    },
    ensureIndex: async () => {},
  }
}

describe(`QueryCollection`, () => {
  let queryClient: QueryClient

  beforeEach(() => {
    queryClient = new QueryClient({
      defaultOptions: {
        queries: {
          // Setting a low staleTime and gcTime to ensure queries can be refetched easily in tests
          // and GC'd quickly if not observed.
          staleTime: 0,
          gcTime: 0, // Immediate GC for tests
          retry: false, // Disable retries for tests to avoid delays
        },
      },
    })
  })

  afterEach(() => {
    // Ensure all queries are properly cleaned up after each test
    queryClient.clear()
  })

  it(`should initialize and fetch initial data`, async () => {
    const queryKey = [`testItems`]
    const initialItems: Array<TestItem> = [
      { id: `1`, name: `Item 1` },
      { id: `2`, name: `Item 2` },
    ]

    const queryFn = vi.fn().mockResolvedValue(initialItems)

    const config: QueryCollectionConfig<TestItem> = {
      id: `test`,
      queryClient,
      queryKey,
      queryFn,
      getKey,
      startSync: true,
    }

    const options = queryCollectionOptions(config)
    const collection = createCollection(options)

    // Wait for the query to complete and collection to update
    await vi.waitFor(
      () => {
        expect(queryFn).toHaveBeenCalledTimes(1)
        expect(collection.size).toBeGreaterThan(0)
      },
      {
        timeout: 1000, // Give it a reasonable timeout
        interval: 50, // Check frequently
      },
    )

    // Additional wait for internal processing if necessary
    await flushPromises()

    // Verify the collection state contains our items
    expect(collection.size).toBe(initialItems.length)
    expect(stripVirtualProps(collection.get(`1`))).toEqual(initialItems[0])
    expect(stripVirtualProps(collection.get(`2`))).toEqual(initialItems[1])

    // Verify the synced data
    expect(collection._state.syncedData.size).toBe(initialItems.length)
    expect(collection._state.syncedData.get(`1`)).toEqual(initialItems[0])
    expect(collection._state.syncedData.get(`2`)).toEqual(initialItems[1])
  })

  it(`should update collection when query data changes`, async () => {
    const queryKey = [`testItems`]
    const initialItems: Array<TestItem> = [
      { id: `1`, name: `Item 1` },
      { id: `2`, name: `Item 2` },
    ]

    // We'll use this to control what the queryFn returns in each call
    let currentItems = [...initialItems]

    const queryFn = vi
      .fn()
      .mockImplementation(() => Promise.resolve(currentItems))

    const config: QueryCollectionConfig<TestItem> = {
      id: `test`,
      queryClient,
      queryKey,
      queryFn,
      getKey,
      startSync: true,
    }

    const options = queryCollectionOptions(config)
    const collection = createCollection(options)

    // Wait for initial data to load
    await vi.waitFor(() => {
      expect(queryFn).toHaveBeenCalledTimes(1)
      expect(collection.size).toBeGreaterThan(0)
    })

    // Verify initial state
    expect(collection.size).toBe(initialItems.length)
    expect(stripVirtualProps(collection.get(`1`))).toEqual(initialItems[0])
    expect(stripVirtualProps(collection.get(`2`))).toEqual(initialItems[1])

    // Now update the data that will be returned by queryFn
    // 1. Modify an existing item
    // 2. Add a new item
    // 3. Remove an existing item
    const updatedItem = { id: `1`, name: `Item 1 Updated` }
    const newItem = { id: `3`, name: `Item 3` }
    currentItems = [
      updatedItem, // Modified
      newItem, // Added
      // Item 2 removed
    ]

    // Refetch the query.
    await collection.utils.refetch()

    expect(queryFn).toHaveBeenCalledTimes(2)
    // Check for update, addition, and removal
    expect(collection.size).toBe(2)
    expect(collection.has(`1`)).toBe(true)
    expect(collection.has(`3`)).toBe(true)
    expect(collection.has(`2`)).toBe(false)

    // Verify the final state more thoroughly
    expect(stripVirtualProps(collection.get(`1`))).toEqual(updatedItem)
    expect(stripVirtualProps(collection.get(`3`))).toEqual(newItem)
    expect(stripVirtualProps(collection.get(`2`))).toBeUndefined()

    // Now update the data again.
    const item4 = { id: `4`, name: `Item 4` }
    currentItems = [...currentItems, item4]

    // Refetch the query to trigger a refetch.
    await collection.utils.refetch()

    // Verify expected.
    expect(queryFn).toHaveBeenCalledTimes(3)
    expect(collection.size).toBe(3)
    expect(stripVirtualProps(collection.get(`4`))).toEqual(item4)
  })

  it(`should handle query errors gracefully`, async () => {
    const queryKey = [`errorItems`]
    const testError = new Error(`Test query error`)
    const initialItem = { id: `1`, name: `Initial Item` }

    // Mock console.error to verify it's called with our error
    const consoleErrorSpy = vi
      .spyOn(console, `error`)
      .mockImplementation(() => {})

    const queryFn: (
      context: QueryFunctionContext<any>,
    ) => Promise<Array<TestItem>> = vi
      .fn()
      .mockResolvedValueOnce([initialItem])
      .mockRejectedValueOnce(testError)

    const options = queryCollectionOptions({
      id: `test`,
      queryClient,
      queryKey,
      queryFn,
      getKey,
      startSync: true,
      retry: 0, // Disable retries for this test case
    })
    const collection = createCollection(options)

    // Wait for initial data to load
    await vi.waitFor(() => {
      expect(queryFn).toHaveBeenCalledTimes(1)
      expect(collection.size).toBe(1)
      expect(stripVirtualProps(collection.get(`1`))).toEqual(initialItem)
    })

    // Trigger an error by refetching
    await collection.utils.refetch()

    // Wait for the error to be logged
    expect(queryFn).toHaveBeenCalledTimes(2)
    expect(consoleErrorSpy).toHaveBeenCalled()

    // Verify the error was logged correctly
    const errorCallArgs = consoleErrorSpy.mock.calls.find((call) =>
      call[0].includes(`[QueryCollection] Error observing query`),
    )
    expect(errorCallArgs).toBeDefined()
    expect(errorCallArgs?.[1]).toBe(testError)

    // The collection should maintain its previous state
    expect(collection.size).toBe(1)
    expect(stripVirtualProps(collection.get(`1`))).toEqual(initialItem)

    // Clean up the spy
    consoleErrorSpy.mockRestore()
  })

  it(`should validate that queryFn returns an array of objects`, async () => {
    const queryKey = [`invalidData`]
    const consoleErrorSpy = vi
      .spyOn(console, `error`)
      .mockImplementation(() => {})

    // Mock queryFn to return invalid data (not an array of objects)
    const queryFn: (
      context: QueryFunctionContext<any>,
    ) => Promise<Array<TestItem>> = vi
      .fn()
      .mockResolvedValue(`not an array` as any)

    const options = queryCollectionOptions({
      id: `test`,
      queryClient,
      queryKey,
      queryFn,
      getKey,
      startSync: true,
    })
    const collection = createCollection(options)

    // Wait for the query to execute
    await vi.waitFor(() => {
      expect(queryFn).toHaveBeenCalledTimes(1)
    })

    // Verify the validation error was logged
    await vi.waitFor(() => {
      const errorCallArgs = consoleErrorSpy.mock.calls.find((call) =>
        call[0].includes(
          `@tanstack/query-db-collection: queryFn must return an array of objects`,
        ),
      )
      expect(errorCallArgs).toBeDefined()
    })

    // The collection state should remain empty or unchanged
    expect(collection.size).toBe(0)

    // Clean up the spy
    consoleErrorSpy.mockRestore()
  })

  it(`should use shallow equality to avoid unnecessary updates`, async () => {
    const queryKey = [`shallowEqualityTest`]
    const initialItem = { id: `1`, name: `Test Item`, count: 42 }

    // First query returns the initial item
    // Second query returns a new object with the same properties (different reference)
    // Third query returns an object with an actual change
    const queryFn: (
      context: QueryFunctionContext<any>,
    ) => Promise<Array<TestItem>> = vi
      .fn()
      .mockResolvedValueOnce([initialItem])
      .mockResolvedValueOnce([{ ...initialItem }]) // Same data, different object reference
      .mockResolvedValueOnce([{ ...initialItem, count: 43 }]) // Actually changed data

    // Spy on console.log to detect when commits happen
    const consoleSpy = vi.spyOn(console, `log`)

    const options = queryCollectionOptions({
      id: `test`,
      queryClient,
      queryKey,
      queryFn,
      getKey,
      startSync: true,
    })
    const collection = createCollection(options)

    // Wait for initial data to load
    await vi.waitFor(() => {
      expect(queryFn).toHaveBeenCalledTimes(1)
      expect(collection.size).toBe(1)
      expect(stripVirtualProps(collection.get(`1`))).toEqual(initialItem)
    })

    // Store the initial state object reference to check if it changes
    const initialStateRef = collection.get(`1`)
    consoleSpy.mockClear()

    // Trigger first refetch - should not cause an update due to shallow equality
    await collection.utils.refetch()

    expect(queryFn).toHaveBeenCalledTimes(2)

    // Since the data is identical (though a different object reference),
    // the state object reference should remain the same due to shallow equality
    expect(collection.get(`1`)).toBe(initialStateRef) // Same reference

    consoleSpy.mockClear()

    // Trigger second refetch - should cause an update due to actual data change
    await collection.utils.refetch()

    expect(queryFn).toHaveBeenCalledTimes(3)

    // Now the state should be updated with the new value
    const updatedItem = collection.get(`1`)
    expect(updatedItem).not.toBe(initialStateRef) // Different reference
    expect(stripVirtualProps(updatedItem)).toEqual({
      id: `1`,
      name: `Test Item`,
      count: 43,
    }) // Updated value

    consoleSpy.mockRestore()
  })

  it(`should use the provided getKey function to identify items`, async () => {
    const queryKey = [`customKeyTest`]

    // Items with a non-standard ID field
    const items = [
      { customId: `item1`, name: `First Item` },
      { customId: `item2`, name: `Second Item` },
    ]

    const queryFn = vi.fn().mockResolvedValue(items)

    // Create a spy for the getKey function
    const getKeySpy = vi.fn((item: any) => item.customId)

    const options = queryCollectionOptions({
      id: `test`,
      queryClient,
      queryKey,
      queryFn,
      getKey: getKeySpy,
      startSync: true,
    })
    const collection = createCollection(options)

    // Wait for initial data to load
    await vi.waitFor(() => {
      expect(queryFn).toHaveBeenCalledTimes(1)
      expect(collection.size).toBe(items.length)
    })

    // Verify getKey was called for each item
    expect(getKeySpy).toHaveBeenCalledTimes(items.length * 2)
    items.forEach((item) => {
      expect(getKeySpy).toHaveBeenCalledWith(item)
    })

    // Verify items are stored with the custom keys
    expect(collection.has(`item1`)).toBe(true)
    expect(collection.has(`item2`)).toBe(true)
    expect(stripVirtualProps(collection.get(`item1`))).toEqual(items[0])
    expect(stripVirtualProps(collection.get(`item2`))).toEqual(items[1])

    // Now update an item and add a new one
    const updatedItems = [
      { customId: `item1`, name: `Updated First Item` }, // Updated
      { customId: `item3`, name: `Third Item` }, // New
      // item2 removed
    ]

    // Reset the spy to track new calls
    getKeySpy.mockClear()
    queryFn.mockResolvedValueOnce(updatedItems)

    // Trigger a refetch
    await collection.utils.refetch()

    expect(queryFn).toHaveBeenCalledTimes(2)
    expect(collection.size).toBe(updatedItems.length)

    // Verify getKey was called at least once for each item
    // It may be called multiple times per item during the diffing process
    expect(getKeySpy).toHaveBeenCalled()
    updatedItems.forEach((item) => {
      expect(getKeySpy).toHaveBeenCalledWith(item)
    })

    // Verify the state reflects the changes
    expect(collection.has(`item1`)).toBe(true)
    expect(collection.has(`item2`)).toBe(false) // Removed
    expect(collection.has(`item3`)).toBe(true) // Added
    expect(stripVirtualProps(collection.get(`item1`))).toEqual(updatedItems[0])
    expect(stripVirtualProps(collection.get(`item3`))).toEqual(updatedItems[1])
  })

  it(`should pass meta property to queryFn context`, async () => {
    const queryKey = [`metaTest`]
    const meta = { errorMessage: `Failed to load items` }
    const queryFn = vi.fn().mockResolvedValueOnce([])

    const config: QueryCollectionConfig<TestItem> = {
      id: `test`,
      queryClient,
      queryKey,
      queryFn,
      getKey,
      meta,
      startSync: true,
    }

    const options = queryCollectionOptions(config)
    createCollection(options)

    // Wait for query to execute
    await vi.waitFor(() => {
      expect(queryFn).toHaveBeenCalledTimes(1)
    })

    // Verify queryFn was called with the correct context, including the meta object
    expect(queryFn).toHaveBeenCalledWith(
      expect.objectContaining({ meta: { ...meta, loadSubsetOptions: {} } }),
    )
  })

  describe(`loadSubsetOptions passed to queryFn`, () => {
    it(`should pass eq where clause to queryFn via loadSubsetOptions`, async () => {
      const queryKey = [`loadSubsetTest`]
      const queryFn = vi
        .fn()
        .mockImplementation((ctx: QueryFunctionContext<any>) => {
          const loadSubsetOptions = ctx.meta?.loadSubsetOptions
          // Verify where clause is present
          expect(loadSubsetOptions?.where).toBeDefined()
          expect(loadSubsetOptions?.where).not.toBeNull()
          if (loadSubsetOptions?.where?.type === `func`) {
            expect(loadSubsetOptions.where.name).toBe(`eq`)
          }
          return Promise.resolve([])
        })

      const config: QueryCollectionConfig<TestItem> = {
        id: `loadSubsetTest`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        syncMode: `on-demand`,
        // startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Create a live query with an eq where clause
      const liveQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.id, `1`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      await liveQuery.preload()

      // Wait for queryFn to be called
      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalled()
      })

      // Verify queryFn was called with loadSubsetOptions containing the where clause
      expect(queryFn).toHaveBeenCalledWith(
        expect.objectContaining({
          meta: expect.objectContaining({
            loadSubsetOptions: expect.objectContaining({
              where: expect.objectContaining({
                type: `func`,
                name: `eq`,
              }),
            }),
          }),
        }),
      )
    })

    it(`should pass ilike where clause to queryFn via loadSubsetOptions`, async () => {
      const queryFn = vi
        .fn()
        .mockImplementation((ctx: QueryFunctionContext<any>) => {
          const loadSubsetOptions = ctx.meta?.loadSubsetOptions
          // Verify where clause is present (this was the bug - it was undefined/null before the fix)
          expect(loadSubsetOptions?.where).toBeDefined()
          expect(loadSubsetOptions?.where).not.toBeNull()
          if (loadSubsetOptions?.where?.type === `func`) {
            expect(loadSubsetOptions.where.name).toBe(`ilike`)
          }
          return Promise.resolve([])
        })

      const config: QueryCollectionConfig<TestItem> = {
        id: `loadSubsetIlikeTest`,
        queryClient,
        queryKey: [`loadSubsetIlikeTest`],
        queryFn,
        getKey,
        syncMode: `on-demand`,
        // startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Create a live query with an ilike where clause
      const liveQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => ilike(item.name, `%test%`))
            .orderBy(({ item }) => item.name)
            .limit(10),
      })

      await liveQuery.preload()

      // Wait for queryFn to be called
      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalled()
      })

      // Verify queryFn was called with loadSubsetOptions containing the ilike where clause
      // Without the fix: where would be undefined/null
      // With the fix: where should be defined with the ilike expression
      expect(queryFn).toHaveBeenCalledWith(
        expect.objectContaining({
          meta: expect.objectContaining({
            loadSubsetOptions: expect.objectContaining({
              where: expect.objectContaining({
                type: `func`,
                name: `ilike`,
              }),
            }),
          }),
        }),
      )
    })
  })

  describe(`Select method testing`, () => {
    type MetaDataType<T> = {
      metaDataOne: string
      metaDataTwo: string
      data: Array<T>
    }

    const initialMetaData: MetaDataType<TestItem> = {
      metaDataOne: `example metadata`,
      metaDataTwo: `example metadata`,
      data: [
        {
          id: `1`,
          name: `First Item`,
        },
        {
          id: `2`,
          name: `Second Item`,
        },
      ],
    }

    it(`Select extracts array from metadata`, async () => {
      const queryKey = [`select-test`]

      const queryFn = vi.fn().mockResolvedValue(initialMetaData)
      const select = vi.fn().mockReturnValue(initialMetaData.data)

      const options = queryCollectionOptions({
        id: `test`,
        queryClient,
        queryKey,
        queryFn,
        select,
        getKey,
        startSync: true,
      })
      const collection = createCollection(options)

      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalledTimes(1)
        expect(select).toHaveBeenCalledTimes(1)
        expect(collection.size).toBeGreaterThan(0)
      })

      expect(collection.size).toBe(initialMetaData.data.length)
      expect(stripVirtualProps(collection.get(`1`))).toEqual(
        initialMetaData.data[0],
      )
      expect(stripVirtualProps(collection.get(`2`))).toEqual(
        initialMetaData.data[1],
      )
    })

    it(`Throws error if select returns non array`, async () => {
      const queryKey = [`select-test`]
      const consoleErrorSpy = vi
        .spyOn(console, `error`)
        .mockImplementation(() => {})

      const queryFn = vi.fn().mockResolvedValue(initialMetaData)
      // Returns non-array
      const select = vi.fn().mockReturnValue(initialMetaData)

      const options = queryCollectionOptions({
        id: `test`,
        queryClient,
        queryKey,
        queryFn,
        select,
        getKey,
        startSync: true,
      })
      const collection = createCollection(options)

      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalledTimes(1)
        expect(select).toHaveBeenCalledTimes(1)
      })

      // Verify the validation error was logged
      await vi.waitFor(() => {
        const errorCallArgs = consoleErrorSpy.mock.calls.find((call) =>
          call[0].includes(
            `@tanstack/query-db-collection: select() must return an array of objects`,
          ),
        )
        expect(errorCallArgs).toBeDefined()
      })

      expect(collection.size).toBe(0)

      // Clean up the spy
      consoleErrorSpy.mockRestore()
    })

    it(`Whole response is cached in QueryClient when used with select option`, async () => {
      const queryKey = [`select-test`]

      const queryFn = vi.fn().mockResolvedValue(initialMetaData)
      const select = vi.fn().mockReturnValue(initialMetaData.data)

      const options = queryCollectionOptions({
        id: `test`,
        queryClient,
        queryKey,
        queryFn,
        select,
        getKey,
        startSync: true,
      })
      const collection = createCollection(options)

      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalledTimes(1)
        expect(select).toHaveBeenCalledTimes(1)
        expect(collection.size).toBe(2)
      })

      // Verify that the query cache state exists along with its metadata
      const initialCache = queryClient.getQueryData(
        queryKey,
      ) as MetaDataType<TestItem>
      expect(initialCache).toEqual(initialMetaData)
    })

    it(`should not throw error when using writeInsert with select option`, async () => {
      const queryKey = [`select-writeInsert-test`]
      const consoleErrorSpy = vi
        .spyOn(console, `error`)
        .mockImplementation(() => {})

      const queryFn = vi.fn().mockResolvedValue(initialMetaData)
      const select = vi.fn((data: MetaDataType<TestItem>) => data.data)

      const options = queryCollectionOptions({
        id: `select-writeInsert-test`,
        queryClient,
        queryKey,
        queryFn,
        select,
        getKey,
        startSync: true,
      })
      const collection = createCollection(options)

      // Wait for collection to be ready
      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
        expect(collection.size).toBe(2)
      })

      // This should NOT cause an error - but with the bug it does
      const newItem: TestItem = { id: `3`, name: `New Item` }
      collection.utils.writeInsert(newItem)

      // Verify the item was inserted
      expect(collection.size).toBe(3)
      expect(stripVirtualProps(collection.get(`3`))).toEqual(newItem)

      // Wait a tick to allow any async error handlers to run
      await flushPromises()

      // Verify no error was logged about select returning non-array
      const errorCallArgs = consoleErrorSpy.mock.calls.find((call) =>
        call[0]?.includes?.(
          `@tanstack/query-db-collection: select() must return an array of objects`,
        ),
      )
      expect(errorCallArgs).toBeUndefined()

      consoleErrorSpy.mockRestore()
    })

    it(`should not throw error when using writeUpsert with select option`, async () => {
      const queryKey = [`select-writeUpsert-test`]
      const consoleErrorSpy = vi
        .spyOn(console, `error`)
        .mockImplementation(() => {})

      const queryFn = vi.fn().mockResolvedValue(initialMetaData)
      const select = vi.fn((data: MetaDataType<TestItem>) => data.data)

      const options = queryCollectionOptions({
        id: `select-writeUpsert-test`,
        queryClient,
        queryKey,
        queryFn,
        select,
        getKey,
        startSync: true,
      })
      const collection = createCollection(options)

      // Wait for collection to be ready
      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
        expect(collection.size).toBe(2)
      })

      // This should NOT cause an error - but with the bug it does
      // Test upsert for new item
      const newItem: TestItem = { id: `3`, name: `Upserted New Item` }
      collection.utils.writeUpsert(newItem)

      // Verify the item was inserted
      expect(collection.size).toBe(3)
      expect(stripVirtualProps(collection.get(`3`))).toEqual(newItem)

      // Test upsert for existing item
      collection.utils.writeUpsert({ id: `1`, name: `Updated First Item` })

      // Verify the item was updated
      expect(collection.get(`1`)?.name).toBe(`Updated First Item`)

      // Wait a tick to allow any async error handlers to run
      await flushPromises()

      // Verify no error was logged about select returning non-array
      const errorCallArgs = consoleErrorSpy.mock.calls.find((call) =>
        call[0]?.includes?.(
          `@tanstack/query-db-collection: select() must return an array of objects`,
        ),
      )
      expect(errorCallArgs).toBeUndefined()

      consoleErrorSpy.mockRestore()
    })

    it(`should update query cache with wrapped format preserved when using writeInsert with select option`, async () => {
      const queryKey = [`select-cache-update-test`]

      const queryFn = vi.fn().mockResolvedValue(initialMetaData)
      const select = vi.fn((data: MetaDataType<TestItem>) => data.data)

      const options = queryCollectionOptions({
        id: `select-cache-update-test`,
        queryClient,
        queryKey,
        queryFn,
        select,
        getKey,
        startSync: true,
      })
      const collection = createCollection(options)

      // Wait for collection to be ready
      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
        expect(collection.size).toBe(2)
      })

      // Verify initial cache has wrapped format
      const initialCache = queryClient.getQueryData(
        queryKey,
      ) as MetaDataType<TestItem>
      expect(initialCache.metaDataOne).toBe(`example metadata`)
      expect(initialCache.metaDataTwo).toBe(`example metadata`)
      expect(initialCache.data).toHaveLength(2)

      // Insert a new item
      const newItem: TestItem = { id: `3`, name: `New Item` }
      collection.utils.writeInsert(newItem)

      // Verify the cache still has wrapped format with metadata preserved
      const cacheAfterInsert = queryClient.getQueryData(
        queryKey,
      ) as MetaDataType<TestItem>
      expect(cacheAfterInsert.metaDataOne).toBe(`example metadata`)
      expect(cacheAfterInsert.metaDataTwo).toBe(`example metadata`)
      expect(cacheAfterInsert.data).toHaveLength(3)
      expect(cacheAfterInsert.data).toContainEqual(newItem)

      // Update an existing item
      collection.utils.writeUpdate({ id: `1`, name: `Updated First Item` })

      // Verify the cache still has wrapped format
      const cacheAfterUpdate = queryClient.getQueryData(
        queryKey,
      ) as MetaDataType<TestItem>
      expect(cacheAfterUpdate.metaDataOne).toBe(`example metadata`)
      expect(cacheAfterUpdate.data).toHaveLength(3)
      const updatedItem = cacheAfterUpdate.data.find((item) => item.id === `1`)
      expect(updatedItem?.name).toBe(`Updated First Item`)

      // Delete an item
      collection.utils.writeDelete(`2`)

      // Verify the cache still has wrapped format
      const cacheAfterDelete = queryClient.getQueryData(
        queryKey,
      ) as MetaDataType<TestItem>
      expect(cacheAfterDelete.metaDataOne).toBe(`example metadata`)
      expect(cacheAfterDelete.data).toHaveLength(2)
      expect(cacheAfterDelete.data).not.toContainEqual(
        expect.objectContaining({ id: `2` }),
      )
    })
  })
  describe(`Direct persistence handlers`, () => {
    it(`should pass through direct persistence handlers to collection options`, () => {
      const queryKey = [`directPersistenceTest`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      // Create mock handlers
      const onInsert = vi.fn().mockResolvedValue(undefined)
      const onUpdate = vi.fn().mockResolvedValue(undefined)
      const onDelete = vi.fn().mockResolvedValue(undefined)

      const config: QueryCollectionConfig<TestItem> = {
        id: `test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        onInsert,
        onUpdate,
        onDelete,
      }

      const options = queryCollectionOptions(config)

      // Verify that the handlers were passed to the collection options
      expect(options.onInsert).toBeDefined()
      expect(options.onUpdate).toBeDefined()
      expect(options.onDelete).toBeDefined()
    })

    it(`should wrap handlers and call the original handler`, async () => {
      const queryKey = [`handlerTest`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      // Create mock transactions for testing with proper types
      const insertTransaction = {
        id: `test-transaction-insert`,
        mutations: [] as any,
      } as TransactionWithMutations<TestItem, `insert`>

      const updateTransaction = {
        id: `test-transaction-update`,
        mutations: [] as any,
      } as TransactionWithMutations<TestItem, `update`>

      const deleteTransaction = {
        id: `test-transaction-delete`,
        mutations: [] as any,
      } as TransactionWithMutations<TestItem, `delete`>

      const mockCollection = {
        utils: {} as QueryCollectionUtils<
          TestItem,
          string | number,
          TestItem,
          unknown
        >,
      } as unknown as Collection<
        TestItem,
        string | number,
        QueryCollectionUtils<TestItem, string | number, TestItem, unknown>,
        never,
        TestItem
      >

      const insertMockParams = {
        transaction: insertTransaction,
        collection: mockCollection,
      } as InsertMutationFnParams<
        TestItem,
        string | number,
        QueryCollectionUtils<TestItem, string | number, TestItem, unknown>
      >
      const updateMockParams = {
        transaction: updateTransaction,
        collection: mockCollection,
      } as UpdateMutationFnParams<
        TestItem,
        string | number,
        QueryCollectionUtils<TestItem, string | number, TestItem, unknown>
      >
      const deleteMockParams = {
        transaction: deleteTransaction,
        collection: mockCollection,
      } as DeleteMutationFnParams<
        TestItem,
        string | number,
        QueryCollectionUtils<TestItem, string | number, TestItem, unknown>
      >

      // Create handlers
      const onInsert = vi.fn().mockResolvedValue(undefined)
      const onUpdate = vi.fn().mockResolvedValue(undefined)
      const onDelete = vi.fn().mockResolvedValue(undefined)

      const config: QueryCollectionConfig<TestItem> = {
        id: `test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        onInsert,
        onUpdate,
        onDelete,
      }

      const options = queryCollectionOptions(config)

      // Call the wrapped handlers
      await options.onInsert!(insertMockParams)
      await options.onUpdate!(updateMockParams)
      await options.onDelete!(deleteMockParams)

      // Verify the original handlers were called
      expect(onInsert).toHaveBeenCalledWith(insertMockParams)
      expect(onUpdate).toHaveBeenCalledWith(updateMockParams)
      expect(onDelete).toHaveBeenCalledWith(deleteMockParams)
    })

    it(`should call refetch based on handler return value`, async () => {
      // Create a mock transaction for testing with proper type
      const insertTransaction = {
        id: `test-transaction-insert`,
        mutations: [] as any,
      } as TransactionWithMutations<TestItem, `insert`>

      // Create handlers with different return values
      const onInsertDefault = vi.fn().mockResolvedValue(undefined) // Default behavior should refetch
      const onInsertFalse = vi.fn().mockResolvedValue({ refetch: false }) // No refetch

      // Create configs with the handlers
      const queryFnDefault = vi
        .fn()
        .mockResolvedValue([{ id: `1`, name: `Item 1` }])
      const queryFnFalse = vi
        .fn()
        .mockResolvedValue([{ id: `1`, name: `Item 1` }])

      const configDefault: QueryCollectionConfig<TestItem> = {
        id: `test-default`,
        queryClient,
        queryKey: [`refetchTest`, `default`],
        queryFn: queryFnDefault,
        getKey,
        onInsert: onInsertDefault,
        startSync: true,
      }

      const configFalse: QueryCollectionConfig<TestItem> = {
        id: `test-false`,
        queryClient,
        queryKey: [`refetchTest`, `false`],
        queryFn: queryFnFalse,
        getKey,
        onInsert: onInsertFalse,
        startSync: true,
      }

      // Test case 1: Default behavior (undefined return) should trigger refetch
      const optionsDefault = queryCollectionOptions(configDefault)
      const collectionDefault = createCollection(optionsDefault)

      // Wait for initial sync
      await vi.waitFor(() => {
        expect(collectionDefault.status).toBe(`ready`)
      })

      // Clear initial call
      queryFnDefault.mockClear()

      const insertParamsDefault = {
        transaction: insertTransaction,
        collection: collectionDefault,
      } satisfies InsertMutationFnParams<
        TestItem,
        string | number,
        QueryCollectionUtils<TestItem, string | number, TestItem, unknown>
      >

      await optionsDefault.onInsert!(insertParamsDefault)

      // Verify handler was called and refetch was triggered (queryFn called again)
      expect(onInsertDefault).toHaveBeenCalledWith(insertParamsDefault)
      await vi.waitFor(() => {
        expect(queryFnDefault).toHaveBeenCalledTimes(1)
      })

      // Test case 2: Explicit { refetch: false } should not trigger refetch
      const optionsFalse = queryCollectionOptions(configFalse)
      const collectionFalse = createCollection(optionsFalse)

      // Wait for initial sync
      await vi.waitFor(() => {
        expect(collectionFalse.status).toBe(`ready`)
      })

      // Clear initial call
      queryFnFalse.mockClear()

      const insertParamsFalse = {
        transaction: insertTransaction,
        collection: collectionFalse,
      } satisfies InsertMutationFnParams<
        TestItem,
        string | number,
        QueryCollectionUtils<TestItem, string | number, TestItem, unknown>
      >

      await optionsFalse.onInsert!(insertParamsFalse)

      // Verify handler was called but refetch was NOT triggered (queryFn not called)
      expect(onInsertFalse).toHaveBeenCalledWith(insertParamsFalse)
      // Wait a bit to ensure no refetch happens
      await new Promise((resolve) => setTimeout(resolve, 50))
      expect(queryFnFalse).not.toHaveBeenCalled()

      await Promise.all([
        collectionDefault.cleanup(),
        collectionFalse.cleanup(),
      ])
    })
  })

  // Tests for lifecycle management
  describe(`lifecycle management`, () => {
    it(`should properly cleanup query and collection when collection is cleaned up`, async () => {
      const queryKey = [`cleanup-test`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `cleanup-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for initial data to load
      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalledTimes(1)
        expect(collection.size).toBe(1)
      })

      // Cleanup the collection
      await collection.cleanup()

      // Verify collection status
      expect(collection.status).toBe(`cleaned-up`)

      // Note: Query cleanup happens during sync cleanup, not collection cleanup
      // We're mainly verifying the collection cleanup works without errors
    })

    it(`should call cancelQueries and removeQueries on sync cleanup`, async () => {
      const queryKey = [`sync-cleanup-test`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `sync-cleanup-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      // Spy on the queryClient methods that should be called during sync cleanup
      const cancelQueriesSpy = vi
        .spyOn(queryClient, `cancelQueries`)
        .mockResolvedValue()
      const removeQueriesSpy = vi.spyOn(queryClient, `removeQueries`)

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for initial data to load
      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalledTimes(1)
        expect(collection.size).toBe(1)
      })

      // Verify initial subscriber state - startSync=true, so even with no subscribers of the collection, there should
      // be an active subscription to the query
      expect(collection.subscriberCount).toBe(0)
      expect(collection.status).toBe(`ready`)

      // Add explicit subscribers to test cleanup with active subscribers
      const subscription1 = collection.subscribeChanges(() => {})
      const subscription2 = collection.subscribeChanges(() => {})
      expect(collection.subscriberCount).toBe(2)

      // Cleanup the collection which should trigger sync cleanup
      await collection.cleanup()

      // Wait a bit to ensure all async operations complete
      await flushPromises()

      // Verify collection status
      expect(collection.status).toBe(`cleaned-up`)

      // Verify that cleanup methods are called regardless of subscriber state
      expect(cancelQueriesSpy).toHaveBeenCalledWith({
        queryKey,
        exact: true,
      })
      expect(removeQueriesSpy).toHaveBeenCalledWith({ queryKey, exact: true })

      // Verify subscribers can be safely cleaned up after collection cleanup
      subscription1.unsubscribe()
      subscription2.unsubscribe()
      expect(collection.subscriberCount).toBe(0)

      // Restore spies
      cancelQueriesSpy.mockRestore()
      removeQueriesSpy.mockRestore()
    })

    it(`should handle multiple cleanup calls gracefully`, async () => {
      const queryKey = [`multiple-cleanup-test`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `multiple-cleanup-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for initial data
      await vi.waitFor(() => {
        expect(collection.size).toBe(1)
      })

      // Add subscribers to test consistency during multiple cleanups
      const subscription1 = collection.subscribeChanges(() => {})
      const subscription2 = collection.subscribeChanges(() => {})
      expect(collection.subscriberCount).toBe(2)

      // Call cleanup multiple times - subscriber count should remain consistent
      await collection.cleanup()
      expect(collection.status).toBe(`cleaned-up`)
      expect(collection.subscriberCount).toBe(2) // Subscribers still tracked

      await collection.cleanup()
      await collection.cleanup()

      // Should handle multiple cleanups gracefully with consistent subscriber state
      expect(collection.status).toBe(`cleaned-up`)
      expect(collection.subscriberCount).toBe(2) // Still consistent

      // Verify subscribers can be safely unsubscribed after multiple cleanups
      subscription1.unsubscribe()
      expect(collection.subscriberCount).toBe(1)
      subscription2.unsubscribe()
      expect(collection.subscriberCount).toBe(0)
    })

    it(`should restart sync when collection is accessed after cleanup`, async () => {
      const queryKey = [`restart-sync-test`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `restart-sync-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for initial data
      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalledTimes(1)
        expect(collection.size).toBe(1)
      })

      // Verify initial subscriber state
      expect(collection.subscriberCount).toBe(0) // startSync: true with no explicit subscribers

      // Add a subscriber before cleanup
      const preCleanupSubscription = collection.subscribeChanges(() => {})
      expect(collection.subscriberCount).toBe(1)

      // Cleanup - should handle active subscribers gracefully
      await collection.cleanup()
      expect(collection.status).toBe(`cleaned-up`)

      // Subscriber count should remain tracked even after cleanup
      expect(collection.subscriberCount).toBe(1)
      preCleanupSubscription.unsubscribe() // Clean up old subscriber
      expect(collection.subscriberCount).toBe(0)

      // Access collection data to restart sync with new subscriber
      const postCleanupSubscription = collection.subscribeChanges(() => {})
      expect(collection.subscriberCount).toBe(1) // Subscriber count tracking works after restart

      // Should restart sync (might be ready immediately if query is cached)
      expect([`loading`, `ready`]).toContain(collection.status)

      postCleanupSubscription.unsubscribe()
      expect(collection.subscriberCount).toBe(0)
    })

    it(`should handle query lifecycle during restart cycle`, async () => {
      const queryKey = [`restart-lifecycle-test`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `restart-lifecycle-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      // Spy on queryClient methods
      const cancelQueriesSpy = vi
        .spyOn(queryClient, `cancelQueries`)
        .mockResolvedValue()
      const removeQueriesSpy = vi.spyOn(queryClient, `removeQueries`)

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for initial data
      await vi.waitFor(() => {
        expect(collection.size).toBe(1)
      })

      // Cleanup which should call query cleanup methods
      await collection.cleanup()
      await flushPromises()
      expect(collection.status).toBe(`cleaned-up`)

      // Verify cleanup methods were called
      expect(cancelQueriesSpy).toHaveBeenCalledWith({
        queryKey,
        exact: true,
      })
      expect(removeQueriesSpy).toHaveBeenCalledWith({ queryKey, exact: true })

      // Clear the spies to track new calls
      cancelQueriesSpy.mockClear()
      removeQueriesSpy.mockClear()

      // Restart by accessing collection
      const subscription = collection.subscribeChanges(() => {})

      // Should restart sync
      expect([`loading`, `ready`]).toContain(collection.status)

      // Cleanup again to verify the new sync cleanup works
      subscription.unsubscribe()
      await collection.cleanup()
      await flushPromises()

      // Verify cleanup methods were called again for the restarted sync
      expect(cancelQueriesSpy).toHaveBeenCalledWith({
        queryKey,
        exact: true,
      })
      expect(removeQueriesSpy).toHaveBeenCalledWith({ queryKey, exact: true })

      // Restore spies
      cancelQueriesSpy.mockRestore()
      removeQueriesSpy.mockRestore()
    })

    it(`should handle query invalidation and refetch properly`, async () => {
      const queryKey = [`invalidation-test`]
      let items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockImplementation(() => Promise.resolve(items))

      const config: QueryCollectionConfig<TestItem> = {
        id: `invalidation-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for initial data
      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalledTimes(1)
        expect(collection.size).toBe(1)
      })

      // Update data for next fetch
      items = [
        { id: `1`, name: `Updated Item 1` },
        { id: `2`, name: `Item 2` },
      ]

      // Invalidate and refetch
      await queryClient.invalidateQueries({ queryKey })

      // Wait for refetch to complete
      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalledTimes(2)
        expect(collection.size).toBe(2)
      })

      expect(stripVirtualProps(collection.get(`1`))).toEqual({
        id: `1`,
        name: `Updated Item 1`,
      })
      expect(stripVirtualProps(collection.get(`2`))).toEqual({
        id: `2`,
        name: `Item 2`,
      })
    })

    it(`should handle concurrent query operations`, async () => {
      const queryKey = [`concurrent-test`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `concurrent-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for initial data
      await vi.waitFor(() => {
        expect(collection.size).toBe(1)
      })

      // Perform concurrent operations
      const promises = [
        collection.utils.refetch(),
        collection.utils.refetch(),
        collection.utils.refetch(),
      ]

      // All should complete without errors
      await Promise.all(promises)

      // Collection should remain in a consistent state
      expect(collection.size).toBe(1)
      expect(stripVirtualProps(collection.get(`1`))).toEqual({
        id: `1`,
        name: `Item 1`,
      })
    })

    it(`should handle query state transitions properly`, async () => {
      const queryKey = [`state-transition-test`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `state-transition-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Initially loading
      expect(collection.status).toBe(`loading`)

      // Wait for data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(1)
        expect(collection.status).toBe(`ready`)
      })

      // Trigger a refetch which should transition to loading and back to ready
      const refetchPromise = collection.utils.refetch()

      // Should transition back to ready after refetch
      await refetchPromise
      expect(collection.status).toBe(`ready`)
    })

    it(`should properly handle subscription lifecycle`, async () => {
      const queryKey = [`subscription-lifecycle-test`]
      let items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockImplementation(() => Promise.resolve(items))

      const config: QueryCollectionConfig<TestItem> = {
        id: `subscription-lifecycle-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for initial data
      await vi.waitFor(() => {
        expect(collection.size).toBe(1)
      })

      // Verify initial subscriber count - startSync=true means the query should be active
      expect(collection.subscriberCount).toBe(0)
      expect(collection.status).toBe(`ready`)

      // Create multiple subscriptions and track count changes
      const changeHandler1 = vi.fn()
      const changeHandler2 = vi.fn()

      const subscription1 = collection.subscribeChanges(changeHandler1)
      expect(collection.subscriberCount).toBe(1) // 0 → 1

      const subscription2 = collection.subscribeChanges(changeHandler2)
      expect(collection.subscriberCount).toBe(2) // 1 → 2

      // Change the data and trigger a refetch
      items = [{ id: `1`, name: `Item 1 Updated` }]
      await collection.utils.refetch()

      // Wait for changes to propagate
      await vi.waitFor(() => {
        expect(collection.get(`1`)?.name).toBe(`Item 1 Updated`)
      })

      // Both handlers should have been called
      expect(changeHandler1).toHaveBeenCalled()
      expect(changeHandler2).toHaveBeenCalled()

      // Unsubscribe one and verify count tracking
      subscription1.unsubscribe()
      expect(collection.subscriberCount).toBe(1) // 2 → 1

      changeHandler1.mockClear()
      changeHandler2.mockClear()

      // Change data again and trigger another refetch
      items = [{ id: `1`, name: `Item 1 Updated Again` }]
      await collection.utils.refetch()

      // Wait for changes to propagate
      await vi.waitFor(() => {
        expect(collection.get(`1`)?.name).toBe(`Item 1 Updated Again`)
      })

      // Only the second handler should be called
      expect(changeHandler1).not.toHaveBeenCalled()
      expect(changeHandler2).toHaveBeenCalled()

      // Final cleanup - verify query remains active due to startSync: true
      subscription2.unsubscribe()
      expect(collection.subscriberCount).toBe(0) // 1 → 0
      expect(collection.status).toBe(`ready`) // Still ready due to startSync: true
    })

    it(`should handle query cancellation gracefully`, async () => {
      const queryKey = [`cancellation-test`]
      let resolvePromise: (value: Array<TestItem>) => void
      const queryPromise = new Promise<Array<TestItem>>((resolve) => {
        resolvePromise = resolve
      })
      const queryFn = vi.fn().mockReturnValue(queryPromise)

      const config: QueryCollectionConfig<TestItem> = {
        id: `cancellation-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Collection should be in loading state
      expect(collection.status).toBe(`loading`)

      // Cancel by cleaning up before query resolves
      await collection.cleanup()

      // Now resolve the promise
      resolvePromise!([{ id: `1`, name: `Item 1` }])

      // Wait a bit to ensure any async operations complete
      await flushPromises()

      // Collection should be cleaned up and not have processed the data
      expect(collection.status).toBe(`cleaned-up`)
      expect(collection.size).toBe(0)
    })

    it(`should maintain data consistency during rapid updates`, async () => {
      const queryKey = [`rapid-updates-test`]
      let updateCount = 0
      const queryFn = vi.fn().mockImplementation(() => {
        updateCount++
        return Promise.resolve([{ id: `1`, name: `Item ${updateCount}` }])
      })

      const config: QueryCollectionConfig<TestItem> = {
        id: `rapid-updates-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for initial data
      await vi.waitFor(() => {
        expect(collection.size).toBe(1)
      })

      // Perform rapid updates
      const updatePromises = []
      for (let i = 0; i < 5; i++) {
        updatePromises.push(collection.utils.refetch())
      }

      await Promise.all(updatePromises)

      // Collection should be in a consistent state
      expect(collection.size).toBe(1)
      expect(collection.status).toBe(`ready`)

      // The final data should reflect one of the updates
      const finalItem = collection.get(`1`)
      expect(finalItem?.name).toMatch(/^Item \d+$/)
    })

    it(`should manage startSync vs subscriber count priority correctly`, async () => {
      const queryKey1 = [`startSyncTruePriorityTest`]
      const queryKey2 = [`startSyncFalsePriorityTest`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn1 = vi.fn().mockResolvedValue(items)
      const queryFn2 = vi.fn().mockResolvedValue(items)

      // Test case 1: startSync=true should keep query active even with 0 subscribers
      const config1: QueryCollectionConfig<TestItem> = {
        id: `startSyncTrueTest`,
        queryClient,
        queryKey: queryKey1,
        queryFn: queryFn1,
        getKey,
        startSync: true,
      }

      const options1 = queryCollectionOptions(config1)
      const collection1 = createCollection(options1)

      await vi.waitFor(() => {
        expect(collection1.status).toBe(`ready`)
      })

      expect(collection1.subscriberCount).toBe(0)
      expect(queryFn1).toHaveBeenCalled()
      expect(collection1.status).toBe(`ready`) // Active due to startSync: true

      // Test case 2: startSync=false should rely purely on subscriber count
      const config2: QueryCollectionConfig<TestItem> = {
        id: `startSyncFalseTest`,
        queryClient,
        queryKey: queryKey2,
        queryFn: queryFn2,
        getKey,
        startSync: false,
      }

      const options2 = queryCollectionOptions(config2)
      const collection2 = createCollection(options2)

      await flushPromises()

      expect(collection2.subscriberCount).toBe(0)
      expect(queryFn2).not.toHaveBeenCalled() // Should not be called without subscribers
      expect(collection2.status).toBe(`idle`) // Inactive due to startSync: false + no subscribers

      // Add subscriber to collection2 -> should now activate
      const subscription = collection2.subscribeChanges(() => {})

      await vi.waitFor(() => expect(collection2.status).toBe(`ready`))

      expect(collection2.subscriberCount).toBe(1)
      expect(queryFn2).toHaveBeenCalled() // Now called due to subscriber

      // Remove subscriber -> query may still be active but subscriber count drops
      subscription.unsubscribe()
      expect(collection2.subscriberCount).toBe(0)

      // Verify the core logic: startSync || subscriberCount > 0
      // collection1: startSync=true, subscriberCount=0 -> active
      // collection2: startSync=false, subscriberCount=0 -> depends on implementation
      expect(collection1.status).toBe(`ready`) // Always active with startSync: true
    })
  })

  describe(`Manual Sync Operations`, () => {
    it(`should provide sync methods for manual collection updates`, async () => {
      const queryKey = [`sync-test`]
      const initialItems: Array<TestItem> = [
        { id: `1`, name: `Item 1`, value: 10 },
        { id: `2`, name: `Item 2`, value: 20 },
      ]

      const queryFn = vi.fn().mockResolvedValue(initialItems)

      const config: QueryCollectionConfig<TestItem> = {
        id: `sync-test-collection`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for collection to be ready
      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
        expect(collection.size).toBe(2)
      })

      // Test writeInsert
      const newItem: TestItem = { id: `3`, name: `Item 3`, value: 30 }
      collection.utils.writeInsert(newItem)

      expect(collection.size).toBe(3)
      expect(stripVirtualProps(collection.get(`3`))).toEqual(newItem)

      // Test writeUpdate
      collection.utils.writeUpdate({ id: `1`, name: `Updated Item 1` })

      const updatedItem = collection.get(`1`)
      expect(updatedItem?.name).toBe(`Updated Item 1`)
      expect(updatedItem?.value).toBe(10) // Should preserve other fields

      // Test writeUpsert (update existing)
      collection.utils.writeUpsert({
        id: `2`,
        name: `Upserted Item 2`,
        value: 25,
      })

      const upsertedItem = collection.get(`2`)
      expect(upsertedItem?.name).toBe(`Upserted Item 2`)
      expect(upsertedItem?.value).toBe(25)

      // Test writeUpsert (insert new)
      collection.utils.writeUpsert({ id: `4`, name: `New Item 4`, value: 40 })

      expect(collection.size).toBe(4)
      expect(stripVirtualProps(collection.get(`4`))).toEqual({
        id: `4`,
        name: `New Item 4`,
        value: 40,
      })

      // Test writeDelete
      collection.utils.writeDelete(`3`)

      expect(collection.size).toBe(3)
      expect(collection.has(`3`)).toBe(false)

      // Test batch operations
      collection.utils.writeInsert([
        { id: `5`, name: `Item 5`, value: 50 },
        { id: `6`, name: `Item 6`, value: 60 },
      ])

      expect(collection.size).toBe(5)
      expect(collection.get(`5`)?.name).toBe(`Item 5`)
      expect(collection.get(`6`)?.name).toBe(`Item 6`)

      // Test batch delete
      collection.utils.writeDelete([`5`, `6`])

      expect(collection.size).toBe(3)
      expect(collection.has(`5`)).toBe(false)
      expect(collection.has(`6`)).toBe(false)

      // Test writeBatch with mixed operations
      collection.utils.writeBatch(() => {
        collection.utils.writeInsert({
          id: `7`,
          name: `Batch Insert`,
          value: 70,
        })
        collection.utils.writeUpdate({ id: `4`, name: `Batch Updated Item 4` })
        collection.utils.writeUpsert({
          id: `8`,
          name: `Batch Upsert`,
          value: 80,
        })
        collection.utils.writeDelete(`1`)
      })

      expect(collection.size).toBe(4) // 3 - 1 (delete) + 2 (insert + upsert) = 4
      expect(collection.get(`7`)?.name).toBe(`Batch Insert`)
      expect(collection.get(`4`)?.name).toBe(`Batch Updated Item 4`)
      expect(collection.get(`8`)?.name).toBe(`Batch Upsert`)
      expect(collection.has(`1`)).toBe(false)
    })

    it(`should handle sync method errors appropriately`, async () => {
      const queryKey = [`sync-error-test`]
      const initialItems: Array<TestItem> = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(initialItems)

      const config: QueryCollectionConfig<TestItem> = {
        id: `sync-error-test-collection`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for collection to be ready
      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
      })

      // Test missing key error in writeUpdate
      expect(() => {
        collection.utils.writeUpdate({ id: `999`, name: `Missing` })
      }).toThrow(/does not exist/)

      // Test missing key error in writeDelete
      expect(() => {
        collection.utils.writeDelete(`999`)
      }).toThrow(/does not exist/)
    })

    it(`should handle writeBatch validation errors`, async () => {
      const queryKey = [`sync-batch-error-test`]
      const initialItems: Array<TestItem> = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(initialItems)

      const config: QueryCollectionConfig<TestItem> = {
        id: `sync-batch-error-test-collection`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for collection to be ready
      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
      })

      // Test duplicate keys within batch
      expect(() => {
        collection.utils.writeBatch(() => {
          collection.utils.writeInsert({ id: `2`, name: `Item 2` })
          collection.utils.writeUpdate({ id: `2`, name: `Updated Item 2` })
        })
      }).toThrow(/Duplicate key.*found within batch operations/)

      // Test updating non-existent item in batch
      expect(() => {
        collection.utils.writeBatch(() => {
          collection.utils.writeUpdate({ id: `999`, name: `Missing` })
        })
      }).toThrow(/does not exist/)

      // Test deleting non-existent item in batch
      expect(() => {
        collection.utils.writeBatch(() => {
          collection.utils.writeDelete(`999`)
        })
      }).toThrow(/does not exist/)
    })

    it(`should update query cache when using sync methods`, async () => {
      const queryKey = [`sync-cache-test`]
      const initialItems: Array<TestItem> = [
        { id: `1`, name: `Item 1`, value: 10 },
        { id: `2`, name: `Item 2`, value: 20 },
      ]

      const queryFn = vi.fn().mockResolvedValue(initialItems)

      const config: QueryCollectionConfig<TestItem> = {
        id: `sync-cache-test-collection`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for collection to be ready
      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
        expect(collection.size).toBe(2)
      })

      // Verify initial query cache state
      const initialCache = queryClient.getQueryData(queryKey) as Array<TestItem>
      expect(initialCache).toHaveLength(2)
      expect(initialCache).toEqual(initialItems)

      // Test writeInsert updates cache
      const newItem = { id: `3`, name: `Item 3`, value: 30 }
      collection.utils.writeInsert(newItem)

      const cacheAfterInsert = queryClient.getQueryData(
        queryKey,
      ) as Array<TestItem>
      expect(cacheAfterInsert).toHaveLength(3)
      expect(cacheAfterInsert).toContainEqual(newItem)

      // Test writeUpdate updates cache
      collection.utils.writeUpdate({ id: `1`, name: `Updated Item 1` })

      const cacheAfterUpdate = queryClient.getQueryData(
        queryKey,
      ) as Array<TestItem>
      expect(cacheAfterUpdate).toHaveLength(3)
      const updatedItem = cacheAfterUpdate.find((item) => item.id === `1`)
      expect(updatedItem?.name).toBe(`Updated Item 1`)
      expect(updatedItem?.value).toBe(10) // Original value preserved
      // Test writeDelete updates cache
      collection.utils.writeDelete(`2`)

      const cacheAfterDelete = queryClient.getQueryData(
        queryKey,
      ) as Array<TestItem>
      expect(cacheAfterDelete).toHaveLength(2)
      expect(cacheAfterDelete).not.toContainEqual({
        id: `2`,
        name: `Item 2`,
        value: 20,
      })

      // Test writeUpsert updates cache
      collection.utils.writeUpsert({ id: `4`, name: `Item 4`, value: 40 })

      const cacheAfterUpsert = queryClient.getQueryData(
        queryKey,
      ) as Array<TestItem>
      expect(cacheAfterUpsert).toHaveLength(3)
      expect(cacheAfterUpsert).toContainEqual({
        id: `4`,
        name: `Item 4`,
        value: 40,
      })

      // Test writeBatch updates cache with multiple operations
      collection.utils.writeBatch(() => {
        collection.utils.writeInsert({
          id: `5`,
          name: `Batch Item 5`,
          value: 50,
        })
        collection.utils.writeUpdate({ id: `3`, name: `Batch Updated Item 3` })
        collection.utils.writeDelete(`1`)
        collection.utils.writeUpsert({
          id: `6`,
          name: `Batch Item 6`,
          value: 60,
        })
      })

      const cacheAfterBatch = queryClient.getQueryData(
        queryKey,
      ) as Array<TestItem>
      expect(cacheAfterBatch).toHaveLength(4) // 3 - 1 (delete) + 1 (insert) + 1 (upsert) = 4

      // Verify specific changes from batch
      expect(cacheAfterBatch).not.toContainEqual(
        expect.objectContaining({ id: `1` }),
      )
      expect(cacheAfterBatch).toContainEqual({
        id: `5`,
        name: `Batch Item 5`,
        value: 50,
      })
      expect(cacheAfterBatch).toContainEqual({
        id: `6`,
        name: `Batch Item 6`,
        value: 60,
      })

      const batchUpdatedItem = cacheAfterBatch.find((item) => item.id === `3`)
      expect(batchUpdatedItem?.name).toBe(`Batch Updated Item 3`)
      expect(batchUpdatedItem?.value).toBe(30) // Original value preserved

      // Verify cache and collection are in sync
      expect(cacheAfterBatch.length).toBe(collection.size)
      expect(new Set(cacheAfterBatch)).toEqual(
        new Set(collection.toArray.map((item) => stripVirtualProps(item))),
      )
    })

    it(`should maintain cache consistency during error scenarios`, async () => {
      const queryKey = [`sync-cache-error-test`]
      const initialItems: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
      ]

      const queryFn = vi.fn().mockResolvedValue(initialItems)

      const config: QueryCollectionConfig<TestItem> = {
        id: `sync-cache-error-test-collection`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for collection to be ready
      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
      })

      // Get initial cache state
      const initialCache = queryClient.getQueryData(queryKey) as Array<TestItem>
      expect(initialCache).toHaveLength(2)

      // Try to update non-existent item (should throw and not update cache)
      expect(() => {
        collection.utils.writeUpdate({ id: `999`, name: `Should Fail` })
      }).toThrow()

      // Verify cache wasn't modified
      const cacheAfterError = queryClient.getQueryData(
        queryKey,
      ) as Array<TestItem>
      expect(cacheAfterError).toEqual(initialCache)
      expect(cacheAfterError).toHaveLength(2)

      // Try batch with duplicate keys (should throw and not update cache)
      expect(() => {
        collection.utils.writeBatch(() => {
          collection.utils.writeInsert({ id: `3`, name: `Item 3` })
          collection.utils.writeUpdate({ id: `3`, name: `Duplicate` })
        })
      }).toThrow(/Duplicate key/)

      // Verify cache wasn't modified
      const cacheAfterBatchError = queryClient.getQueryData(
        queryKey,
      ) as Array<TestItem>
      expect(cacheAfterBatchError).toEqual(initialCache)
      expect(cacheAfterBatchError).toHaveLength(2)
      expect(collection.size).toBe(2)
    })

    it(`should throw error for async callbacks in writeBatch`, async () => {
      const queryKey = [`asyncBatch`]
      const initialItems: Array<TestItem> = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(initialItems)

      const config: QueryCollectionConfig<TestItem> = {
        id: `async-batch-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      await vi.waitFor(() => {
        expect(collection.size).toBe(1)
      })

      // Test async callback throws error
      expect(() => {
        collection.utils.writeBatch(async () => {
          await Promise.resolve()
          collection.utils.writeInsert({ id: `2`, name: `Item 2` })
        })
      }).toThrow(/async callbacks/)

      // Verify no changes were made
      expect(collection.size).toBe(1)
    })

    it(`should prevent nested writeBatch calls`, async () => {
      const queryKey = [`nestedBatch`]
      const initialItems: Array<TestItem> = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(initialItems)

      const config: QueryCollectionConfig<TestItem> = {
        id: `nested-batch-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      await vi.waitFor(() => {
        expect(collection.size).toBe(1)
      })

      // Test nested writeBatch throws error
      expect(() => {
        collection.utils.writeBatch(() => {
          collection.utils.writeInsert({ id: `2`, name: `Item 2` })

          // Attempt nested batch
          collection.utils.writeBatch(() => {
            collection.utils.writeInsert({ id: `3`, name: `Item 3` })
          })
        })
      }).toThrow(/nest writeBatch/)

      // Verify no operations succeeded due to nested batch error
      expect(collection.size).toBe(1)
      expect(collection.has(`2`)).toBe(false)
      expect(collection.has(`3`)).toBe(false)
    })

    it(`should handle concurrent writeBatch calls from different collections`, async () => {
      const queryKey1 = [`collection1`]
      const queryKey2 = [`collection2`]
      const initialItems1: Array<TestItem> = [{ id: `1`, name: `Item 1` }]
      const initialItems2: Array<TestItem> = [{ id: `a`, name: `Item A` }]

      const queryFn1 = vi.fn().mockResolvedValue(initialItems1)
      const queryFn2 = vi.fn().mockResolvedValue(initialItems2)

      const config1: QueryCollectionConfig<TestItem> = {
        id: `collection-1`,
        queryClient,
        queryKey: queryKey1,
        queryFn: queryFn1,
        getKey,
        startSync: true,
      }

      const config2: QueryCollectionConfig<TestItem> = {
        id: `collection-2`,
        queryClient,
        queryKey: queryKey2,
        queryFn: queryFn2,
        getKey,
        startSync: true,
      }

      const options1 = queryCollectionOptions(config1)
      const options2 = queryCollectionOptions(config2)
      const collection1 = createCollection(options1)
      const collection2 = createCollection(options2)

      await vi.waitFor(() => {
        expect(collection1.size).toBe(1)
        expect(collection2.size).toBe(1)
      })

      // Execute batches concurrently (simulated by interleaving)
      let batch1Started = false
      let batch2Started = false

      collection1.utils.writeBatch(() => {
        batch1Started = true
        collection1.utils.writeInsert({ id: `2`, name: `Item 2` })

        // Start second batch while first is still active
        collection2.utils.writeBatch(() => {
          batch2Started = true
          collection2.utils.writeInsert({ id: `b`, name: `Item B` })
        })

        collection1.utils.writeInsert({ id: `3`, name: `Item 3` })
      })

      // Verify both batches executed successfully
      expect(batch1Started).toBe(true)
      expect(batch2Started).toBe(true)

      // Verify collection 1 has correct items
      expect(collection1.size).toBe(3)
      expect(collection1.has(`1`)).toBe(true)
      expect(collection1.has(`2`)).toBe(true)
      expect(collection1.has(`3`)).toBe(true)

      // Verify collection 2 has correct items
      expect(collection2.size).toBe(2)
      expect(collection2.has(`a`)).toBe(true)
      expect(collection2.has(`b`)).toBe(true)
    })

    it(`should replace optimistic state with server state when writeInsert is called in onInsert handler`, async () => {
      // Reproduces bug where optimistic client data overwrites server data in syncedData
      // When writeInsert is called inside onInsert handler to sync server-generated fields
      const queryKey = [`todos-writeinsert-bug`]
      const queryFn = vi.fn().mockResolvedValue([])

      type Todo = {
        id: number
        slug: string
        title: string
        checked: boolean
        createdAt: string
      }

      let nextServerId = 1
      const serverTodos: Array<Todo> = []

      async function sleep(timeMs: number) {
        return new Promise((resolve) => setTimeout(resolve, timeMs))
      }

      async function createTodos(newTodos: Array<Todo>) {
        await sleep(50)
        const savedTodos = newTodos.map((todo) => ({
          ...todo,
          id: nextServerId++,
          createdAt: new Date().toISOString(),
        }))
        serverTodos.push(...savedTodos)
        return savedTodos
      }

      const todosCollection = createCollection(
        queryCollectionOptions<Todo>({
          id: `writeinsert-bug-test`,
          queryKey,
          queryFn,
          queryClient,
          getKey: (item: Todo) => item.slug,
          startSync: true,
          onInsert: async ({ transaction }) => {
            const newItems = transaction.mutations.map((m) => m.modified)
            const serverItems = await createTodos(newItems)

            // Write server data with server-generated IDs to synced store
            todosCollection.utils.writeBatch(() => {
              serverItems.forEach((serverItem) => {
                todosCollection.utils.writeInsert(serverItem)
              })
            })

            return { refetch: false }
          },
        }),
      )

      await vi.waitFor(() => {
        expect(todosCollection.status).toBe(`ready`)
      })

      // Insert with client-side negative ID
      const clientId = -999
      const slug = `test-slug-${Date.now()}`

      todosCollection.insert({
        id: clientId,
        title: `Task`,
        slug,
        checked: false,
        createdAt: new Date().toISOString(),
      })

      // Wait for mutation to complete
      await flushPromises()
      await new Promise((resolve) => setTimeout(resolve, 100))

      // Verify syncedData has server ID, not client ID
      const syncedTodo = todosCollection._state.syncedData.get(slug)
      expect(syncedTodo).toBeDefined()
      expect(syncedTodo?.id).toBe(1) // Server-generated ID
      expect(syncedTodo?.id).not.toBe(clientId) // Not client optimistic ID

      // Verify visible state also shows server ID
      const todo = todosCollection.get(slug)
      expect(todo).toBeDefined()
      expect(todo?.id).toBe(1)
      expect(todo?.id).not.toBe(clientId)
    })

    it(`should update syncedData immediately when writeUpsert is called after async API in onUpdate handler`, async () => {
      // Reproduces bug where syncedData shows stale values when writeUpsert is called
      // AFTER an async API call in a mutation handler. The async await causes the
      // transaction to be added to state.transactions before writeUpsert runs,
      // which means commitPendingTransactions() sees hasPersistingTransaction=true
      // and would skip processing the sync transaction without the immediate flag.
      const queryKey = [`writeUpsert-after-api-test`]

      type Brand = {
        id: string
        brandName: string
      }

      const serverBrands: Array<Brand> = [{ id: `123`, brandName: `A` }]

      const queryFn = vi.fn().mockImplementation(() => {
        return Promise.resolve([...serverBrands])
      })

      // Track syncedData state immediately after writeUpsert
      let syncedDataAfterWriteUpsert: Brand | undefined
      let hasPersistingTransactionDuringWrite = false

      const collection = createCollection(
        queryCollectionOptions<Brand>({
          id: `writeUpsert-after-api-test`,
          queryKey,
          queryFn,
          queryClient,
          getKey: (item: Brand) => item.id,
          startSync: true,
          onUpdate: async ({ transaction }) => {
            const updates = transaction.mutations.map((m) => m.modified)

            // Simulate async API call - THIS IS KEY!
            // After this await, the transaction will be in state.transactions
            await new Promise((resolve) => setTimeout(resolve, 10))

            // Check if there's now a persisting transaction
            hasPersistingTransactionDuringWrite = Array.from(
              collection._state.transactions.values(),
            ).some((tx) => tx.state === `persisting`)

            // Update server state
            for (const update of updates) {
              const idx = serverBrands.findIndex((b) => b.id === update.id)
              if (idx !== -1) {
                serverBrands[idx] = { ...serverBrands[idx], ...update }
              }
            }

            // Write the server response back to syncedData
            // Without the immediate flag, this would be blocked by the persisting transaction
            collection.utils.writeBatch(() => {
              for (const update of updates) {
                collection.utils.writeUpsert(update)
              }
            })

            // Check syncedData IMMEDIATELY after writeUpsert
            syncedDataAfterWriteUpsert = collection._state.syncedData.get(`123`)

            return { refetch: false }
          },
        }),
      )

      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
      })

      // Verify initial state
      expect(collection._state.syncedData.get(`123`)?.brandName).toBe(`A`)

      // Update brandName from A to B
      collection.update(`123`, (draft) => {
        draft.brandName = `B`
      })

      // Wait for mutation to complete
      await flushPromises()
      await new Promise((resolve) => setTimeout(resolve, 50))

      // Verify we had a persisting transaction during the write
      expect(hasPersistingTransactionDuringWrite).toBe(true)

      // The CRITICAL assertion: syncedData should have been updated IMMEDIATELY after writeUpsert
      // Without the fix, this would fail because commitPendingTransactions() would skip
      // processing due to hasPersistingTransaction being true
      expect(syncedDataAfterWriteUpsert).toBeDefined()
      expect(syncedDataAfterWriteUpsert?.brandName).toBe(`B`)
    })

    it(`should not rollback object field updates after server response with refetch: false`, async () => {
      const queryKey = [`object-field-update-test`]

      type Todo = {
        id: string
        metadata: { createdBy: string }
      }

      const serverTodos: Array<Todo> = [
        { id: `1`, metadata: { createdBy: `user1` } },
      ]

      const queryFn = vi
        .fn()
        .mockImplementation(() => Promise.resolve([...serverTodos]))

      async function updateTodo(id: string, changes: Partial<Todo>) {
        await new Promise((resolve) => setTimeout(resolve, 10))
        const todo = serverTodos.find((t) => t.id === id)
        if (todo) {
          Object.assign(todo, changes)
        }
        return todo
      }

      const todosCollection = createCollection(
        queryCollectionOptions<Todo>({
          id: `object-field-update-test`,
          queryKey,
          queryFn,
          queryClient,
          getKey: (item: Todo) => item.id,
          startSync: true,
          onUpdate: async ({ transaction }) => {
            const updates = transaction.mutations.map((m) => ({
              id: m.key as string,
              changes: m.changes,
            }))

            const serverItems = await Promise.all(
              updates.map((update) => updateTodo(update.id, update.changes)),
            )

            todosCollection.utils.writeBatch(() => {
              serverItems.forEach((serverItem) => {
                if (serverItem) {
                  todosCollection.utils.writeUpdate(serverItem)
                }
              })
            })

            return { refetch: false }
          },
        }),
      )

      await vi.waitFor(() => {
        expect(todosCollection.status).toBe(`ready`)
      })

      // Verify initial state
      expect(todosCollection.get(`1`)?.metadata.createdBy).toBe(`user1`)

      // Update 1: change metadata from user1 to user456
      todosCollection.update(`1`, (draft) => {
        draft.metadata = { createdBy: `user456` }
      })

      // Wait for mutation to complete
      await new Promise((resolve) => setTimeout(resolve, 50))

      // Verify Update 1 worked
      expect(todosCollection.get(`1`)?.metadata.createdBy).toBe(`user456`)
      expect(
        todosCollection._state.syncedData.get(`1`)?.metadata.createdBy,
      ).toBe(`user456`)

      // Update 2: change metadata from user456 to user789
      todosCollection.update(`1`, (draft) => {
        draft.metadata = { createdBy: `user789` }
      })

      // Wait for mutation to complete
      await new Promise((resolve) => setTimeout(resolve, 50))

      // Verify Update 2 persisted correctly
      expect(
        todosCollection._state.syncedData.get(`1`)?.metadata.createdBy,
      ).toBe(`user789`)
      expect(todosCollection.get(`1`)?.metadata.createdBy).toBe(`user789`)
    })
  })

  it(`should call markReady when queryFn returns an empty array`, async () => {
    const queryKey = [`emptyArrayTest`]
    const queryFn = vi.fn().mockResolvedValue([])

    const config: QueryCollectionConfig<TestItem> = {
      id: `test`,
      queryClient,
      queryKey,
      queryFn,
      getKey,
      startSync: true,
    }

    const options = queryCollectionOptions(config)
    const collection = createCollection(options)

    // Wait for the query to complete
    await vi.waitFor(
      () => {
        expect(queryFn).toHaveBeenCalledTimes(1)
        // The collection should be marked as ready even with empty array
        expect(collection.status).toBe(`ready`)
      },
      {
        timeout: 1000,
        interval: 50,
      },
    )

    // Verify the collection is empty but ready
    expect(collection.size).toBe(0)
    expect(collection.status).toBe(`ready`)
  })

  it(`should read the state of a query that is already ready`, async () => {
    // Populate the query cache, so the query will immediately be loaded
    const queryKey = [`raceConditionTest`]
    const initialItems: Array<TestItem> = [
      { id: `1`, name: `Cached Item 1` },
      { id: `2`, name: `Cached Item 2` },
    ]
    const queryFn: (
      context: QueryFunctionContext<any>,
    ) => Promise<Array<TestItem>> = vi.fn().mockReturnValue(initialItems)
    await queryClient.prefetchQuery({ queryKey, queryFn })

    // The collection should immediately be ready
    const collection = createCollection(
      queryCollectionOptions({
        id: `test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
        staleTime: 60000, // uses the prefetched value without a refetch
      }),
    )
    expect(collection.status).toBe(`ready`)
    expect(collection.size).toBe(2)
    expect(
      Array.from(collection.values()).map((item) => stripVirtualProps(item)),
    ).toEqual(expect.arrayContaining(initialItems))
  })

  describe(`subscriber count tracking and auto-subscription`, () => {
    it(`should not auto-subscribe when startSync=false and no subscribers`, async () => {
      const queryKey = [`noSubscriptionTest`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `noSubscriptionTest`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: false,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Give it time to potentially subscribe (it shouldn't)
      await flushPromises()

      expect(collection.subscriberCount).toBe(0)
      expect(collection.status).toBe(`idle`) // Should remain idle without startSync or subscribers
      expect(queryFn).not.toHaveBeenCalled() // Query should not be executed
    })

    it(`should subscribe/unsubscribe based on subscriber count transitions`, async () => {
      const queryKey = [`countTransitionTest`]
      const items = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `countTransition`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: false, // Start unsubscribed
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Should start unsubscribed
      expect(collection.subscriberCount).toBe(0)
      expect(collection.status).toBe(`idle`)

      // Add a subscriber -> should subscribe and load data
      const subscription1 = collection.subscribeChanges(() => {})

      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
      })

      expect(collection.subscriberCount).toBe(1)
      expect(queryFn).toHaveBeenCalled()

      // Add another subscriber - should not trigger additional queries
      const initialCallCount = queryFn.mock.calls.length
      const subscription2 = collection.subscribeChanges(() => {})
      expect(collection.subscriberCount).toBe(2)

      await flushPromises()
      expect(queryFn.mock.calls.length).toBe(initialCallCount) // No additional calls

      // Remove first subscriber - should still be subscribed
      subscription1.unsubscribe()
      expect(collection.subscriberCount).toBe(1)
      expect(collection.status).toBe(`ready`)

      // Remove last subscriber -> query should remain active but collection subscriber count drops to 0
      subscription2.unsubscribe()
      expect(collection.subscriberCount).toBe(0)
    })
  })

  it(`should use exact targeting when refetching to avoid unintended cascading of related queries`, async () => {
    // Create multiple collections with related but distinct query keys
    const queryKey = [`todos`]
    const queryKey1 = [`todos`, `project-1`]
    const queryKey2 = [`todos`, `project-2`]

    const mockItems = [{ id: `1`, name: `Item 1` }]
    const queryFn = vi.fn().mockResolvedValue(mockItems)
    const queryFn1 = vi.fn().mockResolvedValue(mockItems)
    const queryFn2 = vi.fn().mockResolvedValue(mockItems)

    const config: QueryCollectionConfig<TestItem> = {
      id: `all-todos`,
      queryClient,
      queryKey: queryKey,
      queryFn: queryFn,
      getKey,
      startSync: true,
    }
    const config1: QueryCollectionConfig<TestItem> = {
      id: `project-1-todos`,
      queryClient,
      queryKey: queryKey1,
      queryFn: queryFn1,
      getKey,
      startSync: true,
    }
    const config2: QueryCollectionConfig<TestItem> = {
      id: `project-2-todos`,
      queryClient,
      queryKey: queryKey2,
      queryFn: queryFn2,
      getKey,
      startSync: true,
    }

    const options = queryCollectionOptions(config)
    const options1 = queryCollectionOptions(config1)
    const options2 = queryCollectionOptions(config2)

    const collection = createCollection(options)
    const collection1 = createCollection(options1)
    const collection2 = createCollection(options2)

    // Wait for initial queries to complete
    await vi.waitFor(() => {
      expect(queryFn).toHaveBeenCalledTimes(1)
      expect(queryFn1).toHaveBeenCalledTimes(1)
      expect(queryFn2).toHaveBeenCalledTimes(1)
      expect(collection.status).toBe(`ready`)
    })

    // Reset call counts to test refetch behavior
    queryFn.mockClear()
    queryFn1.mockClear()
    queryFn2.mockClear()

    // Refetch the target collection with key ['todos', 'project-1']
    await collection1.utils.refetch()

    // Verify that only the target query was refetched
    await vi.waitFor(() => {
      expect(queryFn1).toHaveBeenCalledTimes(1)
      expect(queryFn).not.toHaveBeenCalled()
      expect(queryFn2).not.toHaveBeenCalled()
    })

    // Cleanup
    await Promise.all([
      collection.cleanup(),
      collection1.cleanup(),
      collection2.cleanup(),
    ])
  })

  it(`should use exact targeting when clearError() refetches to avoid unintended cascading`, async () => {
    const queryKey1 = [`todos`, `project-1`]
    const queryKey2 = [`todos`, `project-2`]

    const testError = new Error(`Test error`)
    const mockItems = [{ id: `1`, name: `Item 1` }]
    const queryFn1 = vi
      .fn()
      .mockRejectedValueOnce(testError)
      .mockResolvedValue(mockItems)
    const queryFn2 = vi.fn().mockResolvedValue(mockItems)

    const config1: QueryCollectionConfig<TestItem> = {
      id: `project-1-todos-clear-error`,
      queryClient,
      queryKey: queryKey1,
      queryFn: queryFn1,
      getKey,
      startSync: true,
      retry: false,
    }
    const config2: QueryCollectionConfig<TestItem> = {
      id: `project-2-todos-clear-error`,
      queryClient,
      queryKey: queryKey2,
      queryFn: queryFn2,
      getKey,
      startSync: true,
      retry: false,
    }

    const options1 = queryCollectionOptions(config1)
    const options2 = queryCollectionOptions(config2)

    const collection1 = createCollection(options1)
    const collection2 = createCollection(options2)

    await vi.waitFor(() => {
      expect(collection1.utils.isError).toBe(true)
      expect(collection2.status).toBe(`ready`)
    })

    queryFn1.mockClear()
    queryFn2.mockClear()

    await collection1.utils.clearError()

    await vi.waitFor(() => {
      expect(queryFn1).toHaveBeenCalledTimes(1)
      expect(queryFn2).not.toHaveBeenCalled()
    })

    await Promise.all([collection1.cleanup(), collection2.cleanup()])
  })

  it(`should propagate errors when throwOnError is true in refetch`, async () => {
    const testError = new Error(`Refetch error`)
    const queryKey = [`throw-on-error-test`]
    const queryFn = vi.fn().mockRejectedValue(testError)

    await queryClient.prefetchQuery({ queryKey, queryFn })

    const collection = createCollection(
      queryCollectionOptions({
        id: `throw-on-error-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        retry: false,
        startSync: true,
      }),
    )

    await vi.waitFor(() => {
      expect(collection.utils.isError).toBe(true)
    })

    await expect(
      collection.utils.refetch({ throwOnError: true }),
    ).rejects.toThrow(testError)

    // Should not throw when throwOnError is false
    await collection.utils.refetch({ throwOnError: false })

    await collection.cleanup()
  })

  describe(`refetch() behavior`, () => {
    it(`should refetch when collection is syncing (startSync: true)`, async () => {
      const queryKey = [`refetch-test-syncing`]
      const queryFn = vi.fn().mockResolvedValue([{ id: `1`, name: `A` }])

      const collection = createCollection(
        queryCollectionOptions({
          id: `refetch-test-syncing`,
          queryClient,
          queryKey,
          queryFn,
          getKey,
          startSync: true,
        }),
      )

      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
      })

      queryFn.mockClear()

      await collection.utils.refetch()
      expect(queryFn).toHaveBeenCalledTimes(1)

      await collection.cleanup()
    })

    it(`should refetch even when enabled: false (imperative refetch pattern)`, async () => {
      const mockItems: Array<TestItem> = [{ id: `1`, name: `Item 1` }]
      const queryKey = [`manual-fetch-test`]
      const queryFn = vi.fn().mockResolvedValue(mockItems)

      const collection = createCollection(
        queryCollectionOptions({
          id: `manual-fetch-test`,
          queryClient,
          queryKey,
          queryFn,
          getKey,
          enabled: false,
          startSync: true,
        }),
      )

      // Query should not auto-fetch due to enabled: false
      expect(queryFn).not.toHaveBeenCalled()

      // But manual refetch should work
      await collection.utils.refetch()
      expect(queryFn).toHaveBeenCalledTimes(1)

      await collection.cleanup()
    })

    it(`should be no-op when sync has not started (no observer created)`, async () => {
      const queryKey = [`refetch-test-no-sync`]
      const queryFn = vi.fn().mockResolvedValue([{ id: `1`, name: `A` }])

      const collection = createCollection(
        queryCollectionOptions({
          id: `refetch-test-no-sync`,
          queryClient,
          queryKey,
          queryFn,
          getKey,
          startSync: false,
        }),
      )

      // Refetch should be no-op because observer doesn't exist yet
      await collection.utils.refetch()
      expect(queryFn).not.toHaveBeenCalled()

      await collection.cleanup()
    })

    it(`should return array of QueryObserverResult`, async () => {
      const queryKey = [`refetch-return-value-test`]
      const mockData = [{ id: `1`, val: Math.random() * 100 }]
      const queryFn = vi.fn().mockResolvedValue(mockData)

      const collection = createCollection(
        queryCollectionOptions({
          id: `refetch-return-value-test`,
          queryClient,
          queryKey,
          queryFn,
          getKey,
          startSync: true,
        }),
      )

      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
      })

      queryFn.mockClear()

      const result = await collection.utils.refetch()

      expect(queryFn).toHaveBeenCalledTimes(1)

      expect(result).not.toBeUndefined()
      expect(Array.isArray(result)).toBe(true)
      expect(result.length).toBeGreaterThan(0)
      for (const r of result) {
        expect(r).toHaveProperty(`status`)
        expect(r).toHaveProperty(`data`)
      }

      await collection.cleanup()
    })
  })

  describe(`Error Handling`, () => {
    // Helper to create test collection with common configuration
    const createErrorHandlingTestCollection = (
      testId: string,
      queryFn: ReturnType<typeof vi.fn>,
    ) => {
      const config: QueryCollectionConfig<TestItem> = {
        id: testId,
        queryClient,
        queryKey: [testId],
        queryFn,
        getKey,
        startSync: true,
        retry: false,
      }
      const options = queryCollectionOptions(config)
      return createCollection(options)
    }

    it(`should track error state, count, and support recovery`, async () => {
      const initialData = [{ id: `1`, name: `Item 1` }]
      const updatedData = [{ id: `1`, name: `Updated Item 1` }]
      const errors = [new Error(`First error`), new Error(`Second error`)]

      const queryFn = vi
        .fn()
        .mockResolvedValueOnce(initialData) // Initial success
        .mockRejectedValueOnce(errors[0]) // First error
        .mockRejectedValueOnce(errors[1]) // Second error
        .mockResolvedValueOnce(updatedData) // Recovery

      const collection = createErrorHandlingTestCollection(
        `error-tracking-test`,
        queryFn,
      )

      // Wait for initial success - no errors
      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
        expect(collection.utils.lastError).toBeUndefined()
        expect(collection.utils.isError).toBe(false)
        expect(collection.utils.errorCount).toBe(0)
      })

      // First error - count increments
      await collection.utils.refetch()
      await vi.waitFor(() => {
        expect(collection.utils.lastError).toBe(errors[0])
        expect(collection.utils.errorCount).toBe(1)
        expect(collection.utils.isError).toBe(true)
      })

      // Second error - count increments again
      await collection.utils.refetch()
      await vi.waitFor(() => {
        expect(collection.utils.lastError).toBe(errors[1])
        expect(collection.utils.errorCount).toBe(2)
        expect(collection.utils.isError).toBe(true)
      })

      // Successful refetch resets error state
      await collection.utils.refetch()
      await vi.waitFor(() => {
        expect(collection.utils.lastError).toBeUndefined()
        expect(collection.utils.isError).toBe(false)
        expect(collection.utils.errorCount).toBe(0)
        expect(stripVirtualProps(collection.get(`1`))).toEqual(updatedData[0])
      })
    })

    it(`should support manual error recovery with clearError`, async () => {
      const recoveryData = [{ id: `1`, name: `Item 1` }]
      const testError = new Error(`Test error`)

      const queryFn = vi
        .fn()
        .mockRejectedValueOnce(testError)
        .mockResolvedValueOnce(recoveryData)
        .mockRejectedValueOnce(testError)

      const collection = createErrorHandlingTestCollection(
        `clear-error-test`,
        queryFn,
      )

      // Wait for initial error
      await vi.waitFor(() => {
        expect(collection.utils.isError).toBe(true)
        expect(collection.utils.errorCount).toBe(1)
      })

      // Manual error clearing triggers refetch
      await collection.utils.clearError()

      expect(collection.utils.lastError).toBeUndefined()
      expect(collection.utils.isError).toBe(false)
      expect(collection.utils.errorCount).toBe(0)

      await vi.waitFor(() => {
        expect(stripVirtualProps(collection.get(`1`))).toEqual(recoveryData[0])
      })

      // Refetch on rejection should throw an error
      await expect(collection.utils.clearError()).rejects.toThrow(testError)
      expect(collection.utils.lastError).toBe(testError)
      expect(collection.utils.isError).toBe(true)
      expect(collection.utils.errorCount).toBe(1)
    })

    it(`should maintain collection functionality despite errors and persist error state`, async () => {
      const initialData = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
      ]
      const testError = new Error(`Query error`)

      const queryFn = vi
        .fn()
        .mockResolvedValueOnce(initialData)
        .mockRejectedValue(testError)

      const collection = createErrorHandlingTestCollection(
        `functionality-with-errors-test`,
        queryFn,
      )

      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
        expect(collection.size).toBe(2)
      })

      // Cause error
      await collection.utils.refetch()
      await vi.waitFor(() => {
        expect(collection.utils.errorCount).toBe(1)
        expect(collection.utils.isError).toBe(true)
      })

      // Collection operations still work with cached data
      expect(collection.size).toBe(2)
      expect(stripVirtualProps(collection.get(`1`))).toEqual(initialData[0])
      expect(stripVirtualProps(collection.get(`2`))).toEqual(initialData[1])

      // Manual write operations work and clear error state
      const newItem = { id: `3`, name: `Manual Item` }
      collection.utils.writeInsert(newItem)
      expect(collection.size).toBe(3)
      expect(stripVirtualProps(collection.get(`3`))).toEqual(newItem)

      await flushPromises()

      // Manual writes clear error state
      expect(collection.utils.lastError).toBeUndefined()
      expect(collection.utils.isError).toBe(false)
      expect(collection.utils.errorCount).toBe(0)

      // Create error state again for persistence test
      await collection.utils.refetch()
      await vi.waitFor(() => expect(collection.utils.isError).toBe(true))

      const originalError = collection.utils.lastError
      const originalErrorCount = collection.utils.errorCount

      // Read-only operations don't affect error state
      expect(collection.has(`1`)).toBe(true)
      const changeHandler = vi.fn()
      const subscription = collection.subscribeChanges(changeHandler)

      expect(collection.utils.lastError).toBe(originalError)
      expect(collection.utils.isError).toBe(true)
      expect(collection.utils.errorCount).toBe(originalErrorCount)

      subscription.unsubscribe()
    })

    it(`should handle custom error objects correctly`, async () => {
      interface CustomError {
        code: string
        message: string
        details?: Record<string, unknown>
      }
      const customError: CustomError = {
        code: `NETWORK_ERROR`,
        message: `Failed to fetch data`,
        details: { retryAfter: 5000 },
      }

      // Start with error immediately - no initial success needed
      const queryFn = vi.fn().mockRejectedValue(customError)

      const config: QueryCollectionConfig<
        TestItem,
        typeof queryFn,
        CustomError
      > = {
        id: `custom-error-test`,
        queryClient,
        queryKey: [`custom-error-test`],
        queryFn,
        getKey,
        startSync: true,
        retry: false,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for collection to be ready (even with error)
      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
        expect(collection.utils.isError).toBe(true)
      })

      // Verify custom error is accessible with all its properties
      const lastError = collection.utils.lastError
      expect(lastError).toBe(customError)
      expect(lastError?.code).toBe(`NETWORK_ERROR`)
      expect(lastError?.message).toBe(`Failed to fetch data`)
      expect(lastError?.details?.retryAfter).toBe(5000)
      expect(collection.utils.errorCount).toBe(1)
    })

    it(`should persist error state after collection cleanup`, async () => {
      const testError = new Error(`Persistent error`)

      // Start with error immediately
      const queryFn = vi.fn().mockRejectedValue(testError)

      const collection = createErrorHandlingTestCollection(
        `error-persistence-cleanup-test`,
        queryFn,
      )

      // Wait for collection to be ready (even with error)
      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
        expect(collection.utils.isError).toBe(true)
      })

      // Verify error state before cleanup
      expect(collection.utils.lastError).toBe(testError)
      expect(collection.utils.errorCount).toBe(1)

      // Cleanup collection
      await collection.cleanup()
      expect(collection.status).toBe(`cleaned-up`)

      // Error state should persist after cleanup
      expect(collection.utils.isError).toBe(true)
      expect(collection.utils.lastError).toBe(testError)
      expect(collection.utils.errorCount).toBe(1)
    })

    it(`should increment errorCount only after final failure when using Query retries`, async () => {
      const testError = new Error(`Retry test error`)
      const retryCount = 2
      const totalAttempts = retryCount + 1

      // Create a queryFn that fails consistently
      const queryFn = vi.fn().mockRejectedValue(testError)

      // Create collection with retry enabled (2 retries = 3 total attempts)
      const config: QueryCollectionConfig<TestItem> = {
        id: `retry-semantics-test`,
        queryClient,
        queryKey: [`retry-semantics-test`],
        queryFn,
        getKey,
        startSync: true,
        retry: retryCount, // This will result in 3 total attempts (initial + 2 retries)
        retryDelay: 5, // Short delay for faster tests
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for all retry attempts to complete and final failure
      await vi.waitFor(
        () => {
          expect(collection.status).toBe(`ready`) // Should be ready even with error
          expect(queryFn).toHaveBeenCalledTimes(totalAttempts)
          expect(collection.utils.isError).toBe(true)
        },
        { timeout: 2000 },
      )

      // Error count should only increment once after all retries are exhausted
      // This ensures we track "consecutive post-retry failures," not per-attempt failures
      expect(collection.utils.errorCount).toBe(1)
      expect(collection.utils.lastError).toBe(testError)
      expect(collection.utils.isError).toBe(true)

      // Reset attempt counter for second test
      queryFn.mockClear()

      // Trigger another refetch which should also retry and fail
      await collection.utils.refetch()

      // Wait for the second set of retries to complete
      await vi.waitFor(
        () => {
          expect(queryFn).toHaveBeenCalledTimes(totalAttempts)
        },
        { timeout: 2000 },
      )

      // Error count should now be 2 (two post-retry failures)
      expect(collection.utils.errorCount).toBe(2)
      expect(collection.utils.lastError).toBe(testError)
      expect(collection.utils.isError).toBe(true)
    })
  })

  describe(`preload()`, () => {
    it(`should resolve preload() even without startSync or subscribers`, async () => {
      const queryKey = [`preload-test`]
      const items: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `preload-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        // Note: NOT setting startSync: true
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Collection should be idle initially
      expect(collection.status).toBe(`idle`)
      expect(queryFn).not.toHaveBeenCalled()

      // Preload should resolve without any subscribers
      await collection.preload()

      // After preload, collection should be ready and queryFn should have been called
      expect(collection.status).toBe(`ready`)
      expect(queryFn).toHaveBeenCalledTimes(1)
      expect(collection.size).toBe(items.length)
      expect(stripVirtualProps(collection.get(`1`))).toEqual(items[0])
      expect(stripVirtualProps(collection.get(`2`))).toEqual(items[1])
    })

    it(`should not call queryFn multiple times if preload() is called concurrently`, async () => {
      const queryKey = [`preload-concurrent-test`]
      const items: Array<TestItem> = [{ id: `1`, name: `Item 1` }]

      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `preload-concurrent-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Call preload() multiple times concurrently
      const promises = [
        collection.preload(),
        collection.preload(),
        collection.preload(),
      ]

      await Promise.all(promises)

      // queryFn should only be called once despite multiple preload() calls
      expect(queryFn).toHaveBeenCalledTimes(1)
      expect(collection.status).toBe(`ready`)
      expect(collection.size).toBe(items.length)
    })
    it(`should allow writeDelete in onDelete handler to write to synced store`, async () => {
      const queryKey = [`writeDelete-in-onDelete-test`]
      const items: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      const onDelete = vi.fn(({ transaction, collection }) => {
        const deletedItem = transaction.mutations[0]?.original
        // Call writeDelete inside onDelete handler - this should work without throwing
        collection.utils.writeDelete(deletedItem.id)
        return Promise.resolve({ refetch: false })
      })

      const config: QueryCollectionConfig<TestItem> = {
        id: `writeDelete-in-onDelete-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
        onDelete,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
        expect(collection.size).toBe(2)
      })

      const transaction = collection.delete(`1`)
      await transaction.isPersisted.promise

      // Verify the fix: writeDelete should work, transaction completes, item is deleted
      expect(transaction.state).toBe(`completed`)
      expect(onDelete).toHaveBeenCalledTimes(1)
      expect(collection.has(`1`)).toBe(false)
      expect(collection.size).toBe(1)
    })

    it(`should transition to ready immediately in on-demand mode without loading data`, async () => {
      const queryKey = [`preload-on-demand-test`]
      const items: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `preload-on-demand-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        syncMode: `on-demand`, // No initial query in on-demand mode
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Collection should be idle initially
      expect(collection.status).toBe(`idle`)
      expect(queryFn).not.toHaveBeenCalled()
      expect(collection.size).toBe(0)

      // Preload should resolve immediately without calling queryFn
      // since there's no initial query in on-demand mode
      await collection.preload()

      // After preload, collection should be ready
      // but queryFn should NOT have been called and collection should still be empty
      expect(collection.status).toBe(`ready`)
      expect(queryFn).not.toHaveBeenCalled()
      expect(collection.size).toBe(0)

      // Now if we call loadSubset, it should actually load data
      await collection._sync.loadSubset({})

      await vi.waitFor(() => {
        expect(collection.size).toBe(items.length)
      })

      expect(queryFn).toHaveBeenCalledTimes(1)
      expect(stripVirtualProps(collection.get(`1`))).toEqual(items[0])
      expect(stripVirtualProps(collection.get(`2`))).toEqual(items[1])
    })
  })

  describe(`QueryClient defaultOptions`, () => {
    it(`should respect defaultOptions from QueryClient when not overridden`, async () => {
      // Create a QueryClient with custom defaultOptions
      const customQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            staleTime: 10000, // 10 seconds
            retry: 2,
            refetchOnWindowFocus: false,
          },
        },
      })

      const queryKey = [`defaultOptionsTest`]
      const items: Array<TestItem> = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      // Create a collection without specifying staleTime or retry
      const config: QueryCollectionConfig<TestItem> = {
        id: `defaultOptionsTest`,
        queryClient: customQueryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
      })

      // Verify queryFn was called once
      expect(queryFn).toHaveBeenCalledTimes(1)

      // Verify the query has the correct staleTime from defaultOptions
      const query = customQueryClient.getQueryCache().find({ queryKey })
      expect((query?.options as any).staleTime).toBe(10000)

      // Clean up
      customQueryClient.clear()
    })

    it(`should override defaultOptions when explicitly provided in queryCollectionOptions`, async () => {
      // Create a QueryClient with custom defaultOptions
      const customQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            staleTime: 10000, // 10 seconds default
            retry: 2,
          },
        },
      })

      const queryKey = [`overrideOptionsTest`]
      const items: Array<TestItem> = [{ id: `1`, name: `Item 1` }]
      const queryFn = vi.fn().mockResolvedValue(items)

      // Create a collection WITH explicit staleTime override
      const config: QueryCollectionConfig<TestItem> = {
        id: `overrideOptionsTest`,
        queryClient: customQueryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
        staleTime: 100, // Override to 100ms
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      await vi.waitFor(() => {
        expect(collection.status).toBe(`ready`)
      })

      // Verify the query uses the overridden staleTime (100ms), not the default (10000ms)
      const query = customQueryClient.getQueryCache().find({ queryKey })
      expect((query?.options as any).staleTime).toBe(100)

      // Clean up
      customQueryClient.clear()
    })

    it(`should use retry from QueryClient defaultOptions when not overridden`, async () => {
      let callCount = 0
      // Create a QueryClient with custom retry defaultOption
      const customQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            retry: 2, // Retry 2 times
            retryDelay: 1, // 1ms delay for fast test
          },
        },
      })

      const queryKey = [`retryDefaultOptionsTest`]
      const queryFn = vi.fn().mockImplementation(() => {
        callCount++
        // Fail on first 2 attempts, succeed on 3rd
        if (callCount <= 2) {
          return Promise.reject(new Error(`Attempt ${callCount} failed`))
        }
        return Promise.resolve([{ id: `1`, name: `Item 1` }])
      })

      // Create a collection without specifying retry
      const config: QueryCollectionConfig<TestItem> = {
        id: `retryDefaultOptionsTest`,
        queryClient: customQueryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for the query to eventually succeed (after retries)
      await vi.waitFor(
        () => {
          expect(collection.status).toBe(`ready`)
        },
        { timeout: 2000 },
      )

      // Should have called queryFn 3 times (initial + 2 retries)
      expect(callCount).toBe(3)

      // Clean up
      customQueryClient.clear()
    })
  })

  describe(`Query Garbage Collection`, () => {
    const isCategory = (category: `A` | `B` | `C`, where: any) => {
      return (
        where &&
        where.type === `func` &&
        where.name === `eq` &&
        where.args[0].path[0] === `category` &&
        where.args[1].value === category
      )
    }

    it(`should delete all rows when a single query is garbage collected`, async () => {
      const queryKey = [`single-query-gc-test`]
      const items: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
        { id: `3`, name: `Item 3` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `single-query-gc-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for initial data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(3)
        expect(stripVirtualProps(collection.get(`1`))).toEqual(items[0])
        expect(stripVirtualProps(collection.get(`2`))).toEqual(items[1])
        expect(stripVirtualProps(collection.get(`3`))).toEqual(items[2])
      })

      // Verify all items are in the collection
      expect(collection.has(`1`)).toBe(true)
      expect(collection.has(`2`)).toBe(true)
      expect(collection.has(`3`)).toBe(true)

      // Simulate query garbage collection by removing the query from the cache
      await collection.cleanup()

      // Verify all items are removed
      expect(collection.has(`1`)).toBe(false)
      expect(collection.has(`2`)).toBe(false)
      expect(collection.has(`3`)).toBe(false)
    })

    it(`should only delete non-shared rows when one of multiple overlapping queries is GCed`, async () => {
      const baseQueryKey = [`overlapping-query-test`]

      // Mock queryFn to return different data based on predicates
      const queryFn = vi.fn().mockImplementation((context) => {
        const { meta } = context
        const loadSubsetOptions = meta?.loadSubsetOptions ?? {}
        const { where } = loadSubsetOptions

        // Query 1: items 1, 2, 3 (where: { category: 'A' })
        if (isCategory(`A`, where)) {
          console.log(`Is category A`)
          return Promise.resolve([
            { id: `1`, name: `Item 1` },
            { id: `2`, name: `Item 2` },
            { id: `3`, name: `Item 3` },
          ])
        }

        // Query 2: items 2, 3, 4 (where: { category: 'B' })
        if (isCategory(`B`, where)) {
          return Promise.resolve([
            { id: `2`, name: `Item 2` },
            { id: `3`, name: `Item 3` },
            { id: `4`, name: `Item 4` },
          ])
        }

        // Query 3: items 3, 4, 5 (where: { category: 'C' })
        if (isCategory(`C`, where)) {
          return Promise.resolve([
            { id: `3`, name: `Item 3` },
            { id: `4`, name: `Item 4` },
            { id: `5`, name: `Item 5` },
          ])
        }
        return Promise.resolve([])
      })

      const queryKey = (ctx: any) => {
        if (ctx.where) {
          return [...baseQueryKey, ctx.where]
        }
        return baseQueryKey
      }

      const config: QueryCollectionConfig<
        TestItem & { category: `A` | `B` | `C` }
      > = {
        id: `overlapping-test`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Collection should start empty with on-demand sync mode
      expect(collection.size).toBe(0)

      // Load query 1 with no predicates (items 1, 2, 3)
      const query1 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query1.preload()

      // Wait for query 1 data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(3)
      })

      // Add query 2 with different predicates (items 2, 3, 4)
      // We abuse the `where` clause being typed as `any` to pass a category
      // but in real usage this would be some Intermediate Representation of the where clause
      const query2 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `B`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query2.preload()

      // Wait for query 2 data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(4) // Should have items 1, 2, 3, 4
      })

      // Add query 3 with different predicates
      const query3 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `C`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query3.preload()

      // Wait for query 3 data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(5) // Should have items 1, 2, 3, 4, 5
      })

      // Verify all items are present
      expect(collection.has(`1`)).toBe(true)
      expect(collection.has(`2`)).toBe(true)
      expect(collection.has(`3`)).toBe(true)
      expect(collection.has(`4`)).toBe(true)
      expect(collection.has(`5`)).toBe(true)

      // GC query 1 (no predicates) - should only remove item 1 (unique to query 1)
      // Items 2 and 3 should remain because they're shared with other queries
      await query1.cleanup()

      // Wait for async GC to complete (gcTime: 0 still schedules async removal)
      await vi.waitFor(() => {
        expect(collection.size).toBe(4) // Should have items 2, 3, 4, 5
      })

      // Verify item 1 is removed (it was only in query 1)
      expect(collection.has(`1`)).toBe(false)

      // Verify shared items are still present
      expect(collection.has(`2`)).toBe(true)
      expect(collection.has(`3`)).toBe(true)
      expect(collection.has(`4`)).toBe(true)
      expect(collection.has(`5`)).toBe(true)

      // GC query 2 (where: { category: 'B' }) - should remove item 2
      // Items 3 and 4 should remain because they are shared with query 3
      await query2.cleanup()

      // Wait for async GC to complete
      await vi.waitFor(() => {
        expect(collection.size).toBe(3) // Should have items 3, 4, 5
      })

      // Verify item 2 is removed (it was only in query 2)
      expect(collection.has(`2`)).toBe(false)

      // Verify items 3 and 4 are still present (shared with query 3)
      expect(collection.has(`3`)).toBe(true)
      expect(collection.has(`4`)).toBe(true)
      expect(collection.has(`5`)).toBe(true)

      // GC query 3 (where: { category: 'C' }) - should remove all remaining items
      await query3.cleanup()

      // Wait for async GC to complete
      await vi.waitFor(() => {
        expect(collection.size).toBe(0)
      })

      // Verify all items are now removed
      expect(collection.has(`3`)).toBe(false)
      expect(collection.has(`4`)).toBe(false)
      expect(collection.has(`5`)).toBe(false)
    })

    it(`should handle GC of queries with identical data`, async () => {
      const baseQueryKey = [`identical-query-test`]

      // Mock queryFn to return the same data for all queries
      const queryFn = vi.fn().mockImplementation(() => {
        // All queries return the same data regardless of predicates
        return Promise.resolve([
          { id: `1`, name: `Item 1`, category: `A` },
          { id: `2`, name: `Item 2`, category: `A` },
          { id: `3`, name: `Item 3`, category: `A` },
        ])
      })

      const config: QueryCollectionConfig<CategorisedItem> = {
        id: `identical-test`,
        queryClient,
        queryKey: (ctx) => {
          if (ctx.where) {
            return [...baseQueryKey, ctx.where]
          }
          return baseQueryKey
        },
        queryFn,
        getKey,
        startSync: true,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Collection should start empty with on-demand sync mode
      expect(collection.size).toBe(0)

      // Load query 1 with no predicates (items 1, 2, 3)
      const query1 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query1.preload()

      // Wait for query 1 data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(3)
      })

      // Add query 2 with different predicates (but returns same data)
      const query2 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query2.preload()

      // Wait for query 2 data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(3) // Same data, no new items
      })

      // Add query 3 with different predicates (but returns same data)
      const query3 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) =>
              or(eq(item.category, `A`), eq(item.category, `B`)),
            )
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query3.preload()

      // Wait for query 3 data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(3) // Same data, no new items
      })

      // GC query 1 - should not remove any items (all items are shared with other queries)
      await query1.cleanup()

      expect(collection.size).toBe(3) // Items still present due to other queries

      // All items should still be present
      expect(collection.has(`1`)).toBe(true)
      expect(collection.has(`2`)).toBe(true)
      expect(collection.has(`3`)).toBe(true)

      // GC query 2 - should still not remove any items (all items are shared with query 3)
      await query2.cleanup()

      expect(collection.size).toBe(3) // Items still present due to query 3

      // All items should still be present
      expect(collection.has(`1`)).toBe(true)
      expect(collection.has(`2`)).toBe(true)
      expect(collection.has(`3`)).toBe(true)

      // GC query 3 - should remove all items (no more queries reference them)
      await query3.cleanup()

      // Wait for async GC to complete
      await vi.waitFor(() => {
        expect(collection.size).toBe(0)
      })

      // All items should now be removed
      expect(collection.has(`1`)).toBe(false)
      expect(collection.has(`2`)).toBe(false)
      expect(collection.has(`3`)).toBe(false)
    })

    it(`should handle GC of empty queries gracefully`, async () => {
      const baseQueryKey = [`empty-query-test`]

      // Mock queryFn to return different data based on predicates
      const queryFn = vi.fn().mockImplementation((context) => {
        const { meta } = context
        const loadSubsetOptions = meta?.loadSubsetOptions || {}
        const { where } = loadSubsetOptions

        // Query 2: some items (where: { category: 'B' })
        if (isCategory(`B`, where)) {
          return Promise.resolve([
            { id: `1`, name: `Item 1`, category: `B` },
            { id: `2`, name: `Item 2`, category: `B` },
          ])
        }

        return Promise.resolve([])
      })

      const config: QueryCollectionConfig<TestItem & { category: `A` | `B` }> =
        {
          id: `empty-test`,
          queryClient,
          queryKey: (ctx) => {
            if (ctx.where) {
              return [...baseQueryKey, ctx.where]
            }
            return baseQueryKey
          },
          queryFn,
          getKey,
          startSync: true,
          syncMode: `on-demand`,
        }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Collection should start empty with on-demand sync mode
      expect(collection.size).toBe(0)

      // Load query 1 (returns empty array)
      const query1 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      await query1.preload()

      // Wait for query 1 data to load (still empty)
      await vi.waitFor(() => {
        expect(collection.size).toBe(0) // Empty query
      })

      // Add query 2 with different predicates (items 1, 2)
      const query2 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `B`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query2.preload()

      // Wait for query 2 data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(2) // Should have items 1, 2
      })

      // Verify items are present
      expect(collection.has(`1`)).toBe(true)
      expect(collection.has(`2`)).toBe(true)

      // GC empty query 1 - should not affect the collection
      await query1.cleanup()

      // Collection should still have items from query 2
      expect(collection.size).toBe(2)
      expect(collection.has(`1`)).toBe(true)
      expect(collection.has(`2`)).toBe(true)

      // GC non-empty query 2 - should remove its items
      await query2.cleanup()

      await vi.waitFor(() => {
        expect(collection.size).toBe(0)
      })

      expect(collection.has(`1`)).toBe(false)
      expect(collection.has(`2`)).toBe(false)
    })

    it(`should handle concurrent GC of multiple queries`, async () => {
      const baseQueryKey = [`concurrent-query-test`]

      // Mock queryFn to return different data based on predicates
      const queryFn = vi.fn().mockImplementation((context) => {
        const { meta } = context
        const loadSubsetOptions = meta?.loadSubsetOptions || {}
        const { where } = loadSubsetOptions

        // Query 1: items 1, 2 (no predicates)
        if (isCategory(`C`, where)) {
          return Promise.resolve([
            { id: `1`, name: `Item 1`, category: `C` },
            { id: `2`, name: `Item 2`, category: `C` },
          ])
        }

        // Query 2: items 2, 3 (where: { type: 'A' })
        if (isCategory(`A`, where)) {
          return Promise.resolve([
            { id: `2`, name: `Item 2`, category: `A` },
            { id: `3`, name: `Item 3`, category: `A` },
          ])
        }

        // Query 3: items 3, 4 (where: { type: 'B' })
        if (isCategory(`B`, where)) {
          return Promise.resolve([
            { id: `3`, name: `Item 3`, category: `B` },
            { id: `4`, name: `Item 4`, category: `B` },
          ])
        }

        return Promise.resolve([])
      })

      const config: QueryCollectionConfig<
        TestItem & { category: `A` | `B` | `C` }
      > = {
        id: `concurrent-test`,
        queryClient,
        queryKey: (ctx) => {
          if (ctx.where) {
            return [...baseQueryKey, ctx.where]
          }
          return baseQueryKey
        },
        queryFn,
        getKey,
        startSync: true,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Collection should start empty with on-demand sync mode
      expect(collection.size).toBe(0)

      // Load query 1 with no predicates (items 1, 2)
      const query1 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `C`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query1.preload()

      // Wait for query 1 data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
      })

      // Add query 2 with different predicates (items 2, 3)
      const query2 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query2.preload()

      // Wait for query 2 data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(3) // Should have items 1, 2, 3
      })

      // Add query 3 with different predicates
      const query3 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `B`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query3.preload()

      // Wait for query 3 data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(4) // Should have items 1, 2, 3, 4
      })

      // GC all queries concurrently
      const queries = [query1, query2, query3]
      const proms = queries.map((query) => query.cleanup())
      await Promise.all(proms)

      // Wait for async GC to complete
      await vi.waitFor(() => {
        expect(collection.size).toBe(0)
      })

      // Verify all items are removed
      expect(collection.has(`1`)).toBe(false)
      expect(collection.has(`2`)).toBe(false)
      expect(collection.has(`3`)).toBe(false)
      expect(collection.has(`4`)).toBe(false)
    })

    it(`should handle GC correctly when queries are ordered and have a LIMIT`, async () => {
      const baseQueryKey = [`deduplication-gc-test`]

      // Mock queryFn to return different data based on predicates
      const queryFn = vi.fn().mockImplementation((context) => {
        const { meta } = context
        const loadSubsetOptions = meta?.loadSubsetOptions ?? {}
        const { where, limit } = loadSubsetOptions

        // Query 1: all items with category A (no limit)
        if (isCategory(`A`, where)) {
          const items = [
            { id: `1`, name: `Item 1`, category: `A` },
            { id: `2`, name: `Item 2`, category: `A` },
            { id: `3`, name: `Item 3`, category: `A` },
          ]
          // Slice to limit if provided
          return Promise.resolve(limit ? items.slice(0, limit) : items)
        }

        return Promise.resolve([])
      })

      const config: QueryCollectionConfig<CategorisedItem> = {
        id: `deduplication-test`,
        queryClient,
        queryKey: (ctx) => {
          const key = [...baseQueryKey]
          if (ctx.where) {
            key.push(`where`, JSON.stringify(ctx.where))
          }
          if (ctx.limit) {
            key.push(`limit`, ctx.limit.toString())
          }
          if (ctx.orderBy) {
            key.push(`orderBy`, JSON.stringify(ctx.orderBy))
          }
          return key
        },
        queryFn,
        getKey,
        startSync: true,
        syncMode: `on-demand`,
        autoIndex: `eager`,
        defaultIndexType: BTreeIndex,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Collection should start empty with on-demand sync mode
      expect(collection.size).toBe(0)

      // Execute first query: load all rows that belong to category A (returns 3 rows)
      const query1 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query1.preload()

      // Wait for first query data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(3)
        expect(queryFn).toHaveBeenCalledTimes(1)
      })

      // Verify all 3 items are present
      expect(collection.has(`1`)).toBe(true)
      expect(collection.has(`2`)).toBe(true)
      expect(collection.has(`3`)).toBe(true)

      // Execute second query: load rows with category A, limit 2, ordered by ID
      // This should be deduplicated since we already have all category A data
      // So it will load the data from the local collection
      const query2 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .orderBy(({ item }) => item.id, `asc`)
            .limit(2)
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await query2.preload()

      await flushPromises()

      // queryFn should have been called twice
      // because we do not dedupe the 2nd query
      expect(queryFn).toHaveBeenCalledTimes(2)

      // Collection should still have all 3 items (deduplication doesn't remove data)
      expect(collection.size).toBe(3)
      expect(collection.has(`1`)).toBe(true)
      expect(collection.has(`2`)).toBe(true)
      expect(collection.has(`3`)).toBe(true)

      // GC the first query (all category A without limit)
      await query1.cleanup()

      // Wait for async GC to complete
      await vi.waitFor(() => {
        expect(collection.size).toBe(2) // Should only have items 1 and 2 because they are still referenced by query 2
      })

      // Verify that only row 3 is removed (it was only referenced by query 1)
      expect(collection.has(`1`)).toBe(true) // Still present (referenced by query 2)
      expect(collection.has(`2`)).toBe(true) // Still present (referenced by query 2)
      expect(collection.has(`3`)).toBe(false) // Removed (only referenced by query 1)

      // GC the second query (category A with limit 2)
      await query2.cleanup()

      // Wait for final GC to process
      await vi.waitFor(() => {
        expect(collection.size).toBe(0)
      })
    })

    it(`should handle duplicate subset loads correctly (refcount bug)`, async () => {
      // This test catches Bug 1: missing refcount increment when reusing existing observer
      // When two subscriptions load the same subset, unloading one should NOT destroy
      // the observer since another subscription still needs it

      const baseQueryKey = [`refcount-bug-test`]
      const items: Array<CategorisedItem> = [
        { id: `1`, name: `Item 1`, category: `A` },
        { id: `2`, name: `Item 2`, category: `A` },
        { id: `3`, name: `Item 3`, category: `A` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<CategorisedItem> = {
        id: `refcount-test`,
        queryClient,
        queryKey: baseQueryKey,
        queryFn,
        getKey: (item) => item.id,
        startSync: true,
        syncMode: `on-demand`,
        onInsert: () => Promise.resolve({ refetch: false }),
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Create two live queries that request the SAME subset
      const query1 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      const query2 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      // Load both queries
      await query1.preload()
      await query2.preload()

      // Wait for data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(3)
      })
      expect(queryFn).toHaveBeenCalledTimes(1) // Deduplicated

      // Cleanup query1
      await query1.cleanup()
      await flushPromises()

      // BUG: Without refcount increment on reuse, the observer is destroyed
      // and query2 stops receiving updates. Collection data is also removed.
      // EXPECTED: query2 should still work since it's using the same observer
      await vi.waitFor(() => {
        expect(collection.size).toBe(3) // Should still have data for query2
      })

      // Verify query2 still works by mutating data
      await collection.insert({ id: `4`, name: `Item 4`, category: `A` })
      await vi.waitFor(() => {
        expect(collection.size).toBe(4)
        expect(collection.has(`4`)).toBe(true)
      })

      // Now cleanup query2
      await query2.cleanup()
      await vi.waitFor(() => {
        expect(collection.size).toBe(0) // NOW it should be cleaned up
      })
    })

    it(`should diff against retained query-owned rows on warm start`, async () => {
      const baseQueryKey = [`persisted-baseline-test`]
      const queryFn = vi.fn().mockResolvedValue([])

      const config: QueryCollectionConfig<CategorisedItem> = {
        id: `persisted-baseline-test`,
        queryClient,
        queryKey: baseQueryKey,
        queryFn,
        getKey: (item) => item.id,
        syncMode: `eager`,
        startSync: false,
      }

      const baseOptions = queryCollectionOptions(config)
      const originalSync = baseOptions.sync
      const ownedRow = { id: `1`, name: `Owned row`, category: `A` }
      const unrelatedRow = { id: `2`, name: `Unrelated row`, category: `B` }
      const ownedQueryHash = hashKey(baseQueryKey)
      const metadataHarness = createInMemorySyncMetadataApi<string | number>({
        rowMetadata: new Map([
          [
            ownedRow.id,
            {
              queryCollection: {
                owners: {
                  [ownedQueryHash]: true,
                },
              },
            },
          ],
        ]),
        collectionMetadata: new Map([
          [
            `queryCollection:gc:${ownedQueryHash}`,
            {
              queryHash: ownedQueryHash,
              mode: `until-revalidated`,
            },
          ],
        ]),
        persistedRows: new Map([
          [ownedRow.id, ownedRow],
          [unrelatedRow.id, unrelatedRow],
        ]),
      })

      const collection = createCollection({
        ...baseOptions,
        sync: {
          sync: (params: Parameters<typeof originalSync.sync>[0]) => {
            params.begin({ immediate: true })
            params.write({ type: `insert`, value: ownedRow })
            params.write({ type: `insert`, value: unrelatedRow })
            params.commit()

            return originalSync.sync({
              ...params,
              metadata: metadataHarness.api,
            })
          },
        },
      })

      await collection.preload()
      await flushPromises()

      expect(queryFn).toHaveBeenCalledTimes(1)
      expect(collection.has(ownedRow.id)).toBe(false)
      expect(collection.has(unrelatedRow.id)).toBe(true)
      expect(
        metadataHarness.collectionMetadata.has(
          `queryCollection:gc:${ownedQueryHash}`,
        ),
      ).toBe(false)
    })

    it(`should clean up expired persisted ttl placeholders on startup`, async () => {
      const baseQueryKey = [`persisted-ttl-cleanup-test`]
      const queryFn = vi.fn().mockResolvedValue([])
      const expiredQueryHash = hashKey(baseQueryKey)
      const otherOwnerHash = `other-owner`

      const config: QueryCollectionConfig<CategorisedItem> = {
        id: `persisted-ttl-cleanup-test`,
        queryClient,
        queryKey: baseQueryKey,
        queryFn,
        getKey: (item) => item.id,
        syncMode: `on-demand`,
        startSync: true,
      }

      const baseOptions = queryCollectionOptions(config)
      const originalSync = baseOptions.sync
      const orphanRow = { id: `1`, name: `Orphan`, category: `A` }
      const sharedRow = { id: `2`, name: `Shared`, category: `B` }
      const metadataHarness = createInMemorySyncMetadataApi<string | number>({
        rowMetadata: new Map([
          [
            orphanRow.id,
            {
              queryCollection: {
                owners: {
                  [expiredQueryHash]: true,
                },
              },
            },
          ],
          [
            sharedRow.id,
            {
              queryCollection: {
                owners: {
                  [expiredQueryHash]: true,
                  [otherOwnerHash]: true,
                },
              },
            },
          ],
        ]),
        collectionMetadata: new Map([
          [
            `queryCollection:gc:${expiredQueryHash}`,
            {
              queryHash: expiredQueryHash,
              mode: `ttl`,
              expiresAt: Date.now() - 1_000,
            },
          ],
        ]),
        persistedRows: new Map([
          [orphanRow.id, orphanRow],
          [sharedRow.id, sharedRow],
        ]),
      })

      const collection = createCollection({
        ...baseOptions,
        sync: {
          sync: (params: Parameters<typeof originalSync.sync>[0]) => {
            params.begin({ immediate: true })
            params.write({ type: `insert`, value: orphanRow })
            params.write({ type: `insert`, value: sharedRow })
            params.commit()

            return originalSync.sync({
              ...params,
              metadata: metadataHarness.api,
            })
          },
        },
      })

      await collection.stateWhenReady()
      await flushPromises()

      expect(queryFn).not.toHaveBeenCalled()
      expect(collection.has(orphanRow.id)).toBe(false)
      expect(collection.has(sharedRow.id)).toBe(true)
      expect(
        metadataHarness.collectionMetadata.get(
          `queryCollection:gc:${expiredQueryHash}`,
        ),
      ).toBeUndefined()
      expect(metadataHarness.rowMetadata.get(sharedRow.id)).toEqual({
        queryCollection: {
          owners: {
            [otherOwnerHash]: true,
          },
        },
      })
    })

    it(`should preserve until-revalidated retained rows on startup`, async () => {
      const baseQueryKey = [`persisted-until-revalidated-test`]
      const queryFn = vi.fn().mockResolvedValue([])
      const retainedQueryHash = hashKey(baseQueryKey)

      const config: QueryCollectionConfig<CategorisedItem> = {
        id: `persisted-until-revalidated-test`,
        queryClient,
        queryKey: baseQueryKey,
        queryFn,
        getKey: (item) => item.id,
        syncMode: `on-demand`,
        startSync: true,
      }

      const baseOptions = queryCollectionOptions(config)
      const originalSync = baseOptions.sync
      const retainedRow = { id: `1`, name: `Retained`, category: `A` }
      const metadataHarness = createInMemorySyncMetadataApi<string | number>({
        rowMetadata: new Map([
          [
            retainedRow.id,
            {
              queryCollection: {
                owners: {
                  [retainedQueryHash]: true,
                },
              },
            },
          ],
        ]),
        collectionMetadata: new Map([
          [
            `queryCollection:gc:${retainedQueryHash}`,
            {
              queryHash: retainedQueryHash,
              mode: `until-revalidated`,
            },
          ],
        ]),
      })

      const collection = createCollection({
        ...baseOptions,
        sync: {
          sync: (params: Parameters<typeof originalSync.sync>[0]) => {
            params.begin({ immediate: true })
            params.write({ type: `insert`, value: retainedRow })
            params.commit()

            return originalSync.sync({
              ...params,
              metadata: metadataHarness.api,
            })
          },
        },
      })

      await collection.stateWhenReady()
      await flushPromises()

      expect(queryFn).not.toHaveBeenCalled()
      expect(collection.has(retainedRow.id)).toBe(true)
      expect(
        metadataHarness.collectionMetadata.get(
          `queryCollection:gc:${retainedQueryHash}`,
        ),
      ).toEqual({
        queryHash: retainedQueryHash,
        mode: `until-revalidated`,
      })
    })

    it(`should clean up expired retained placeholders for cold persisted rows through the persisted wrapper`, async () => {
      const queryHash = hashKey([`persisted-cold-ttl-cleanup`])
      const otherOwnerHash = `other-owner`
      const orphanRow = { id: `1`, name: `Cold orphan`, category: `A` }
      const sharedRow = { id: `2`, name: `Cold shared`, category: `B` }
      const adapter = createPersistedQueryAdapter<CategorisedItem>({
        rows: new Map([
          [orphanRow.id, orphanRow],
          [sharedRow.id, sharedRow],
        ]),
        rowMetadata: new Map([
          [
            orphanRow.id,
            {
              queryCollection: {
                owners: {
                  [queryHash]: true,
                },
              },
            },
          ],
          [
            sharedRow.id,
            {
              queryCollection: {
                owners: {
                  [queryHash]: true,
                  [otherOwnerHash]: true,
                },
              },
            },
          ],
        ]),
        collectionMetadata: new Map([
          [
            `queryCollection:gc:${queryHash}`,
            {
              queryHash,
              mode: `ttl`,
              expiresAt: Date.now() - 1_000,
            },
          ],
        ]),
      })

      const collection = createCollection(
        persistedCollectionOptions({
          ...(queryCollectionOptions<CategorisedItem>({
            id: `persisted-cold-ttl-cleanup`,
            queryClient,
            queryKey: [`persisted-cold-ttl-cleanup`],
            queryFn: async () => [],
            getKey: (item: CategorisedItem): string => item.id,
            syncMode: `on-demand`,
            startSync: true,
          }) as any),
          persistence: {
            adapter,
          },
        }) as any,
      )

      await collection.stateWhenReady()
      await flushPromises()

      expect(adapter.rows.has(orphanRow.id)).toBe(false)
      expect(adapter.rows.has(sharedRow.id)).toBe(true)
      expect(
        adapter.collectionMetadata.has(`queryCollection:gc:${queryHash}`),
      ).toBe(false)
      expect(adapter.rowMetadata.get(sharedRow.id)).toEqual({
        queryCollection: {
          owners: {
            [otherOwnerHash]: true,
          },
        },
      })
    })

    it(`should revalidate retained queries against cold persisted baselines through the persisted wrapper`, async () => {
      const queryHash = hashKey([`persisted-cold-retained`])
      const retainedRow = { id: `1`, name: `Stale retained`, category: `A` }
      const adapter = createPersistedQueryAdapter<CategorisedItem>({
        rows: new Map([[retainedRow.id, retainedRow]]),
        rowMetadata: new Map([
          [
            retainedRow.id,
            {
              queryCollection: {
                owners: {
                  [queryHash]: true,
                },
              },
            },
          ],
        ]),
        collectionMetadata: new Map([
          [
            `queryCollection:gc:${queryHash}`,
            {
              queryHash,
              mode: `until-revalidated`,
            },
          ],
        ]),
      })

      const collection = createCollection(
        persistedCollectionOptions({
          ...(queryCollectionOptions<CategorisedItem>({
            id: `persisted-cold-retained`,
            queryClient,
            queryKey: [`persisted-cold-retained`],
            queryFn: async () => [],
            getKey: (item: CategorisedItem): string => item.id,
            syncMode: `on-demand`,
            startSync: true,
          }) as any),
          persistence: {
            adapter,
          },
        }) as any,
      )

      await collection.stateWhenReady()
      expect(adapter.rows.has(retainedRow.id)).toBe(true)

      const liveQuery = createLiveQueryCollection({
        query: (q) => q.from({ item: collection }),
      })

      await liveQuery.preload()
      await flushPromises()

      expect(adapter.rows.has(retainedRow.id)).toBe(false)
      expect(
        adapter.collectionMetadata.has(`queryCollection:gc:${queryHash}`),
      ).toBe(false)
    })

    it(`should expire retained ttl placeholders while the app stays open`, async () => {
      vi.useFakeTimers()
      try {
        const baseQueryKey = [`runtime-ttl-retention-test`]
        const retainedQueryHash = hashKey(baseQueryKey)
        const items: Array<CategorisedItem> = [
          { id: `1`, name: `Retained`, category: `A` },
        ]
        const queryFn = vi.fn().mockResolvedValue(items)

        const config: QueryCollectionConfig<CategorisedItem> = {
          id: `runtime-ttl-retention-test`,
          queryClient,
          queryKey: () => baseQueryKey,
          queryFn,
          getKey: (item) => item.id,
          syncMode: `on-demand`,
          startSync: true,
          persistedGcTime: 100,
        }

        const baseOptions = queryCollectionOptions(config)
        const originalSync = baseOptions.sync
        const metadataHarness = createInMemorySyncMetadataApi<
          string | number,
          CategorisedItem
        >({
          persistedRows: new Map(items.map((item) => [item.id, item])),
        })

        const collection = createCollection({
          ...baseOptions,
          sync: {
            sync: (params: Parameters<typeof originalSync.sync>[0]) =>
              originalSync.sync({
                ...params,
                metadata: metadataHarness.api,
              }),
          },
        })

        const liveQuery = createLiveQueryCollection({
          query: (q) =>
            q
              .from({ item: collection })
              .where(({ item }) => eq(item.category, `A`)),
        })

        await liveQuery.preload()
        await vi.waitFor(() => {
          expect(collection.size).toBe(1)
        })

        await liveQuery.cleanup()

        expect(
          metadataHarness.collectionMetadata.get(
            `queryCollection:gc:${retainedQueryHash}`,
          ),
        ).toEqual({
          queryHash: retainedQueryHash,
          mode: `ttl`,
          expiresAt: expect.any(Number),
        })

        await vi.advanceTimersByTimeAsync(150)
        await vi.runOnlyPendingTimersAsync()

        expect(
          metadataHarness.collectionMetadata.get(
            `queryCollection:gc:${retainedQueryHash}`,
          ),
        ).toBeUndefined()
        expect(collection.has(`1`)).toBe(false)
      } finally {
        vi.useRealTimers()
      }
    })

    it(`should default persisted retention ttl to query gcTime when persistedGcTime is undefined`, async () => {
      vi.useFakeTimers()
      const gcTime = 120
      const gcTimeFallbackQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            gcTime,
            staleTime: 0,
            retry: false,
          },
        },
      })

      try {
        const baseQueryKey = [`runtime-ttl-retention-default-gctime-test`]
        const retainedQueryHash = hashKey(baseQueryKey)
        const items: Array<CategorisedItem> = [
          { id: `1`, name: `Retained`, category: `A` },
        ]
        const queryFn = vi.fn().mockResolvedValue(items)

        const config: QueryCollectionConfig<CategorisedItem> = {
          id: `runtime-ttl-retention-default-gctime-test`,
          queryClient: gcTimeFallbackQueryClient,
          queryKey: () => baseQueryKey,
          queryFn,
          getKey: (item) => item.id,
          syncMode: `on-demand`,
          startSync: true,
        }

        const baseOptions = queryCollectionOptions(config)
        const originalSync = baseOptions.sync
        const metadataHarness = createInMemorySyncMetadataApi<
          string | number,
          CategorisedItem
        >({
          persistedRows: new Map(items.map((item) => [item.id, item])),
        })

        const collection = createCollection({
          ...baseOptions,
          sync: {
            sync: (params: Parameters<typeof originalSync.sync>[0]) =>
              originalSync.sync({
                ...params,
                metadata: metadataHarness.api,
              }),
          },
        })

        const liveQuery = createLiveQueryCollection({
          query: (q) =>
            q
              .from({ item: collection })
              .where(({ item }) => eq(item.category, `A`)),
        })

        await liveQuery.preload()
        await vi.waitFor(() => {
          expect(collection.size).toBe(1)
        })

        await liveQuery.cleanup()

        const retentionEntry = metadataHarness.collectionMetadata.get(
          `queryCollection:gc:${retainedQueryHash}`,
        ) as
          | {
              queryHash: string
              mode: `ttl` | `until-revalidated`
              expiresAt?: number
            }
          | undefined

        expect(retentionEntry).toEqual({
          queryHash: retainedQueryHash,
          mode: `ttl`,
          expiresAt: expect.any(Number),
        })
        expect(retentionEntry?.expiresAt).toBeGreaterThanOrEqual(Date.now())
        expect(retentionEntry?.expiresAt).toBeLessThanOrEqual(
          Date.now() + gcTime,
        )

        await vi.advanceTimersByTimeAsync(gcTime + 25)
        await vi.runOnlyPendingTimersAsync()

        expect(
          metadataHarness.collectionMetadata.get(
            `queryCollection:gc:${retainedQueryHash}`,
          ),
        ).toBeUndefined()
        expect(collection.has(`1`)).toBe(false)
      } finally {
        gcTimeFallbackQueryClient.clear()
        vi.useRealTimers()
      }
    })

    it(`should default persisted retention to resolved query gcTime when queryClient gcTime is implicit`, async () => {
      vi.useFakeTimers()
      const implicitGcTimeQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            staleTime: 0,
            retry: false,
          },
        },
      })

      try {
        const baseQueryKey = [`runtime-ttl-retention-implicit-gctime-test`]
        const retainedQueryHash = hashKey(baseQueryKey)
        const items: Array<CategorisedItem> = [
          { id: `1`, name: `Retained`, category: `A` },
        ]
        const queryFn = vi.fn().mockResolvedValue(items)

        const config: QueryCollectionConfig<CategorisedItem> = {
          id: `runtime-ttl-retention-implicit-gctime-test`,
          queryClient: implicitGcTimeQueryClient,
          queryKey: () => baseQueryKey,
          queryFn,
          getKey: (item) => item.id,
          syncMode: `on-demand`,
          startSync: true,
        }

        const baseOptions = queryCollectionOptions(config)
        const originalSync = baseOptions.sync
        const metadataHarness = createInMemorySyncMetadataApi<
          string | number,
          CategorisedItem
        >({
          persistedRows: new Map(items.map((item) => [item.id, item])),
        })

        const collection = createCollection({
          ...baseOptions,
          sync: {
            sync: (params: Parameters<typeof originalSync.sync>[0]) =>
              originalSync.sync({
                ...params,
                metadata: metadataHarness.api,
              }),
          },
        })

        const liveQuery = createLiveQueryCollection({
          query: (q) =>
            q
              .from({ item: collection })
              .where(({ item }) => eq(item.category, `A`)),
        })

        await liveQuery.preload()
        await vi.waitFor(() => {
          expect(collection.size).toBe(1)
        })

        const resolvedQueryGcTime = implicitGcTimeQueryClient
          .getQueryCache()
          .find({ queryKey: baseQueryKey, exact: true })?.gcTime

        expect(resolvedQueryGcTime).toBeDefined()

        await liveQuery.cleanup()

        const retentionEntry = metadataHarness.collectionMetadata.get(
          `queryCollection:gc:${retainedQueryHash}`,
        ) as
          | {
              queryHash: string
              mode: `ttl` | `until-revalidated`
              expiresAt?: number
            }
          | undefined

        if (resolvedQueryGcTime === Number.POSITIVE_INFINITY) {
          expect(retentionEntry).toEqual({
            queryHash: retainedQueryHash,
            mode: `until-revalidated`,
          })
        } else {
          expect(retentionEntry).toEqual({
            queryHash: retainedQueryHash,
            mode: `ttl`,
            expiresAt: expect.any(Number),
          })
          expect(retentionEntry?.expiresAt).toBeGreaterThanOrEqual(Date.now())
          expect(retentionEntry?.expiresAt).toBeLessThanOrEqual(
            Date.now() + resolvedQueryGcTime!,
          )

          await vi.advanceTimersByTimeAsync(resolvedQueryGcTime! + 25)
          await vi.runOnlyPendingTimersAsync()

          expect(
            metadataHarness.collectionMetadata.get(
              `queryCollection:gc:${retainedQueryHash}`,
            ),
          ).toBeUndefined()
          expect(collection.has(`1`)).toBe(false)
        }
      } finally {
        implicitGcTimeQueryClient.clear()
        vi.useRealTimers()
      }
    })

    it(`should reset refcount after query GC and reload (stale refcount bug)`, async () => {
      // This test catches Bug 2: stale refcounts after GC/remove
      // When TanStack Query GCs a query, the refcount should be cleaned up
      // Otherwise, reloading the same subset will start with a stale count

      const baseQueryKey = [`stale-refcount-test`]
      const items: Array<CategorisedItem> = [
        { id: `1`, name: `Item 1`, category: `A` },
        { id: `2`, name: `Item 2`, category: `A` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<CategorisedItem> = {
        id: `stale-refcount-test`,
        queryClient,
        queryKey: baseQueryKey,
        queryFn,
        getKey: (item) => item.id,
        startSync: true,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Create and load a query
      const query1 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      await query1.preload()

      // Wait for data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
      })

      // Force GC by calling removeQueries (simulates gcTime expiry)
      queryClient.removeQueries({ queryKey: baseQueryKey })
      await flushPromises()

      // BUG: queryRefCounts still has stale count, wasn't cleaned up by cleanupQuery
      // When we load again, the refcount will be wrong (starts at 1 instead of 0, or accumulates)

      // Reload the same query
      const query2 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      await query2.preload()

      // Wait for data to reload
      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
      })

      // Cleanup - this should properly decrement from 1 to 0 and clean up
      await query2.cleanup()
      await vi.waitFor(() => {
        expect(collection.size).toBe(0) // Should be cleaned up
      })

      // BUG SYMPTOM: If refcount was stale (e.g. was 2, decremented to 1),
      // the observer won't be destroyed and data won't be cleaned up
    })

    it(`should handle mount/unmount/remount without breaking cache (destroyed observer bug)`, async () => {
      // This test catches Bug 3: destroyed observer reuse
      // When subscriberCount hits 0, unsubscribeFromQueries() destroys observers
      // but leaves them in state.observers. On remount, subscribeToQueries()
      // tries to reuse destroyed observers, which breaks cache processing

      const baseQueryKey = [`destroyed-observer-test`]
      const items: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      // Use a longer gcTime to ensure cache persists across unmount/remount
      const customQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            gcTime: 5 * 60 * 1000, // 5 minutes
            staleTime: Infinity, // set an Infinity staleTime to prevent a refetch
            retry: false,
          },
        },
      })

      const config: QueryCollectionConfig<TestItem> = {
        id: `destroyed-observer-test`,
        queryClient: customQueryClient,
        queryKey: baseQueryKey,
        queryFn,
        getKey,
        startSync: true,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Mount: create and subscribe to a query
      const query1 = createLiveQueryCollection({
        query: (q) => q.from({ item: collection }).select(({ item }) => item),
      })

      await query1.preload()

      // Wait for initial data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
      })
      expect(queryFn).toHaveBeenCalledTimes(1)

      // Unmount: cleanup the query, triggering subscriberCount -> 0
      // This calls unsubscribeFromQueries() which destroys observers
      await query1.cleanup()
      await flushPromises()

      // At this point, observer.destroy() was called but observer is still in state.observers

      // Remount quickly (before gcTime expires): cache should still be valid
      const query2 = createLiveQueryCollection({
        query: (q) => q.from({ item: collection }).select(({ item }) => item),
      })

      // BUG: subscribeToQueries() tries to subscribe to the destroyed observer
      // QueryObserver.destroy() is terminal - reactivation isn't guaranteed
      // This breaks cache processing on remount

      await query2.preload()

      // EXPECTED: Should process cached data immediately without refetch
      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
      })
      expect(queryFn).toHaveBeenCalledTimes(1) // No refetch!

      // BUG SYMPTOM: If destroyed observer doesn't process cached results,
      // collection will be empty or queryFn will be called again
    })

    it(`should not leak data when unsubscribing while load is in flight`, async () => {
      // Test the edge case where the last subscriber unsubscribes before queryFn resolves.
      // We need to ensure that:
      // 1. No late-arriving data is written after unsubscribe
      // 2. No rows leak back into the collection

      const baseQueryKey = [`in-flight-unsubscribe-test`]
      const items: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
      ]

      // Create a delayed queryFn that we can control
      let resolveQuery: ((value: Array<TestItem>) => void) | undefined
      const queryFnPromise = new Promise<Array<TestItem>>((resolve) => {
        resolveQuery = resolve
      })
      const queryFn = vi.fn().mockReturnValue(queryFnPromise)

      const customQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            gcTime: 5 * 60 * 1000,
            staleTime: 0,
            retry: false,
          },
        },
      })

      const config: QueryCollectionConfig<TestItem> = {
        id: `in-flight-unsubscribe-test`,
        queryClient: customQueryClient,
        queryKey: baseQueryKey,
        queryFn,
        getKey,
        startSync: true,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Create a live query and start loading
      const query1 = createLiveQueryCollection({
        query: (q) => q.from({ item: collection }).select(({ item }) => item),
      })

      // Start preload but don't await - this triggers the queryFn
      const preloadPromise = query1.preload()

      // Wait a bit to ensure queryFn has been called
      await flushPromises()
      expect(queryFn).toHaveBeenCalledTimes(1)
      expect(collection.size).toBe(0) // No data yet

      // Unsubscribe while the query is still in flight (before queryFn resolves)
      await query1.cleanup()
      await flushPromises()

      // Collection should be empty after cleanup
      expect(collection.size).toBe(0)

      // Now resolve the query - this is the "late-arriving data"
      resolveQuery!(items)
      await flushPromises()

      // CRITICAL: After the late-arriving data is processed, the collection
      // should still be empty. No rows should leak back in.
      expect(collection.size).toBe(0)

      // Clean up
      try {
        await preloadPromise
      } catch {
        // Query was cancelled, this is expected
      }
    })

    it(`hydration must not strip active in-memory query owners when persisted metadata is out of date`, async () => {
      // Deterministic regression test for the desync that
      // getHydratedOwnedRowsForQueryBaseline used to cause: it OVERWROTE
      // rowToQueries[rowKey] with persisted owners, silently evicting any
      // query that held ownership in-memory only. queryToRows was left
      // untouched, so the two maps desynced and cleanupQueryInternal later
      // deleted rows still needed by an active query.
      //
      // Reproduction:
      //   1. Query A fetches a brand-new row. Inside its applySuccessfulResult
      //      loop the row is inserted via ctx.write; that insert clobbers the
      //      metadata entry that setPersistedOwners wrote earlier in the same
      //      transaction (see sync.ts row insert path). Net result after A:
      //        - in-memory  rowToQueries[row1] = { A }
      //        - persisted  row1 metadata      = <empty>
      //   2. Query B fetches the SAME row with a different predicate. Because
      //      row1 already exists in syncedData, ctx.write runs an update
      //      (which does NOT clobber metadata) and setPersistedOwners
      //      survives. Net result after B:
      //        - in-memory  rowToQueries[row1] = { A, B }
      //        - persisted  row1 metadata      = { B }     (A was never persisted)
      //   3. Query C subscribes with an unmatched predicate (0 results).
      //      Because queryToRows.get(C) is undefined, its applySuccessfulResult
      //      enters getHydratedOwnedRowsForQueryBaseline, which iterates
      //      syncedData, sees row1's persisted owners = { B }, and (pre-fix)
      //      rowToQueries.set(row1, new Set({ B })) — wiping A.
      //   4. Tear down Query B. cleanupQueryInternal consults rowToQueries:
      //      only B tracked → nextOwners is empty → row1 is deleted from
      //      syncedData, even though Query A is still subscribed.
      const baseQueryKey = [`hydration-strip-regression`]

      type Row = CategorisedItem
      // Pre-seed `server` with a row in each category so that
      //   - predicate category='A' returns [row1]
      //   - predicate category='AB' (query B) also returns [row1]  ← shared
      //   - predicate category='C' returns []
      const row1: Row = { id: `1`, name: `Shared row`, category: `A` }
      const server: Array<Row & { extraTags?: Array<string> }> = [
        { ...row1, extraTags: [`A`, `AB`] },
      ]

      const matchesA = (where: any) => isCategory(`A`, where)
      const matchesAB = (where: any) =>
        where?.type === `func` &&
        where.name === `eq` &&
        where.args?.[0]?.path?.[0] === `category` &&
        where.args?.[1]?.value === `AB`
      const matchesC = (where: any) => isCategory(`C`, where)

      const queryFn = vi.fn().mockImplementation((context: any) => {
        const where = context.meta?.loadSubsetOptions?.where
        if (matchesA(where)) {
          return Promise.resolve(
            server
              .filter((i) => i.extraTags?.includes(`A`))
              .map(({ extraTags: _extraTags, ...r }) => r),
          )
        }
        if (matchesAB(where)) {
          return Promise.resolve(
            server
              .filter((i) => i.extraTags?.includes(`AB`))
              .map(({ extraTags: _extraTags, ...r }) => r),
          )
        }
        if (matchesC(where)) {
          return Promise.resolve([])
        }
        return Promise.resolve(
          server.map(({ extraTags: _extraTags, ...r }) => r),
        )
      })

      const collection = createCollection(
        queryCollectionOptions<Row>({
          id: `hydration-strip-regression`,
          queryClient,
          queryKey: (ctx) => {
            if (ctx.where) {
              return [...baseQueryKey, ctx.where]
            }
            return baseQueryKey
          },
          queryFn,
          getKey,
          startSync: true,
          syncMode: `on-demand`,
        }),
      ) as Collection<Row>

      // Step 1 — Query A loads row1 (fresh insert → persisted metadata for
      // row1 ends up empty because ctx.write({type:'insert'}) clobbers it).
      const queryA = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await queryA.preload()
      await vi.waitFor(() => expect(collection.has(`1`)).toBe(true))

      // Step 2 — Query B also matches row1 via a different predicate. Because
      // row1 already exists in syncedData, B's applySuccessfulResult takes
      // the update path (not insert) and setPersistedOwners(row1, {B})
      // survives the commit. In-memory ownership for row1 is now {A, B}.
      const queryB = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            // Match row1 via a different predicate literal. The queryFn
            // filters by the server-side tag so this matches row1 too.
            .where(({ item }) => eq(item.category, `AB`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await queryB.preload()
      await flushPromises()

      // Step 3 — Query C subscribes with an empty-result predicate. Its
      // applySuccessfulResult must enter getHydratedOwnedRowsForQueryBaseline
      // (because queryToRows has no entry for C yet). Pre-fix that function
      // reads persisted row1 owners = {B} and overwrites rowToQueries[row1],
      // stripping A.
      const queryC = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `C`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })
      await queryC.preload()
      await flushPromises()

      // Step 4 — Tear down Query B. Pre-fix, rowToQueries[row1] is now {B},
      // so removing B leaves nextOwners empty and row1 is deleted from
      // syncedData even though Query A still owns it in queryToRows[A].
      // Post-fix, the merge in getHydratedOwnedRowsForQueryBaseline preserves
      // A, so removing B leaves nextOwners = {A} and row1 survives.
      await queryB.cleanup()
      await flushPromises()

      expect(collection.has(`1`)).toBe(true)
      expect(collection.size).toBeGreaterThan(0)
    })
  })

  describe(`Cache Persistence on Remount`, () => {
    it(`should process cached results immediately when QueryObserver resubscribes`, async () => {
      const queryKey = [`remount-cache-test`]
      const items: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
        { id: `3`, name: `Item 3` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      // Use a longer gcTime to simulate cache persistence
      const customQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            gcTime: 5 * 60 * 1000, // 5 minutes
            staleTime: 0,
            retry: false,
          },
        },
      })

      const config: QueryCollectionConfig<TestItem> = {
        id: `remount-cache-test`,
        queryClient: customQueryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Create first live query and load data
      const query1 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      await query1.preload()

      // Wait for data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(3)
        expect(queryFn).toHaveBeenCalledTimes(1)
      })

      // Verify all items are present before creating second query
      expect(collection.has(`1`)).toBe(true)
      expect(collection.has(`2`)).toBe(true)
      expect(collection.has(`3`)).toBe(true)

      // Create second live query while first is still active
      // This simulates multiple components using the same collection
      // (e.g., list view and detail view both querying the same collection)
      const query2 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      // Preload - this should use cached data and process it immediately
      await query2.preload()
      await flushPromises()

      // queryFn should still only have been called once (using cache)
      // This verifies the fix: QueryObserver processes cached results immediately
      expect(queryFn).toHaveBeenCalledTimes(1)

      // Data should be present in both queries
      expect(collection.size).toBe(3)
      expect(collection.has(`1`)).toBe(true)
      expect(collection.has(`2`)).toBe(true)
      expect(collection.has(`3`)).toBe(true)

      // Cleanup
      await query1.cleanup()
      await query2.cleanup()
      customQueryClient.clear()
    })

    it(`should preserve cache and avoid refetch during quick remount`, async () => {
      const queryKey = [`preserve-cache-remount`]
      const items: Array<TestItem> = [{ id: `1`, name: `Item 1` }]

      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `preserve-cache-remount`,
        queryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Create and load first query
      const query1 = createLiveQueryCollection({
        query: (q) => q.from({ item: collection }),
      })

      await query1.preload()

      await vi.waitFor(() => {
        expect(collection.size).toBe(1)
        expect(queryFn).toHaveBeenCalledTimes(1)
      })

      // Create second query while first is still active (simulating remount)
      // In real-world React, the first component unmounts but cleanup is deferred
      const query2 = createLiveQueryCollection({
        query: (q) => q.from({ item: collection }),
      })

      await query2.preload()
      await flushPromises()

      // Cache should still be present in the collection
      expect(collection.size).toBe(1)

      // We should NOT have refetched (used TanStack Query cache)
      expect(queryFn).toHaveBeenCalledTimes(1)

      // Cleanup both
      await query1.cleanup()
      await query2.cleanup()
    })

    it(`should allow TanStack Query to manage cache lifecycle via gcTime`, async () => {
      const queryKey = [`gctime-respect-test`]
      const items: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      // Use a longer gcTime to verify cache isn't prematurely removed
      const customQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            gcTime: 5 * 60 * 1000, // 5 minutes
            staleTime: 0,
            retry: false,
          },
        },
      })

      const config: QueryCollectionConfig<TestItem> = {
        id: `gctime-respect-test`,
        queryClient: customQueryClient,
        queryKey,
        queryFn,
        getKey,
        startSync: true,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // First mount
      const query1 = createLiveQueryCollection({
        query: (q) => q.from({ item: collection }),
      })

      await query1.preload()
      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
        expect(queryFn).toHaveBeenCalledTimes(1)
      })

      // Create second query while first is active (simulating overlapping mount)
      const query2 = createLiveQueryCollection({
        query: (q) => q.from({ item: collection }),
      })

      await query2.preload()
      await flushPromises()

      // Should still use cache - no refetch
      expect(queryFn).toHaveBeenCalledTimes(1)
      expect(collection.size).toBe(2)

      // Cleanup both
      await query1.cleanup()
      await query2.cleanup()
      customQueryClient.clear()
    })

    it(`should not immediately remove query data from cache when live query is GCed (respects gcTime)`, async () => {
      // Create a QueryClient with a longer cacheTime to test that data should persist
      const testQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            staleTime: Infinity, // set an Infinity staleTime to prevent a refetch
            gcTime: 300,
            retry: false,
          },
        },
      })

      const queryKey = [`premature-gc-test`]
      const items: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      // Use on-demand mode so the query is only created when the live query needs it
      // This ensures the subscription is passed when the query is created
      const config: QueryCollectionConfig<TestItem> = {
        id: `premature-gc-test`,
        queryClient: testQueryClient,
        queryKey,
        queryFn,
        getKey,
        syncMode: `on-demand`, // Use on-demand mode so query is created with subscription
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Create a live query that uses the collection
      // This creates a subscription that will trigger the unsubscribed event when cleaned up
      const liveQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      // Preload the live query - this will create the query with the subscription
      await liveQuery.preload()

      // Wait for data to load
      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalledTimes(1)
        expect(collection.size).toBe(2)
      })

      // Verify query data is in the cache
      const cachedData = testQueryClient.getQueryData(
        queryKey,
      ) as Array<TestItem>
      expect(cachedData).toBeDefined()
      expect(cachedData).toEqual(items)

      // Cleanup the live query - this triggers the unsubscribed event
      await liveQuery.cleanup()

      // Wait 100ms, the gcTime is set to 300ms, so data should remain in the cache
      await new Promise((resolve) => setTimeout(resolve, 100))

      // Data should remain in cache until gcTime elapses
      const cachedDataAfterCleanup = testQueryClient.getQueryData(queryKey)
      expect(cachedDataAfterCleanup).toBeDefined()
      expect(cachedDataAfterCleanup).toEqual(items)

      // Wait an additional 250ms to be sure the gcTime elapsed
      await new Promise((resolve) => setTimeout(resolve, 250))

      // Data should be removed from cache after gcTime elapses
      const cachedDataAfterCacheTime = testQueryClient.getQueryData(queryKey)
      expect(cachedDataAfterCacheTime).toBeUndefined()

      // Cleanup
      testQueryClient.clear()
    })
  })

  describe(`Static queryKey with on-demand mode`, () => {
    it(`should automatically append serialized predicates to static queryKey in on-demand mode`, async () => {
      const items: Array<CategorisedItem> = [
        { id: `1`, name: `Item 1`, category: `A` },
        { id: `2`, name: `Item 2`, category: `A` },
        { id: `3`, name: `Item 3`, category: `B` },
        { id: `4`, name: `Item 4`, category: `B` },
      ]

      const queryFn = vi.fn((ctx: QueryFunctionContext) => {
        const loadSubsetOptions = ctx.meta?.loadSubsetOptions
        // Filter items based on the where clause if present
        if (loadSubsetOptions?.where) {
          // Simple mock filtering - in real use, you'd use parseLoadSubsetOptions
          return Promise.resolve(items)
        }
        return Promise.resolve(items)
      })

      const staticQueryKey = [`static-on-demand-test`]

      const config: QueryCollectionConfig<CategorisedItem> = {
        id: `static-on-demand-test`,
        queryClient,
        queryKey: staticQueryKey, // Static queryKey (not a function)
        queryFn,
        getKey: (item: CategorisedItem) => item.id,
        syncMode: `on-demand`,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Collection should start empty with on-demand sync mode
      expect(collection.size).toBe(0)

      // Create first live query with category A filter
      const queryA = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => item),
      })

      await queryA.preload()

      // Wait for first query to load
      await vi.waitFor(() => {
        expect(collection.size).toBeGreaterThan(0)
      })

      // Verify queryFn was called
      expect(queryFn).toHaveBeenCalledTimes(1)
      const firstCall = queryFn.mock.calls[0]?.[0]
      expect(firstCall?.meta?.loadSubsetOptions).toBeDefined()

      // Create second live query with category B filter
      const queryB = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `B`))
            .select(({ item }) => item),
      })

      await queryB.preload()

      // Wait for second query to trigger another queryFn call
      await vi.waitFor(() => {
        expect(queryFn).toHaveBeenCalledTimes(2)
      })

      // Verify the second call has different loadSubsetOptions
      const secondCall = queryFn.mock.calls[1]?.[0]
      expect(secondCall?.meta?.loadSubsetOptions).toBeDefined()

      // The two queries should have triggered separate cache entries
      // because the static queryKey was automatically extended with serialized predicates
      expect(queryFn).toHaveBeenCalledTimes(2)

      // Cleanup
      await queryA.cleanup()
      await queryB.cleanup()
    })

    it(`should create same cache key for identical predicates with static queryKey`, async () => {
      const items: Array<CategorisedItem> = [
        { id: `1`, name: `Item 1`, category: `A` },
        { id: `2`, name: `Item 2`, category: `A` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<CategorisedItem> = {
        id: `static-identical-predicates-test`,
        queryClient,
        queryKey: [`identical-test`],
        queryFn,
        getKey: (item: CategorisedItem) => item.id,
        syncMode: `on-demand`,
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Create two live queries with identical predicates
      const query1 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => item),
      })

      const query2 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => item),
      })

      await query1.preload()
      await query2.preload()

      await vi.waitFor(() => {
        expect(collection.size).toBeGreaterThan(0)
      })

      // Should only call queryFn once because identical predicates
      // should produce the same serialized cache key
      expect(queryFn).toHaveBeenCalledTimes(1)

      // Cleanup
      await query1.cleanup()
      await query2.cleanup()
    })

    it(`should work correctly in eager mode with static queryKey (no automatic serialization)`, async () => {
      const items: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      const config: QueryCollectionConfig<TestItem> = {
        id: `static-eager-test`,
        queryClient,
        queryKey: [`eager-test`],
        queryFn,
        getKey,
        syncMode: `eager`, // Eager mode should NOT append predicates
        startSync: true,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Wait for initial load
      await vi.waitFor(() => {
        expect(collection.size).toBe(items.length)
      })

      // Should call queryFn once with empty predicates
      expect(queryFn).toHaveBeenCalledTimes(1)
      const call = queryFn.mock.calls[0]?.[0]
      expect(call?.meta?.loadSubsetOptions).toEqual({})
    })
  })

  describe(`On-demand collection directWrite cache update`, () => {
    it(`should update query cache for all active query keys when using writeUpdate with computed queryKey`, async () => {
      // Ensures writeUpdate on on-demand collections with computed query keys
      // updates all active cache keys to prevent data loss on remount

      const items: Array<CategorisedItem> = [
        { id: `1`, name: `Item 1`, category: `A` },
        { id: `2`, name: `Item 2`, category: `A` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      // Use a custom queryClient with longer gcTime to prevent cache from being removed
      const customQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            gcTime: 5 * 60 * 1000, // 5 minutes
            staleTime: Infinity, // Prevent refetch
            retry: false,
          },
        },
      })

      // Function-based queryKey (computed) - the bug scenario
      const config: QueryCollectionConfig<CategorisedItem> = {
        id: `directwrite-computed-key-test`,
        queryClient: customQueryClient,
        queryKey: (opts) => {
          // Computed key includes predicate info
          if (opts.where) {
            return [`directwrite-test`, JSON.stringify(opts.where)]
          }
          return [`directwrite-test`]
        },
        queryFn,
        getKey: (item) => item.id,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Create a live query that will load data with a specific where clause
      const query1 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      await query1.preload()

      // Wait for data to load
      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
      })

      // Perform a direct write update
      collection.utils.writeUpdate({ id: `1`, name: `Updated Item 1` })

      // Verify the collection reflects the update
      expect(collection.get(`1`)?.name).toBe(`Updated Item 1`)

      // IMPORTANT: Simulate remount by cleaning up and recreating the live query
      // This is where the bug manifests - the updated data should persist
      await query1.cleanup()
      await flushPromises()

      // Recreate the same live query (simulating component remount)
      const query2 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      await query2.preload()

      // Wait for data to be available
      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
      })

      // BUG ASSERTION: After remount, the updated data should persist
      // With the bug, this will fail because writeUpdate updated the wrong cache key
      // and on remount, the stale cached data is loaded instead
      expect(collection.get(`1`)?.name).toBe(`Updated Item 1`)

      // Cleanup
      await query2.cleanup()
      customQueryClient.clear()
    })

    it(`should update query cache for static queryKey with where clause in on-demand mode`, async () => {
      // Scenario: static queryKey + on-demand mode + where clause
      // The where clause causes a computed query key to be generated

      const items: Array<CategorisedItem> = [
        { id: `1`, name: `Item 1`, category: `A` },
        { id: `2`, name: `Item 2`, category: `A` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      const customQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            gcTime: 5 * 60 * 1000,
            staleTime: Infinity,
            retry: false,
          },
        },
      })

      // Static queryKey but with on-demand mode, the where clause will append serialized predicates
      const config: QueryCollectionConfig<CategorisedItem> = {
        id: `directwrite-static-key-where-test`,
        queryClient: customQueryClient,
        queryKey: [`static-directwrite-test`],
        queryFn,
        getKey: (item) => item.id,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      // Create a live query with a where clause
      const query1 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      await query1.preload()

      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
      })

      // Perform a direct write update
      collection.utils.writeUpdate({ id: `1`, name: `Updated Item 1` })

      expect(collection.get(`1`)?.name).toBe(`Updated Item 1`)

      // Simulate remount
      await query1.cleanup()
      await flushPromises()

      const query2 = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `A`))
            .select(({ item }) => ({ id: item.id, name: item.name })),
      })

      await query2.preload()

      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
      })

      // After remount, the updated data should persist
      expect(collection.get(`1`)?.name).toBe(`Updated Item 1`)

      await query2.cleanup()
      customQueryClient.clear()
    })

    it(`should update query cache for function queryKey that returns constant value in on-demand mode`, async () => {
      // Scenario: function queryKey that returns same value
      // This creates an undefined entry in the cache

      const items: Array<TestItem> = [
        { id: `1`, name: `Item 1` },
        { id: `2`, name: `Item 2` },
      ]

      const queryFn = vi.fn().mockResolvedValue(items)

      const customQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            gcTime: 5 * 60 * 1000,
            staleTime: Infinity,
            retry: false,
          },
        },
      })

      // Function queryKey that always returns the same value
      const config: QueryCollectionConfig<TestItem> = {
        id: `directwrite-constant-fn-key-test`,
        queryClient: customQueryClient,
        queryKey: () => [`constant-fn-key-test`],
        queryFn,
        getKey,
        syncMode: `on-demand`,
      }

      const options = queryCollectionOptions(config)
      const collection = createCollection(options)

      const query1 = createLiveQueryCollection({
        query: (q) => q.from({ item: collection }).select(({ item }) => item),
      })

      await query1.preload()

      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
      })

      // Perform a direct write update
      collection.utils.writeUpdate({ id: `1`, name: `Updated Item 1` })

      expect(collection.get(`1`)?.name).toBe(`Updated Item 1`)

      // Simulate remount
      await query1.cleanup()
      await flushPromises()

      const query2 = createLiveQueryCollection({
        query: (q) => q.from({ item: collection }).select(({ item }) => item),
      })

      await query2.preload()

      await vi.waitFor(() => {
        expect(collection.size).toBe(2)
      })

      // After remount, the updated data should persist
      expect(collection.get(`1`)?.name).toBe(`Updated Item 1`)

      await query2.cleanup()
      customQueryClient.clear()
    })
  })

  describe(`rows from external sync sources`, () => {
    it(`should retain pre-hydrated rows when a disjoint query correctly returns empty results`, async () => {
      // Simulates a warm-start scenario where a persistence layer has already
      // hydrated "history" rows into the collection. Two disjoint queries
      // share the collection:
      //   - "history": returns the same rows (but with a server delay)
      //   - "live":    correctly returns [] (there are no live items yet)
      //
      // When the live query resolves first with its correct empty result,
      // the history rows should remain in the collection. The live query's
      // empty result only means there are no *live* items — it should not
      // affect rows from a different query's domain.

      const preHydratedItems: Array<CategorisedItem> = [
        { id: `1`, name: `History 1`, category: `history` },
        { id: `2`, name: `History 2`, category: `history` },
        { id: `3`, name: `History 3`, category: `history` },
      ]

      let resolveHistoryQueryFn!: (value: Array<CategorisedItem>) => void

      const isQueryCategory = (category: string, where: any): boolean => {
        return (
          where &&
          where.type === `func` &&
          where.name === `eq` &&
          where.args[0]?.path?.[0] === `category` &&
          where.args[1]?.value === category
        )
      }

      const queryFn = vi.fn().mockImplementation((ctx: any) => {
        const where = ctx.meta?.loadSubsetOptions?.where

        if (isQueryCategory(`history`, where)) {
          // History query: returns data, but the server is slow
          return new Promise<Array<CategorisedItem>>((resolve) => {
            resolveHistoryQueryFn = resolve
          })
        }

        if (isQueryCategory(`live`, where)) {
          // Live query: correctly returns empty — no live items exist yet
          return Promise.resolve([])
        }

        return Promise.resolve([])
      })

      const baseQueryKey = [`warm-start-disjoint-test`]

      const baseOptions = queryCollectionOptions<CategorisedItem>({
        id: `warm-start-disjoint-test`,
        queryClient,
        queryKey: (opts: any) => {
          if (opts.where) {
            return [...baseQueryKey, opts.where]
          }
          return baseQueryKey
        },
        queryFn,
        getKey: (item: CategorisedItem) => item.id,
        syncMode: `on-demand`,
        startSync: true,
      })

      const originalSync = baseOptions.sync
      const collection = createCollection({
        ...baseOptions,
        sync: {
          sync: (params: Parameters<typeof originalSync.sync>[0]) => {
            // Simulate a persistence layer hydrating rows from a previous
            // session on warm start, before the query layer initializes.
            params.begin({ immediate: true })
            for (const item of preHydratedItems) {
              params.write({ type: `insert`, value: item })
            }
            params.commit()

            return originalSync.sync(params)
          },
        },
      })

      // Verify the persistence layer's hydrated rows are present
      expect(collection.size).toBe(3)

      // Subscribe two disjoint queries — history (delayed) and live (immediate)
      const historyQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `history`)),
      })

      const liveQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ item: collection })
            .where(({ item }) => eq(item.category, `live`)),
      })

      // Trigger both queries. The history queryFn is pending; the live
      // queryFn resolves immediately with [].
      const historyPreload = historyQuery.preload()
      await liveQuery.preload()
      await flushPromises()

      // The live query correctly returned [] (no live items exist).
      // The pre-hydrated history rows should still be in the collection.
      expect(collection.size).toBe(3)
      expect(collection.has(`1`)).toBe(true)
      expect(collection.has(`2`)).toBe(true)
      expect(collection.has(`3`)).toBe(true)

      // Now the history query's server response arrives
      resolveHistoryQueryFn(preHydratedItems)
      await historyPreload

      // Collection should still have all history items
      expect(collection.size).toBe(3)

      await historyQuery.cleanup()
      await liveQuery.cleanup()
    })
  })

  describe(`Stale cache consistency`, () => {
    const sleep = (ms: number) =>
      new Promise((resolve) => setTimeout(resolve, ms))

    it(`should not re-insert deleted item when a destroyed query is recreated with stale cache`, async () => {
      const customQueryClient = new QueryClient({
        defaultOptions: {
          queries: {
            staleTime: Infinity,
            gcTime: Infinity,
            retry: false,
            refetchOnWindowFocus: false,
            refetchOnMount: false,
            refetchOnReconnect: false,
          },
        },
      })

      interface Assignment {
        id: number
        task_id: number
        resource_id: number
        hours_per_day: number
      }

      const MUTATION_DELAY = 50

      let serverItems: Array<Assignment> = [
        { id: 1, task_id: 10, resource_id: 1, hours_per_day: 8 },
        { id: 2, task_id: 10, resource_id: 2, hours_per_day: 4 },
        { id: 3, task_id: 20, resource_id: 3, hours_per_day: 8 },
      ]
      let nextId = 100

      const apiCreate = async (
        item: Omit<Assignment, 'id'>,
      ): Promise<Assignment> => {
        await sleep(MUTATION_DELAY)
        const created = { ...item, id: nextId++ }
        serverItems.push(created)
        return created
      }

      const apiDelete = async (id: number): Promise<void> => {
        await sleep(MUTATION_DELAY)
        serverItems = serverItems.filter((a) => a.id !== id)
      }

      const collection = createCollection(
        queryCollectionOptions<Assignment>({
          id: `stale-cache-${Date.now()}-${Math.random()}`,
          queryClient: customQueryClient,
          queryKey: ['stale-cache', String(Date.now()), String(Math.random())],
          queryFn: async () => [...serverItems],
          getKey: (item) => item.id,
          syncMode: 'on-demand',
          startSync: true,

          onInsert: async ({ transaction, collection: col }) => {
            const { id: _id, ...rest } = transaction.mutations[0].modified
            const serverItem = await apiCreate(rest)
            col.utils.writeInsert(serverItem)
            return { refetch: false }
          },

          onDelete: async ({ transaction, collection: col }) => {
            const id = transaction.mutations[0].key as number
            await apiDelete(id)
            col.utils.writeDelete(id)
            return { refetch: false }
          },
        }),
      )

      // Always-active queries
      const taskQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ assignment: collection })
            .where(({ assignment }) => inArray(assignment.task_id, [10])),
      })
      await taskQuery.preload()

      const projectQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ assignment: collection })
            .where(({ assignment }) => eq(assignment.task_id, 10)),
      })
      await projectQuery.preload()

      await vi.waitFor(() => {
        expect(collection.size).toBe(3)
      })

      // Step 1: Toggle ON → add item → toggle OFF
      let workloadQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ assignment: collection })
            .where(({ assignment }) =>
              inArray(assignment.resource_id, [1, 2, 3, 4]),
            ),
      })
      await workloadQuery.preload()

      collection.insert({
        id: -1,
        task_id: 10,
        resource_id: 4,
        hours_per_day: 8,
      })

      workloadQuery.cleanup()
      workloadQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ assignment: collection })
            .where(({ assignment }) =>
              inArray(assignment.resource_id, [1, 2, 4]),
            ),
      })
      await workloadQuery.preload()
      await flushPromises()
      await sleep(MUTATION_DELAY + 50)
      await flushPromises()

      const carolId = 100
      expect(collection.has(carolId)).toBe(true)

      // Step 2: Delete
      collection.delete(carolId)

      workloadQuery.cleanup()
      workloadQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ assignment: collection })
            .where(({ assignment }) => inArray(assignment.resource_id, [1, 2])),
      })
      await workloadQuery.preload()
      await flushPromises()
      await sleep(MUTATION_DELAY + 50)
      await flushPromises()

      expect(collection.has(carolId)).toBe(false)
      expect(collection._state.syncedData.has(carolId)).toBe(false)

      // Step 3: Toggle ON again (stale cache)
      workloadQuery.cleanup()
      workloadQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ assignment: collection })
            .where(({ assignment }) =>
              inArray(assignment.resource_id, [1, 2, 3, 4]),
            ),
      })
      await workloadQuery.preload()
      await flushPromises()

      // Step 4: Re-add → toggle OFF
      const t2 = collection.insert({
        id: -2,
        task_id: 10,
        resource_id: 4,
        hours_per_day: 8,
      })

      workloadQuery.cleanup()
      workloadQuery = createLiveQueryCollection({
        query: (q) =>
          q
            .from({ assignment: collection })
            .where(({ assignment }) =>
              inArray(assignment.resource_id, [1, 2, 4]),
            ),
      })
      await workloadQuery.preload()
      await flushPromises()

      await t2.isPersisted.promise
      await flushPromises()
      await sleep(50)

      // The deleted item (id=100) must NOT be in syncedData
      expect(collection._state.syncedData.has(carolId)).toBe(false)

      // The new item (id=101) should exist
      expect(collection.has(101)).toBe(true)

      // Only one assignment with resource_id=4
      const allItems = Array.from(collection.values())
      const carolAssignments = allItems.filter((a) => a.resource_id === 4)
      expect(carolAssignments).toHaveLength(1)
      expect(carolAssignments[0]?.id).toBe(101)

      expect(collection.size).toBe(4)

      workloadQuery.cleanup()
      taskQuery.cleanup()
      projectQuery.cleanup()
      customQueryClient.clear()
    })
  })
})