Fix #307: memory leak in __len__ and __contains__ view implementation (#309)

Author: asvetlov

docs/changes.rst

@@ -1,5 +1,10 @@
 .. _changes:
 
+4.5.2 (2018-11-28)
+------------------
+
+* Fix another memory leak introduced by 4.5.0 release (:pr:`307`)
+
 4.5.1 (2018-11-22)
 ------------------
 

multidict/_multidict_views.c

@@ -84,11 +84,14 @@ multidict_view_clear(_Multidict_ViewObject *self)
 static Py_ssize_t
 multidict_view_len(_Multidict_ViewObject *self)
 {
+    Py_ssize_t ret;
     PyObject *impl = _PyObject_CallMethodId(self->md, &PyId_impl, NULL);
     if (impl == NULL) {
         return 0;
     }
-    return pair_list_len(impl);
+    ret = pair_list_len(impl);
+    Py_DECREF(impl);
+    return ret;
 }
 
 static PyObject *
@@ -374,11 +377,14 @@ static PyMethodDef multidict_keysview_methods[] = {
 static int
 multidict_keysview_contains(_Multidict_ViewObject *self, PyObject *key)
 {
+    int ret;
     PyObject *impl = _PyObject_CallMethodId(self->md, &PyId_impl, NULL);
     if (impl == NULL) {
         return -1;
     }
-    return pair_list_contains(impl, key);
+    ret = pair_list_contains(impl, key);
+    Py_DECREF(impl);
+    return ret;
 }
 
 static PySequenceMethods multidict_keysview_as_sequence = {

requirements/wheel.txt

@@ -1,4 +1,4 @@
-cython==0.29
+cython==0.29.1
 pytest==4.0.0
 pytest-cov==2.6.0