Merge pull request #54 from cpp-best-practices/clang-tidy-clang-cl

Author: aminya

.clang-tidy

@@ -1,41 +1,19 @@
 ---
-Checks:
-'-*,
-  cert-*,-cert-err58-cpp,
-  clang-diagnostic-*,
-  clang-analyzer-*,
-  hicpp-*,-hicpp-avoid-c-arrays,-hicpp-no-array-decay,hicpp-explicit-*,-hicpp-use-equals-default,-hicpp-signed-bitwise,-hicpp-special-member-functions,-hicpp-use-equals-delete,
-  misc-*,-misc-non-private-member-variables-in-classes,
-  modernize-*,modernize-use-*,modernize-avoid-c-arrays,-modernize-use-trailing-return-type,
-  performance-*,
-  portability-*,
-  readablity-*,
-'
-WarningsAsErrors: 'clang-analyzer-*'
-HeaderFilterRegex: '.*\.hpp$'
-AnalyzeTemporaryDtors: false
-FormatStyle:     file
-User:            klein_cl
-CheckOptions:
-  - key:             google-readability-braces-around-statements.ShortStatementLines
-    value:           '1'
-  - key:             google-readability-function-size.StatementThreshold
-    value:           '800'
-  - key:             google-readability-namespace-comments.ShortNamespaceLines
-    value:           '10'
-  - key:             google-readability-namespace-comments.SpacesBeforeComments
-    value:           '2'
-  - key:             modernize-loop-convert.MaxCopySize
-    value:           '16'
-  - key:             modernize-loop-convert.MinConfidence
-    value:           reasonable
-  - key:             modernize-loop-convert.NamingStyle
-    value:           CamelCase
-  - key:             modernize-pass-by-value.IncludeStyle
-    value:           llvm
-  - key:             modernize-replace-auto-ptr.IncludeStyle
-    value:           llvm
-  - key:             modernize-use-nullptr.NullMacros
-    value:           'NULL'
-...
-
+Checks: "*,
+        -abseil-*,
+        -altera-*,
+        -android-*,
+        -fuchsia-*,
+        -google-*,
+        -llvm*,
+        -modernize-use-trailing-return-type,
+        -zircon-*,
+        -readability-else-after-return,
+        -readability-static-accessed-through-instance,
+        -readability-avoid-const-params-in-decls,
+        -cppcoreguidelines-non-private-member-variables-in-classes,
+        -misc-non-private-member-variables-in-classes,
+"
+WarningsAsErrors: ''
+HeaderFilterRegex: ''
+FormatStyle:     none

src/StaticAnalyzers.cmake

@@ -8,7 +8,10 @@ macro(enable_cppcheck)
         --enable=style,performance,warning,portability
         --inline-suppr
         --inconclusive)
-    if(${CMAKE_CXX_STANDARD})
+    if(NOT
+       "${CMAKE_CXX_STANDARD}"
+       STREQUAL
+       "")
       set(CMAKE_CXX_CPPCHECK ${CMAKE_CXX_CPPCHECK} --std=c++${CMAKE_CXX_STANDARD})
     endif()
     if(WARNINGS_AS_ERRORS)
@@ -31,11 +34,20 @@ macro(enable_clang_tidy)
         SEND_ERROR
           "clang-tidy cannot be enabled with non-clang compiler and PCH, clang-tidy fails to handle gcc's PCH file")
     endif()
-
+    # construct the clang-tidy command line
     set(CMAKE_CXX_CLANG_TIDY ${CLANGTIDY} -extra-arg=-Wno-unknown-warning-option)
-    if(${CMAKE_CXX_STANDARD})
-      set(CMAKE_CXX_CLANG_TIDY ${CMAKE_CXX_CLANG_TIDY} -extra-arg=-std=c++${CMAKE_CXX_STANDARD})
+    # set standard
+    if(NOT
+       "${CMAKE_CXX_STANDARD}"
+       STREQUAL
+       "")
+      if("${CMAKE_CXX_CLANG_TIDY_DRIVER_MODE}" STREQUAL "cl")
+        set(CMAKE_CXX_CLANG_TIDY ${CMAKE_CXX_CLANG_TIDY} -extra-arg=/std:c++${CMAKE_CXX_STANDARD})
+      else()
+        set(CMAKE_CXX_CLANG_TIDY ${CMAKE_CXX_CLANG_TIDY} -extra-arg=-std=c++${CMAKE_CXX_STANDARD})
+      endif()
     endif()
+    # set warnings as errors
     if(WARNINGS_AS_ERRORS)
       list(APPEND CMAKE_CXX_CLANG_TIDY -warnings-as-errors=*)
     endif()

test/main.cpp

@@ -27,4 +27,7 @@ int main() {
   // trigger address sanitizer
   // int *p = nullptr;
   // *p = 1;
+
+  // trigger compiler warnings, clang-tidy, and cppcheck
+  int a;
 }