feat: support cuda warnings in project_warnings

Author: aminya

README.md

@@ -99,6 +99,7 @@ It gets the following named parameters (each accepting multiple values):
 - `MSVC_WARNINGS`: Override the defaults for the MSVC warnings
 - `CLANG_WARNINGS`: Override the defaults for the CLANG warnings
 - `GCC_WARNINGS`: Override the defaults for the GCC warnings
+- `CUDA_WARNINGS`: Override the defaults for the CUDA warnings
 - `CONAN_OPTIONS`: Extra Conan options
 
 ## `run_vcpkg` function
@@ -122,15 +123,15 @@ A very useful function that accepts the same arguments as `target_link_libraries
 
 Similar to `target_include_directories`, but it suppresses the warnings. It is useful if you want to include some external directories directly.
 
-## `find_and_link_cuda` function
+## `target_link_cuda` function
 
-A function that links Cuda to the given target. This function automatically links the compiler warnings, so do not link `project_warnings` with your target.
+A function that links Cuda to the given target.
 
 ```cmake
 add_executable(main_cuda main.cu)
 target_compile_features(main_cuda PRIVATE cxx_std_17)
-target_link_libraries(main_cuda PRIVATE project_options)
-find_and_link_cuda(main_cuda)
+target_link_libraries(main_cuda PRIVATE project_options project_warnings)
+target_link_cuda(main_cuda)
 ```
 
 ## Changing the project_options parameters dynamically

src/CompilerWarnings.cmake

@@ -8,7 +8,8 @@ function(
   WARNINGS_AS_ERRORS
   MSVC_WARNINGS
   CLANG_WARNINGS
-  GCC_WARNINGS)
+  GCC_WARNINGS
+  CUDA_WARNINGS)
   if(NOT ${MSVC_WARNINGS})
     set(MSVC_WARNINGS
         /W4 # Baseline reasonable warnings
@@ -69,23 +70,44 @@ function(
     )
   endif()
 
+  if(NOT ${CUDA_WARNINGS})
+    set(CUDA_WARNINGS
+        -Wall
+        -Wextra
+        -Wunused
+        -Wconversion
+        -Wshadow
+        # TODO add more Cuda warnings
+    )
+  endif()
+
   if(WARNINGS_AS_ERRORS STREQUAL TRUE)
     message(AUTHOR_WARNING "NOTE: WARNINGS_AS_ERRORS=${WARNINGS_AS_ERRORS}")
     list(APPEND CLANG_WARNINGS -Werror)
     list(APPEND GCC_WARNINGS -Werror)
     list(APPEND MSVC_WARNINGS /WX)
   endif()
 
-  if(MSVC)
-    set(PROJECT_WARNINGS ${MSVC_WARNINGS})
-  elseif(CMAKE_CXX_COMPILER_ID MATCHES ".*Clang")
-    set(PROJECT_WARNINGS ${CLANG_WARNINGS})
-  elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-    set(PROJECT_WARNINGS ${GCC_WARNINGS})
-  else()
+  if(NOT MSVC
+     AND NOT
+         CMAKE_CXX_COMPILER_ID
+         MATCHES
+         ".*Clang"
+     AND NOT
+         CMAKE_CXX_COMPILER_ID
+         STREQUAL
+         "GNU")
     message(AUTHOR_WARNING "No compiler warnings set for '${CMAKE_CXX_COMPILER_ID}' compiler.")
   endif()
 
-  target_compile_options(${project_name} INTERFACE ${PROJECT_WARNINGS})
+  target_compile_options(
+    ${project_name}
+    INTERFACE $<$<COMPILE_LANG_AND_ID:CXX,Clang>:${CLANG_WARNINGS}>
+              $<$<COMPILE_LANG_AND_ID:C,Clang>:${CLANG_WARNINGS}>
+              $<$<COMPILE_LANG_AND_ID:CXX,GNU>:${GCC_WARNINGS}>
+              $<$<COMPILE_LANG_AND_ID:C,GNU>:${GCC_WARNINGS}>
+              $<$<COMPILE_LANG_AND_ID:CXX,MSVC>:${MSVC_WARNINGS}>
+              $<$<COMPILE_LANG_AND_ID:C,MSVC>:${MSVC_WARNINGS}>
+              $<$<COMPILE_LANGUAGE:CUDA>:${CUDA_WARNINGS}>)
 
 endfunction()

src/Cuda.cmake

@@ -1,13 +1,13 @@
-# ! find_and_link_cuda
-# A function that links Cuda to the given target. This function automatically links the compiler warnings, so do not link `project_warnings` with your target.
+# ! target_link_cuda
+# A function that links Cuda to the given target
 #
 # # Example
 # add_executable(main_cuda main.cu)
 # target_compile_features(main_cuda PRIVATE cxx_std_17)
-# target_link_libraries(main_cuda PRIVATE project_options)
-# find_and_link_cuda(main_cuda)
+# target_link_libraries(main_cuda PRIVATE project_options project_warnings)
+# target_link_cuda(main_cuda)
 #
-macro(find_and_link_cuda target)
+macro(target_link_cuda target)
   # optional named CUDA_WARNINGS
   set(oneValueArgs CUDA_WARNINGS)
   cmake_parse_arguments(
@@ -38,14 +38,4 @@ macro(find_and_link_cuda target)
     # so that the static cuda runtime can find it at runtime.
     set_property(TARGET ${target} PROPERTY BUILD_RPATH ${CMAKE_CUDA_IMPLICIT_LINK_DIRECTORIES})
   endif()
-
-  if(${_cuda_args_CUDA_WARNINGS} STREQUAL "")
-    target_compile_options(
-      ${target}
-      PRIVATE -Wall
-              -Wextra
-              -Wunused
-              -Wconversion
-              -Wshadow)
-  endif()
 endmacro()

src/Index.cmake

@@ -36,6 +36,7 @@ include("${ProjectOptions_SRC_DIR}/Cuda.cmake")
 # - MSVC_WARNINGS: Override the defaults for the MSVC warnings
 # - CLANG_WARNINGS: Override the defaults for the CLANG warnings
 # - GCC_WARNINGS: Override the defaults for the GCC warnings
+# - CUDA_WARNINGS: Override the defaults for the CUDA warnings
 # - CONAN_OPTIONS: Extra Conan options
 #
 # NOTE: cmake-lint [C0103] Invalid macro name "project_options" doesn't match `[0-9A-Z_]+`
@@ -115,7 +116,8 @@ macro(project_options)
     "${WARNINGS_AS_ERRORS}"
     "${ProjectOptions_MSVC_WARNINGS}"
     "${ProjectOptions_CLANG_WARNINGS}"
-    "${ProjectOptions_GCC_WARNINGS}")
+    "${ProjectOptions_GCC_WARNINGS}"
+    "${ProjectOptions_CUDA_WARNINGS}")
 
   include("${ProjectOptions_SRC_DIR}/Tests.cmake")
   if(${ProjectOptions_ENABLE_COVERAGE})