Skip to content

Commit dbdaef9

Browse files
committed
fix: fix warnings not being set
1 parent bd688c8 commit dbdaef9

1 file changed

Lines changed: 7 additions & 9 deletions

File tree

src/CompilerWarnings.cmake

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function(
1010
CLANG_WARNINGS
1111
GCC_WARNINGS
1212
CUDA_WARNINGS)
13-
if(NOT ${MSVC_WARNINGS})
13+
if("${MSVC_WARNINGS}" STREQUAL "")
1414
set(MSVC_WARNINGS
1515
/W4 # Baseline reasonable warnings
1616
/w14242 # 'identifier': conversion from 'type1' to 'type1', possible loss of data
@@ -38,7 +38,7 @@ function(
3838
)
3939
endif()
4040

41-
if(NOT ${CLANG_WARNINGS})
41+
if("${CLANG_WARNINGS}" STREQUAL "")
4242
set(CLANG_WARNINGS
4343
-Wall
4444
-Wextra # reasonable and standard
@@ -59,7 +59,7 @@ function(
5959
)
6060
endif()
6161

62-
if(NOT ${GCC_WARNINGS})
62+
if("${GCC_WARNINGS}" STREQUAL "")
6363
set(GCC_WARNINGS
6464
${CLANG_WARNINGS}
6565
-Wmisleading-indentation # warn if indentation implies blocks where blocks do not exist
@@ -70,7 +70,7 @@ function(
7070
)
7171
endif()
7272

73-
if(NOT ${CUDA_WARNINGS})
73+
if("${CUDA_WARNINGS}" STREQUAL "")
7474
set(CUDA_WARNINGS
7575
-Wall
7676
-Wextra
@@ -103,15 +103,13 @@ function(
103103
set(PROJECT_WARNINGS_C "${PROJECT_WARNINGS_CXX}")
104104

105105
set(PROJECT_WARNINGS_CUDA "${CUDA_WARNINGS}")
106-
106+
107107
target_compile_options(
108108
${project_name}
109-
INTERFACE
110-
# C++ warnings
111-
$<$<COMPILE_LANGUAGE:CXX>:${PROJECT_WARNINGS_CXX}>
109+
INTERFACE # C++ warnings
110+
$<$<COMPILE_LANGUAGE:CXX>:${PROJECT_WARNINGS_CXX}>
112111
# C warnings
113112
$<$<COMPILE_LANGUAGE:C>:${PROJECT_WARNINGS_C}>
114113
# Cuda warnings
115114
$<$<COMPILE_LANGUAGE:CUDA>:${PROJECT_WARNINGS_CUDA}>)
116-
117115
endfunction()

0 commit comments

Comments
 (0)