Skip to content

feat: Add missing type to Struct #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Divyanshu-s13 wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: Add missing type to Struct #340

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8354f7c
Fix: Updated LICENSE reference to LICENSE.txt
Nov 17, 2025
5552226
Fix:[JS] Strong typing for builders
Nov 17, 2025
a11a307
remove unused file
Nov 18, 2025
5621b52
Merge branch 'main' into strong-typing-for-builders
Divyanshu-s13 Nov 18, 2025
e86951c
chore: remove unnecessary is-relative dependency
Nov 19, 2025
0525b22
original yarn.lock
Nov 19, 2025
b784274
fix: resolve TypeScript compilation errors in strong-typing-for-builders
Nov 20, 2025
5fd1900
fix cli failure and fix issue #90
Nov 20, 2025
2ad4fac
added a test case
Nov 20, 2025
531a67b
restore: re-add eslint.config.js
Nov 20, 2025
957d656
chore: add Apache 2.0 license header to struct-builder test
Nov 20, 2025
c7d5c6b
fix yarn.lock
Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ export class List<T extends DataType = any> extends DataType<Type.List, { [0]: T
/** @ignore */
export interface Struct<T extends TypeMap = any> extends DataType<Type.Struct, T> {
TArray: Array<StructRowProxy<T>>;
TValue: StructRowProxy<T>;
TValue: StructRowProxy<T> | { [P in keyof T]: T[P]['TValue'] };
dataTypes: T;
}

Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop

@kou kou Nov 19, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this change?

Original file line number Diff line number Diff line change
Expand Up @@ -6649,4 +6649,4 @@ yocto-queue@^0.1.0:
zstd-codec@0.1.5:
version "0.1.5"
resolved "https://registry.yarnpkg.com/zstd-codec/-/zstd-codec-0.1.5.tgz#c180193e4603ef74ddf704bcc835397d30a60e42"
integrity sha512-v3fyjpK8S/dpY/X5WxqTK3IoCnp/ZOLxn144GZVlNUjtwAchzrVo03h+oMATFhCIiJ5KTr4V3vDQQYz4RU684g==
integrity sha512-v3fyjpK8S/dpY/X5WxqTK3IoCnp/ZOLxn144GZVlNUjtwAchzrVo03h+oMATFhCIiJ5KTr4V3vDQQYz4RU684g==

@kou kou Nov 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert this change?

Loading