Skip to content

Commit 652d7cb

Browse files
authored
Merge pull request #37834 from apache/cp-37668
Cherrypick #37668
2 parents 7d657b7 + 1ee624f commit 652d7cb

6 files changed

Lines changed: 22 additions & 15 deletions

File tree

sdks/python/apache_beam/ml/inference/gemini_inference.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
from typing import Any
2323
from typing import Optional
2424
from typing import Union
25+
from typing import cast
2526

2627
from google import genai
2728
from google.genai import errors
@@ -73,7 +74,7 @@ def generate_from_string(
7374
call.
7475
"""
7576
return model.models.generate_content(
76-
model=model_name, contents=batch, **inference_args)
77+
model=model_name, contents=cast(Any, batch), **inference_args)
7778

7879

7980
def generate_image_from_strings_and_images(
@@ -96,7 +97,7 @@ def generate_image_from_strings_and_images(
9697
call.
9798
"""
9899
return model.models.generate_content(
99-
model=model_name, contents=batch, **inference_args)
100+
model=model_name, contents=cast(Any, batch), **inference_args)
100101

101102

102103
class GeminiModelHandler(RemoteModelHandler[Any, PredictionResult,

sdks/python/apache_beam/ml/rag/embeddings/vertex_ai_test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,12 @@
1616

1717
"""Tests for apache_beam.ml.rag.embeddings.vertex_ai."""
1818

19-
import pytest
2019
import shutil
2120
import tempfile
2221
import unittest
2322

23+
import pytest
24+
2425
import apache_beam as beam
2526
from apache_beam.ml.rag.types import Chunk
2627
from apache_beam.ml.rag.types import Content

sdks/python/apache_beam/ml/rag/ingestion/milvus_search_it_test.py

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,6 @@
2222
from typing import cast
2323

2424
import pytest
25-
from pymilvus import CollectionSchema
26-
from pymilvus import DataType
27-
from pymilvus import FieldSchema
28-
from pymilvus import MilvusClient
29-
from pymilvus.exceptions import MilvusException
30-
from pymilvus.milvus_client import IndexParams
3125

3226
import apache_beam as beam
3327
from apache_beam.ml.rag.ingestion.jdbc_common import WriteConfig
@@ -41,11 +35,21 @@
4135
from apache_beam.ml.rag.utils import unpack_dataclass_with_kwargs
4236
from apache_beam.testing.test_pipeline import TestPipeline
4337

38+
# pylint: disable=wrong-import-order, wrong-import-position, ungrouped-imports
4439
try:
40+
from pymilvus import CollectionSchema
41+
from pymilvus import DataType
42+
from pymilvus import FieldSchema
43+
from pymilvus import MilvusClient
44+
from pymilvus.exceptions import MilvusException
45+
from pymilvus.milvus_client import IndexParams
46+
4547
from apache_beam.ml.rag.ingestion.milvus_search import MilvusVectorWriterConfig
4648
from apache_beam.ml.rag.ingestion.milvus_search import MilvusWriteConfig
47-
except ImportError as e:
48-
raise unittest.SkipTest(f'Milvus dependencies not installed: {str(e)}')
49+
PYMILVUS_AVAILABLE = True
50+
except ImportError:
51+
PYMILVUS_AVAILABLE = False
52+
# pylint: enable=wrong-import-order, wrong-import-position, ungrouped-imports
4953

5054

5155
def _construct_index_params():
@@ -158,6 +162,7 @@ def drop_collection(client: MilvusClient, collection_name: str):
158162

159163

160164
@pytest.mark.require_docker_in_docker
165+
@unittest.skipIf(not PYMILVUS_AVAILABLE, 'pymilvus is not installed.')
161166
@unittest.skipUnless(
162167
platform.system() == "Linux",
163168
"Test runs only on Linux due to lack of support, as yet, for nested "

sdks/python/apache_beam/ml/transforms/base_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@
5151
import PIL
5252
from PIL.Image import Image as PIL_Image
5353
except ImportError:
54-
PIL = None
55-
PIL_Image = Any
54+
PIL = None # type: ignore[assignment]
55+
PIL_Image = Any # type: ignore[misc, assignment]
5656

5757
try:
5858

sdks/python/apache_beam/ml/transforms/embeddings/huggingface_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
try:
5454
from PIL import Image
5555
except ImportError:
56-
Image = None
56+
Image = None # type: ignore[assignment]
5757

5858
_HF_TOKEN = os.environ.get('HF_INFERENCE_TOKEN')
5959
test_query = "This is a test"

sdks/python/apache_beam/ml/transforms/embeddings/tensorflow_hub_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
from apache_beam.ml.transforms.embeddings.tensorflow_hub import TensorflowHubImageEmbeddings
5353
except ImportError:
5454
TensorflowHubImageEmbeddings = None # type: ignore
55-
Image = None
55+
Image = None # type: ignore[assignment]
5656

5757

5858
@unittest.skipIf(

0 commit comments

Comments
 (0)