From b3f1bcd520a45e8f3e647560abd9caf149d03b27 Mon Sep 17 00:00:00 2001 From: Ahmed Abualsaud Date: Fri, 17 Apr 2026 11:43:33 -0400 Subject: [PATCH 1/3] Include insert error in log message --- .../io/gcp/bigquery/StorageApiWriteUnshardedRecords.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java index 2fe10453e256..c736a419c361 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java @@ -760,7 +760,11 @@ long flush( error.getRowIndexToErrorMessage().get(failedIndex), tableDestination.getTableReference()); } catch (Exception e) { - LOG.error("Failed to insert row and could not parse the result!", e); + String msg = + String.format( + "Failed to insert row and could not parse the result! Insert error: %s", + error.getRowIndexToErrorMessage().get(failedIndex)); + LOG.error(msg, e); } // output outside try {} clause to avoid suppress downstream Exception if (element != null) { From c1f38c13f7c26fb405a47961ff33c55964e80feb Mon Sep 17 00:00:00 2001 From: Ahmed Abualsaud Date: Tue, 21 Apr 2026 13:16:37 -0400 Subject: [PATCH 2/3] use constant message --- .../io/gcp/bigquery/StorageApiWriteUnshardedRecords.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java index c736a419c361..d50b9d2d5b7d 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java @@ -760,11 +760,10 @@ long flush( error.getRowIndexToErrorMessage().get(failedIndex), tableDestination.getTableReference()); } catch (Exception e) { - String msg = - String.format( - "Failed to insert row and could not parse the result! Insert error: %s", - error.getRowIndexToErrorMessage().get(failedIndex)); - LOG.error(msg, e); + LOG.error( + "Failed to insert row and could not parse the result! Insert error: {}.\n Parse error: {}", + error.getRowIndexToErrorMessage().get(failedIndex), + e); } // output outside try {} clause to avoid suppress downstream Exception if (element != null) { From fccaa15e94bf9cb8bdd215884a51e84da9ac7d32 Mon Sep 17 00:00:00 2001 From: Ahmed Abualsaud Date: Tue, 21 Apr 2026 14:35:17 -0400 Subject: [PATCH 3/3] fix placeholder --- .../sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java index d50b9d2d5b7d..1320f24e984c 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java @@ -761,7 +761,7 @@ long flush( tableDestination.getTableReference()); } catch (Exception e) { LOG.error( - "Failed to insert row and could not parse the result! Insert error: {}.\n Parse error: {}", + "Failed to insert row and could not parse the result! Insert error: {}.", error.getRowIndexToErrorMessage().get(failedIndex), e); }