Skip to content

branch-4.2: [test](fe) Enable debug points for NestedGroup session default test - #70756

Open
eldenmoon wants to merge 1 commit into
apache:branch-4.2from
eldenmoon:branch-pick-70639-4.2-20261119
Open

eldenmoon wants to merge 1 commit into
apache:branch-4.2from
eldenmoon:branch-pick-70639-4.2-20261119

Conversation

@eldenmoon

Copy link
Copy Markdown
Member

cherry-pick #70639

Conflicts in VariantEscapeTableTest.java were resolved by keeping the Config import needed for enable_debug_points.

…pache#70639)

VARIANT tables with escaped dotted keys reject NestedGroup columns. The
parser only applies the test-only `default_variant_*` session variables
when debug points are enabled.

Issue Number: None
Related PR: apache#70501 (added the debug-point gate for VARIANT session
defaults)
PR Type: Test

Problem Summary:

`VariantEscapeTableTest.testNestedGroupFinalTypeIsForbidden` sets the
NestedGroup session default without enabling debug points. The parser
therefore uses the built-in default, creates the table, and the
expected-exception assertion fails. Enable debug points for the
session-default case and restore both the original configuration and
session value in `finally`.

- **Failure:** The original test fails at the `nested_default` CREATE
TABLE assertion with "Expected java.lang.Exception to be thrown, but
nothing was thrown."
- **Cause:** The test did not enable the debug-point gate introduced by
- **Stability evidence:** The failure was reproduced on master before
the change. After the change, the complete test class and the adjacent
parser and CREATE TABLE LIKE test classes pass. Both modified values are
restored even if the assertion fails.

On the remote Linux development worktree:

- Before the fix: `./run-fe-ut.sh --run
org.apache.doris.catalog.VariantEscapeTableTest#testNestedGroupFinalTypeIsForbidden`
fails at the expected-exception assertion.
- After the fix: `./run-fe-ut.sh --run
org.apache.doris.catalog.VariantEscapeTableTest,org.apache.doris.catalog.CreateTableLikeTest,org.apache.doris.nereids.parser.NereidsParserTest`
passes all 115 tests (9 + 14 + 92), with no failures, errors, or skips.
- `PATH=~/agent-bin:$PATH build-support/clang-format.sh` completes
successfully.
- `mvn checkstyle:check -pl fe-core` reports 0 violations.

None.

- Behavior changed: No
- Does this need documentation: No
- Pre-submission status: Ready

- Tool: OpenAI Codex
- Generated: Test fix and PR description.
- Human review: Not yet performed.

(cherry picked from commit 25de3bf)
@eldenmoon
eldenmoon requested a review from yiguolei as a code owner November 19, 2026 09:59
@eldenmoon

Copy link
Copy Markdown
Member Author

run buildall

@eldenmoon

Copy link
Copy Markdown
Member Author

run compile

1 similar comment
@eldenmoon

Copy link
Copy Markdown
Member Author

run compile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant