Repository navigation
Conversation
…pache#70639) VARIANT tables with escaped dotted keys reject NestedGroup columns. The parser only applies the test-only `default_variant_*` session variables when debug points are enabled. Issue Number: None Related PR: apache#70501 (added the debug-point gate for VARIANT session defaults) PR Type: Test Problem Summary: `VariantEscapeTableTest.testNestedGroupFinalTypeIsForbidden` sets the NestedGroup session default without enabling debug points. The parser therefore uses the built-in default, creates the table, and the expected-exception assertion fails. Enable debug points for the session-default case and restore both the original configuration and session value in `finally`. - **Failure:** The original test fails at the `nested_default` CREATE TABLE assertion with "Expected java.lang.Exception to be thrown, but nothing was thrown." - **Cause:** The test did not enable the debug-point gate introduced by - **Stability evidence:** The failure was reproduced on master before the change. After the change, the complete test class and the adjacent parser and CREATE TABLE LIKE test classes pass. Both modified values are restored even if the assertion fails. On the remote Linux development worktree: - Before the fix: `./run-fe-ut.sh --run org.apache.doris.catalog.VariantEscapeTableTest#testNestedGroupFinalTypeIsForbidden` fails at the expected-exception assertion. - After the fix: `./run-fe-ut.sh --run org.apache.doris.catalog.VariantEscapeTableTest,org.apache.doris.catalog.CreateTableLikeTest,org.apache.doris.nereids.parser.NereidsParserTest` passes all 115 tests (9 + 14 + 92), with no failures, errors, or skips. - `PATH=~/agent-bin:$PATH build-support/clang-format.sh` completes successfully. - `mvn checkstyle:check -pl fe-core` reports 0 violations. None. - Behavior changed: No - Does this need documentation: No - Pre-submission status: Ready - Tool: OpenAI Codex - Generated: Test fix and PR description. - Human review: Not yet performed. (cherry picked from commit 25de3bf)
Member
Author
|
run buildall |
Member
Author
|
run compile |
1 similar comment
Member
Author
|
run compile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #70639
Conflicts in VariantEscapeTableTest.java were resolved by keeping the Config import needed for enable_debug_points.