Repository navigation
Fix the integration test cluster and window test expectations - #9152
Merged
Merged
Conversation
- worker.childopts in the integration storm.yaml still used Java 8 GC logging flags, so no worker JVM could start on Java 9+. Use the unified -Xlog syntax and drop storm-java9.yaml, which was only appended for JDK 11. - The window tests asserted IllegalArgumentException for invalid sizes but then went on to build the topology again, failing with the same exception. Return after the assertion.
TopoWrap fetches worker logs from http://<host>:8000, but the logviewer has disabled its HTTP binding by default since 2018, so every window test failed with Connection refused.
The binary assembly builds public/ from storm-webapp/target/classes/WEB-INF. The Integration-Test job only downloads the built jars, so that directory was missing, the distribution had no public/, and the UI and logviewer failed to start. Unpack WEB-INF from the storm-webapp jar first.
The log date pattern carries no zone, so ZonedDateTime.parse failed for every decorated log line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9151. Before surefire 3.6.0, the integration-test job ran 0 TestNG tests, so the suite had broken without anyone noticing. With this PR, all 37 integration tests run against a real cluster and pass (about 11 minutes).
Fixes, in the order they surfaced:
worker.childoptsinintegration-test/config/storm.yamlused Java 8 GC logging flags (-XX:+PrintGCDateStamps,-Xloggc, …), so the worker JVM refused to start on Java 25. It now uses the unified-Xlog:gc*syntax.storm-java9.yaml, only appended for JDK 11, is removed.testTumbleTimeand bothSlidingWindowTesttests assertedIllegalArgumentException, then built the topology anyway. They now return after the assertion.http://<host>:8000, butlogviewer.disable.http.bindingdefaults totrue. It is enabled for the integration cluster only.public/fromstorm-webapp/target/classes/WEB-INF, which the Integration-Test job never builds (it only downloads the jars).run-it.shnow unpacksWEB-INFfrom the storm-webapp jar before packaging the distribution. This also fixes the long-standing "Cannot find static file directory … .jarWEB-INF" UI crash in CI. Release builds run the full reactor and are not affected.DecoratedLogLineparsed zone-less timestamps withZonedDateTime.parse. The formatter now uses UTC.(The
node1host resolution fix went in with #9151.)