diff --git a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx index c0aa70ea66d9..f60adb41028d 100644 --- a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx +++ b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx @@ -281,11 +281,7 @@ const config: ControlPanelConfig = { { controls, datasource, form_data }: ControlPanelState, controlState: ControlState, ) => ({ - columns: datasource?.columns[0]?.hasOwnProperty('filterable') - ? (datasource as Dataset)?.columns?.filter( - (c: ColumnMeta) => c.filterable, - ) - : datasource?.columns, + columns: datasource?.columns || [], savedMetrics: defineSavedMetrics(datasource), // current active adhoc metrics selectedMetrics: diff --git a/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/columns.tsx b/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/columns.tsx index bd7d30a139f3..5b234d6be638 100644 --- a/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/columns.tsx +++ b/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/columns.tsx @@ -20,8 +20,6 @@ import { ControlSetItem, ExtraControlProps, sharedControls, - Dataset, - ColumnMeta, } from '@superset-ui/chart-controls'; import { t } from '@apache-superset/core/translation'; import { ensureIsArray } from '@superset-ui/core'; @@ -35,11 +33,7 @@ const dndAllColumns: typeof sharedControls.groupby = { mapStateToProps({ datasource, controls }, controlState) { const newState: ExtraControlProps = {}; if (datasource) { - if (datasource?.columns[0]?.hasOwnProperty('filterable')) { - newState.options = (datasource as Dataset)?.columns?.filter( - (c: ColumnMeta) => c.filterable, - ); - } else newState.options = datasource.columns; + newState.options = datasource.columns || []; } newState.queryMode = getQueryMode(controls); newState.externalValidationErrors = diff --git a/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/metrics.tsx b/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/metrics.tsx index de33013527ba..7eeecd4d2401 100644 --- a/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/metrics.tsx +++ b/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/metrics.tsx @@ -21,8 +21,6 @@ import { ControlSetItem, ControlState, sharedControls, - Dataset, - ColumnMeta, defineSavedMetrics, } from '@superset-ui/chart-controls'; import { t } from '@apache-superset/core/translation'; @@ -77,11 +75,7 @@ export const metricsControlSetItem: ControlSetItem = { { controls, datasource, form_data }: ControlPanelState, controlState: ControlState, ) => ({ - columns: datasource?.columns[0]?.hasOwnProperty('filterable') - ? (datasource as Dataset)?.columns?.filter( - (c: ColumnMeta) => c.filterable, - ) - : datasource?.columns, + columns: datasource?.columns || [], savedMetrics: defineSavedMetrics(datasource), // current active adhoc metrics selectedMetrics: diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx index 2787fed15a1a..381459076a64 100644 --- a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx +++ b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx @@ -304,11 +304,7 @@ const config: ControlPanelConfig = { { controls, datasource, form_data }: ControlPanelState, controlState: ControlState, ) => ({ - columns: datasource?.columns[0]?.hasOwnProperty('filterable') - ? (datasource as Dataset)?.columns?.filter( - (c: ColumnMeta) => c.filterable, - ) - : datasource?.columns, + columns: datasource?.columns || [], savedMetrics: defineSavedMetrics(datasource), // current active adhoc metrics selectedMetrics: