Remove ignores for GLV feature tests that either no longer exist or now pass (#3275)

Remove ignores for GLV feature tests that either no longer exist or now pass. Changed a SideEffectCap.feature test to double escape quotes for nested map (similar to ElementMap.feature) so that it can be properly handled by python.

Author: andreachild

gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs

@@ -53,10 +53,6 @@ public class GherkinTestRunner
                 {"g_withStrategiesXProductiveByStrategyX_V_group_byXageX", IgnoreReason.NullKeysInMapNotSupported},
                 {"g_withStrategiesXProductiveByStrategyX_V_groupCount_byXageX", IgnoreReason.NullKeysInMapNotSupported},
                 {"g_withStrategiesXProductiveByStrategyX_V_group_byXageX_byXnameX", IgnoreReason.NullKeysInMapNotSupported},
-                {"g_withoutStrategiesXCountStrategyX_V_count", IgnoreReason.NoReason}, // needs investigation
-                {"g_withoutStrategiesXLazyBarrierStrategyX_V_asXlabelX_aggregateXlocal_xX_selectXxX_selectXlabelX", IgnoreReason.NoReason},
-                // error from P.typeOf() construction causes request deserialization errors that hangs in .NET, solution TBD
-                {"g_V_valuesXageX_isXtypeOfXnon_registered_NameXX", IgnoreReason.NoReason},
             };
 
         private static class Keywords

gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js

@@ -79,6 +79,7 @@ const ignoreReason = {
   needsFurtherInvestigation: '',
 };
 
+// An associative array for ignored feature tests containing the scenario name as key
 const ignoredScenarios = {
   // javascript doesn't have subgraph() step yet
   'g_VX1X_outEXknowsX_subgraphXsgX_name_capXsgX': new IgnoreError(ignoreReason.subgraphStepNotSupported),
@@ -97,12 +98,8 @@ const ignoredScenarios = {
   'g_VX1X_outE_inV_bothE_otherV_tree': new IgnoreError(ignoreReason.treeStepNotSupported),
   'g_VX1X_outE_inV_bothE_otherV_tree_byXnameX_byXlabelX': new IgnoreError(ignoreReason.treeStepNotSupported),
   'g_V_out_treeXaX_selectXaX_countXlocalX': new IgnoreError(ignoreReason.treeStepNotSupported),
-  'g_V_out_order_byXnameX_localXtreeXaX_selectXaX_countXlocalXX': new IgnoreError(ignoreReason.treeStepNotSupported),
-  // An associative array containing the scenario name as key, for example:
-  'g_withStrategiesXProductiveByStrategyX_V_groupCount_byXageX': new IgnoreError(ignoreReason.nullKeysInMapNotSupportedWell),
-  'g_V_shortestPath_edgesIncluded': new IgnoreError(ignoreReason.needsFurtherInvestigation),
-  'g_V_shortestPath_edgesIncluded_edgesXoutEX': new IgnoreError(ignoreReason.needsFurtherInvestigation),
-  'g_V_shortestpath': new IgnoreError(ignoreReason.needsFurtherInvestigation),
+  'g_V_out_order_byXnameX_localXtreeXaX_selectXaX_countXlocalXX': new IgnoreError(ignoreReason.treeStepNotSupported), 
+   // floating point issues
   'g_withSackXBigInteger_TEN_powX1000X_assignX_V_localXoutXknowsX_barrierXnormSackXX_inXknowsX_barrier_sack': new IgnoreError(ignoreReason.floatingPointIssues),
   'g_withSackX2X_V_sackXdivX_byXconstantX4_0XX_sack': new IgnoreError(ignoreReason.floatingPointIssues),
 };

gremlin-python/src/main/python/radish/feature_steps.py

@@ -37,7 +37,6 @@
 tail = __.tail
 
 ignores = [
-    "g.V().choose(has(T.label, \"person\"),values(\"age\").groupCount(\"a\"), values(\"name\").groupCount(\"b\")).cap(\"a\", \"b\").unfold()", # uses embedded Map in assertion
     "g.withSideEffect(\"x\",{}).V().both().both().sideEffect(__.store(\"x\").by(\"name\")).cap(\"x\").unfold()", # Objects must be both of Map or Collection: a=LinkedHashMap b=BulkSet???
     "g.withSack(10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000n, Operator.assign).V().local(__.out(\"knows\").barrier(Barrier.normSack)).in(\"knows\").barrier().sack()" # issues with BigInteger/BigDecimal - why do we carry BigDecimal? just use python Decimal module?
 ]

gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/sideEffect/SideEffectCap.feature

@@ -161,8 +161,8 @@ Feature: Step - cap()
     When iterated to list
     Then the result should be unordered
       | result |
-      | m[{"a":"m[{\"d[32].i\":\"d[1].l\",\"d[35].i\":\"d[1].l\",\"d[27].i\":\"d[1].l\",\"d[29].i\":\"d[1].l\"}]"}] |
-      | m[{"b":"m[{\"ripple\":\"d[1].l\",\"lop\":\"d[1].l\"}]"}] |
+      | m[{"a":"m[{\\"d[32].i\\":\\"d[1].l\\",\\"d[35].i\\":\\"d[1].l\\",\\"d[27].i\\":\\"d[1].l\\",\\"d[29].i\\":\\"d[1].l\\"}]"}] |
+      | m[{"b":"m[{\\"ripple\\":\\"d[1].l\\",\\"lop\\":\\"d[1].l\\"}]"}] |
 
   # validates that a collecting barrier produces a filtering effect if it is unproductive.
   Scenario: g_V_hasXperson_name_withinXvadas_peterXX_groupXaX_by_byXout_orderX_capXaX