Skip to content

Commit 08cdd46

Browse files
cijothomascodeboten
authored andcommitted
chore: Remove redundant 'View name' entry from compliance matrix (open-telemetry#5043)
The compliance matrix entry "The name of the `View` can be specified" is misleading and redundant: 1. The spec defines `name` as a [stream configuration](./specification/metrics/sdk.md#stream-configuration) parameter that renames the output metric stream — **there is no concept of naming a View itself.** 2. This capability is already covered by the existing entry: "The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream." 3. The redundancy caused contradictory compliance statuses in some languages (e.g. Go marked `-` for the removed entry but `+` for the broader one). **Changes:** - Remove "The name of the `View` can be specified" from `spec-compliance-matrix/template.yaml` and all 12 language YAML files - Regenerate `spec-compliance-matrix.md` Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
1 parent 92417db commit 08cdd46

14 files changed

Lines changed: 0 additions & 26 deletions

File tree

spec-compliance-matrix.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@ formats is required. Implementing more than one format is optional.
144144
| The `View` instrument selection criteria is as specified. | | + | + | + | + | + | + | + | + | + | + | | - |
145145
| The `View` instrument selection criteria supports wildcards. | X | + | + | + | + | + | - | | + | + | + | | - |
146146
| The `View` instrument selection criteria supports the match-all wildcard. | | + | + | + | + | + | + | | + | + | + | | - |
147-
| The name of the `View` can be specified. | | - | + | + | + | + | + | + | | + | + | | - |
148147
| The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream. | | + | + | + | + | | + | + | + | + | - | | - |
149148
| The `View` allows configuring excluded attribute keys of resulting metric stream. | | + | | + | | | - | | | | | | - |
150149
| The `View` allows configuring the exemplar reservoir of resulting metric stream. | X | + | - | - | - | | - | | | | - | | - |

spec-compliance-matrix/cpp.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,6 @@ sections:
255255
status: '+'
256256
- name: The `View` instrument selection criteria supports the match-all wildcard.
257257
status: '+'
258-
- name: The name of the `View` can be specified.
259-
status: '+'
260258
- name: The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream.
261259
status: '+'
262260
- name: The `View` allows configuring excluded attribute keys of resulting metric stream.

spec-compliance-matrix/dotnet.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,6 @@ sections:
255255
status: '+'
256256
- name: The `View` instrument selection criteria supports the match-all wildcard.
257257
status: '+'
258-
- name: The name of the `View` can be specified.
259-
status: '+'
260258
- name: The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream.
261259
status: '-'
262260
- name: The `View` allows configuring excluded attribute keys of resulting metric stream.

spec-compliance-matrix/erlang.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,6 @@ sections:
255255
status: '-'
256256
- name: The `View` instrument selection criteria supports the match-all wildcard.
257257
status: '+'
258-
- name: The name of the `View` can be specified.
259-
status: '+'
260258
- name: The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream.
261259
status: '+'
262260
- name: The `View` allows configuring excluded attribute keys of resulting metric stream.

spec-compliance-matrix/go.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,6 @@ sections:
255255
status: '+'
256256
- name: The `View` instrument selection criteria supports the match-all wildcard.
257257
status: '+'
258-
- name: The name of the `View` can be specified.
259-
status: '-'
260258
- name: The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream.
261259
status: '+'
262260
- name: The `View` allows configuring excluded attribute keys of resulting metric stream.

spec-compliance-matrix/java.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,6 @@ sections:
255255
status: '+'
256256
- name: The `View` instrument selection criteria supports the match-all wildcard.
257257
status: '+'
258-
- name: The name of the `View` can be specified.
259-
status: '+'
260258
- name: The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream.
261259
status: '+'
262260
- name: The `View` allows configuring excluded attribute keys of resulting metric stream.

spec-compliance-matrix/js.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,6 @@ sections:
255255
status: '+'
256256
- name: The `View` instrument selection criteria supports the match-all wildcard.
257257
status: '+'
258-
- name: The name of the `View` can be specified.
259-
status: '+'
260258
- name: The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream.
261259
status: '+'
262260
- name: The `View` allows configuring excluded attribute keys of resulting metric stream.

spec-compliance-matrix/kotlin.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,6 @@ sections:
255255
status: '-'
256256
- name: The `View` instrument selection criteria supports the match-all wildcard.
257257
status: '-'
258-
- name: The name of the `View` can be specified.
259-
status: '-'
260258
- name: The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream.
261259
status: '-'
262260
- name: The `View` allows configuring excluded attribute keys of resulting metric stream.

spec-compliance-matrix/php.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,6 @@ sections:
255255
status: '?'
256256
- name: The `View` instrument selection criteria supports the match-all wildcard.
257257
status: '?'
258-
- name: The name of the `View` can be specified.
259-
status: '+'
260258
- name: The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream.
261259
status: '+'
262260
- name: The `View` allows configuring excluded attribute keys of resulting metric stream.

spec-compliance-matrix/python.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,6 @@ sections:
255255
status: '+'
256256
- name: The `View` instrument selection criteria supports the match-all wildcard.
257257
status: '+'
258-
- name: The name of the `View` can be specified.
259-
status: '+'
260258
- name: The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream.
261259
status: '+'
262260
- name: The `View` allows configuring excluded attribute keys of resulting metric stream.

0 commit comments

Comments
 (0)