From 2aad108a4e3e42df151d9c520388f91bce1dac0e Mon Sep 17 00:00:00 2001 From: sksat Date: Thu, 8 Feb 2024 18:58:52 +0900 Subject: [PATCH 1/2] make reviewdog fail_on_error configurable --- .github/workflows/build.yml | 4 ++++ action-c2a-build/action.yml | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 781991a..faa3587 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -60,6 +60,9 @@ on: reviewdog_default_filter: type: string default: added + reviewdog_fail_on_error: + type: boolean + default: true secrets: GH_FEDERATION_ENDPOINT: required: false @@ -104,6 +107,7 @@ jobs: reviewdog_tool_name: clang-tidy -${{ matrix.warning }} reviewdog_reporter: ${{ (!contains(matrix.warning, 'Wextra') && inputs.reviewdog_default_reporter ) || 'github-check' }} reviewdog_filter_mode: ${{ (!contains(matrix.warning, 'Wextra') && inputs.reviewdog_default_filter ) || 'nofilter' }} + reviewdog_fail_on_error: ${{ inputs.reviewdog_fail_on_error }} build_linux32_cxx: if: inputs.build_as_cxx diff --git a/action-c2a-build/action.yml b/action-c2a-build/action.yml index 13a4694..2519075 100644 --- a/action-c2a-build/action.yml +++ b/action-c2a-build/action.yml @@ -44,6 +44,9 @@ inputs: reviewdog_filter_mode: type: string default: added + reviewdog_fail_on_error: + type: boolean + default: true runs: using: "composite" @@ -125,3 +128,4 @@ runs: reporter: ${{ inputs.reviewdog_reporter }} filter_mode: ${{ inputs.reviewdog_filter_mode }} workdir: ./c2a_user/${{ inputs.c2a_dir }}/build + fail_on_error: ${{ inputs.reviewdog_fail_on_error }} From 859b949bda82c2d19dc2efda555ed398a8ba397f Mon Sep 17 00:00:00 2001 From: sksat Date: Thu, 8 Feb 2024 19:02:38 +0900 Subject: [PATCH 2/2] disable fail_on_error in test-build workflow to avoid error from old C2A code --- .github/workflows/test-build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-build.yml b/.github/workflows/test-build.yml index a628ac3..48cae3a 100644 --- a/.github/workflows/test-build.yml +++ b/.github/workflows/test-build.yml @@ -33,3 +33,4 @@ jobs: build_as_cxx: true reviewdog_default_reporter: github-check reviewdog_default_filter: added + reviewdog_fail_on_error: false