term_from_resource: fix C++ compat#2364
Merged
Merged
Conversation
term_from_resource is a static inline in term.h and can be reached from C++ translation units, but refc_binary_add_refcount relies on C11 <stdatomic.h>, which C++ does not support. Use the extern "C" refc_binary_increment_refcount helper instead. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w28/fix-cpp-compat
branch
from
July 20, 2026 19:47
1e31a7b to
45377e0
Compare
bettio
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
term_from_resource is a static inline in term.h and can be reached from C++ translation units, but refc_binary_add_refcount relies on C11 <stdatomic.h>, which C++ does not support. Use the extern "C" refc_binary_increment_refcount helper instead.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later